Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910002 - net-firewall/ufw: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: net-firewall/ufw: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:57 UTC by Michał Górny
Modified: 2025-04-09 13:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:57:51 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:55 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:18 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2025-03-22 20:18:22 UTC
Absolutely final ping before I really start last riting stuff.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-23 01:39:35 UTC
parona, any chance you'd be willing to look at this one?
Comment 5 Larry the Git Cow gentoo-dev 2025-03-31 17:33:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8917e5a6de7a4e80556947da469f9a393886e1b7

commit 8917e5a6de7a4e80556947da469f9a393886e1b7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-31 17:31:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-31 17:32:01 +0000

    net-firewall/ufw: port to python-single-r1
    
    The package isn't suitable for PEP517, as it installs data files and
    it simply happens to be written in Python, rather than intending to be
    imported and so on.
    
    Unfortunately, for the remaining PEP517 holdouts, there's little pressure
    upstream for them to port to a proper build system yet, as while setuptools
    deprecated the `setup.py` entrypoint some time ago, there's no removal
    in sight yet, so the only pressing side is on Gentoo's where we want
    to cleanup distutils-r1's support for that.
    
    It was arguably a mistake to really have these packages use distutils-r1
    in the first place.
    
    The obvious workaround for now is to invoke setup.py manually w/ python-single-r1,
    and punt the question until setuptools removal of the entrypoint looks
    closer (at which time, other distros will be putting pressure on upstreams
    too). Of course, if at the time of such a setuptools change, the package
    is still not fixed, then we'd have to remove it.
    
    (The same issues apply to bug #923094 which isn't fixed by this, but
    hopefully won't be an actual problem until that aforementioned removal
    in setuptools itself of the other bits.)
    
    Bug: https://bugs.gentoo.org/923094
    Closes: https://bugs.gentoo.org/910002
    Signed-off-by: Sam James <sam@gentoo.org>

 net-firewall/ufw/ufw-0.36.1-r2.ebuild | 217 ++++++++++++++++++++++++++++++++++
 1 file changed, 217 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2025-04-09 13:47:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eccfb5e0a97179bb4a7080713bc21acc4ac6a9c4

commit eccfb5e0a97179bb4a7080713bc21acc4ac6a9c4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-04-09 13:43:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-09 13:46:54 +0000

    net-firewall/ufw: drop 0.36.1-r1
    
    Bug: https://bugs.gentoo.org/910002
    Bug: https://bugs.gentoo.org/952968
    Signed-off-by: Sam James <sam@gentoo.org>

 net-firewall/ufw/ufw-0.36.1-r1.ebuild | 209 ----------------------------------
 1 file changed, 209 deletions(-)