Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909998 - net-analyzer/fail2ban-1.1.0: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: net-analyzer/fail2ban-1.1.0: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:57 UTC by Michał Górny
Modified: 2025-04-09 13:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:57:47 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:54 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:19 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Anton Bolshakov 2024-03-14 00:31:35 UTC
On the relevant note, python 3.12 can be added, similar to what was done for Fedora:
https://github.com/fail2ban/fail2ban/issues/3487#issuecomment-1994628453
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-14 03:57:39 UTC
(In reply to Michał Górny from comment #2)
> Final ping.  Please note that we will not hesitate to last rite low profile
> packages over this.

I don't think it makes sense for us to have pushed everyone (including non-libraries) to use distutils-r1 and then yank out the path for non-PEP517.

If we're going to do that, we need way more time. Or we fork one of the cases into a separate eclass, which is probably what we should've done originally for PEP517 if this was the plan all along.
Comment 5 Larry the Git Cow gentoo-dev 2024-03-14 04:52:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0f6688522dd2809feccb3d691db98364b0919f0

commit f0f6688522dd2809feccb3d691db98364b0919f0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-14 04:26:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-14 04:51:37 +0000

    net-analyzer/fail2ban: enable py3.12
    
    Bug: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/fail2ban/fail2ban-1.0.2-r3.ebuild | 137 +++++++++++++++++++++++++
 net-analyzer/fail2ban/fail2ban-9999.ebuild     |  21 +++-
 2 files changed, 154 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=39d0940f078bdc5b1108da1ee10bbc94aea73e2b

commit 39d0940f078bdc5b1108da1ee10bbc94aea73e2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-14 04:45:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-14 04:49:32 +0000

    dev-python/aiosmtpd: new package, add 1.4.5
    
    Bug: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/aiosmtpd/Manifest              |  1 +
 dev-python/aiosmtpd/aiosmtpd-1.4.5.ebuild | 36 +++++++++++++++++++++++++++++++
 dev-python/aiosmtpd/metadata.xml          | 13 +++++++++++
 3 files changed, 50 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8219a0dc4e5294b74fdcb6d447f4e1601580916

commit d8219a0dc4e5294b74fdcb6d447f4e1601580916
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-14 04:18:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-14 04:49:31 +0000

    dev-python/pyasynchat: new package, add 1.0.4
    
    Bug: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/pyasynchat/Manifest                |  1 +
 dev-python/pyasynchat/metadata.xml            | 13 +++++++++++++
 dev-python/pyasynchat/pyasynchat-1.0.4.ebuild | 26 ++++++++++++++++++++++++++
 3 files changed, 40 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d123620a304ed68d4e07d74d1a38c5267dbdc8b1

commit d123620a304ed68d4e07d74d1a38c5267dbdc8b1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-14 04:16:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-14 04:49:31 +0000

    dev-python/pyasyncore: new package, add 1.0.4
    
    Bug: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/pyasyncore/Manifest                |  1 +
 dev-python/pyasyncore/metadata.xml            | 13 +++++++++++++
 dev-python/pyasyncore/pyasyncore-1.0.4.ebuild | 24 ++++++++++++++++++++++++
 3 files changed, 38 insertions(+)
Comment 6 Agostino Sarubbo gentoo-dev 2024-04-29 06:43:42 UTC
ci has reproduced this issue with version 1.1.0 - Updating summary.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2025-03-22 20:18:22 UTC
Absolutely final ping before I really start last riting stuff.
Comment 8 Larry the Git Cow gentoo-dev 2025-03-31 15:53:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3315537514a3457b3a43674bfe721aa4cff110e

commit c3315537514a3457b3a43674bfe721aa4cff110e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-31 15:47:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-31 15:52:41 +0000

    net-analyzer/fail2ban: port to python-single-r1
    
    The package isn't suitable for PEP517, as it installs data files and
    it simply happens to be written in Python, rather than intending to be
    imported and so on.
    
    Unfortunately, for the remaining PEP517 holdouts, there's little pressure
    upstream for them to port to a proper build system yet, as while setuptools
    deprecated the `setup.py` entrypoint some time ago, there's no removal
    in sight yet, so the only pressing side is on Gentoo's where we want
    to cleanup distutils-r1's support for that.
    
    It was arguably a mistake to really have these packages use distutils-r1
    in the first place.
    
    The obvious workaround for now is to invoke setup.py manually w/ python-single-r1,
    and punt the question until setuptools removal of the entrypoint looks
    closer (at which time, other distros will be putting pressure on upstreams
    too). Of course, if at the time of such a setuptools change, the package
    is still not fixed, then we'd have to remove it.
    
    (The same issues apply to bug #923080 which isn't fixed by this, but
    hopefully won't be an actual problem until that aforementioned removal
    in setuptools itself of the other bits.)
    
    Bug: https://bugs.gentoo.org/923080
    Closes: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/fail2ban/fail2ban-1.1.0-r3.ebuild | 147 +++++++++++++++++++++++++
 net-analyzer/fail2ban/fail2ban-9999.ebuild     |  29 +++--
 2 files changed, 166 insertions(+), 10 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2025-03-31 16:33:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf2cc5755453fc1d8e44ee02705407b2a055e6d2

commit cf2cc5755453fc1d8e44ee02705407b2a055e6d2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-31 16:28:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-31 16:31:52 +0000

    net-analyzer/fail2ban: add setuptools BDEPEND, drop debris
    
    Bug: https://bugs.gentoo.org/909998
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/fail2ban/fail2ban-1.1.0-r3.ebuild | 4 +++-
 net-analyzer/fail2ban/fail2ban-9999.ebuild     | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 10 Larry the Git Cow gentoo-dev 2025-04-09 13:47:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=417ab5d83ffaca2dee1928eafc3a38e0ad733b47

commit 417ab5d83ffaca2dee1928eafc3a38e0ad733b47
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-04-09 13:43:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-09 13:46:53 +0000

    net-analyzer/fail2ban: drop 1.1.0-r2
    
    Bug: https://bugs.gentoo.org/909998
    Bug: https://bugs.gentoo.org/952967
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/fail2ban/fail2ban-1.1.0-r2.ebuild | 138 -------------------------
 1 file changed, 138 deletions(-)