Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909996 - media-video/openshot: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: media-video/openshot: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Stefan Strogin
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:57 UTC by Michał Górny
Modified: 2024-04-07 15:24 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openshot-3.1.1-r1.ebuild patch (openshot-3.1.1-r1.patch,430 bytes, patch)
2024-03-28 17:57 UTC, Jesse Adelman
Details | Diff
libopenshot-0.3.2 corercted (?) with graphicsmagick support (libopenshot-0.3.2-r2.ebuild,2.46 KB, text/plain)
2024-04-02 07:37 UTC, Jakub Klawiter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:57:13 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:53 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:20 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-22 16:40:47 UTC
This one's high on last rite list because of distutils_install_for_testing use.
Comment 4 Larry the Git Cow gentoo-dev 2024-03-26 14:21:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a22680171a900fb1e3d70df0e533170b009b61f

commit 9a22680171a900fb1e3d70df0e533170b009b61f
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-03-26 14:10:48 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-03-26 14:21:20 +0000

    package.mask: Last rite media-video/openshot & libs
    
    Bug: https://bugs.gentoo.org/909996
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 5 Jesse Adelman 2024-03-28 17:57:15 UTC
Created attachment 888944 [details, diff]
openshot-3.1.1-r1.ebuild patch
Comment 6 Jesse Adelman 2024-03-28 17:59:32 UTC
Howdy. I'm an OpenShot user, so I've got an itch to scratch here. :) I've worked with ebuilds for a long time ago, and I was never a dev, so please forgive the ignorance. I tried the naive approach, and followed the migration path to PEP 517 as linked (thanks for that).

I tested this with the 'ebuild test' command, and used 'ebuild merge' and then smoke-tested the application. It ran, and I loaded a few files, showed some dialog boxes, etc.

Note that I did try to set 'DISTUTILS_USE_PEP517="setuptools"', but I got errors. I'm not sure if this is correct - please do let me know if I need to do more. Happy to share logs, and make adjustments. Thanks.
Comment 7 Jesse Adelman 2024-03-28 18:00:56 UTC
*I worked with ebuilds a long time ago, and I was never a dev, so please forgive the ignorance.
Comment 8 Giuseppe Foti 2024-03-29 22:45:55 UTC
I am an Openshot user too. I just wrote an email to the author, asking him if an upgrade to Qt6 is planned, notifying him of the imminent removal from Gentoo.
He replied that this will need to be done at some point in the near future and that he will discuss it with his team.
Maybe we could wait a little longer before removing the package and wait what happens upstream.
Comment 9 Jakub Klawiter 2024-04-02 07:37:10 UTC
Created attachment 889246 [details]
libopenshot-0.3.2 corercted (?) with graphicsmagick support

I don't have any experience here :D, but maybe this will be enough to just keep openshot in portage while we ate waiting for the next release and the correct ebuild?

I've added the graphicmagick USE flag and support to replace imagemagick with gmagick.