Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909991 - media-sound/gpodder: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: media-sound/gpodder: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard: fixed in 3.11.4-r1
Keywords: PATCH, PullRequest
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:57 UTC by Michał Górny
Modified: 2024-11-06 08:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:57:08 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:53 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Miroslav Šulc gentoo-dev 2023-10-01 08:17:15 UTC
this bug needs an attention from someone who knows python setup system more than i do.
Comment 3 Seth 2023-10-06 22:31:05 UTC
Does this also explain the uncaught exceptions I'm seeing in the gpo CLI utility?

https://bpa.st/YZYA
Comment 4 Brand Huntsman 2023-10-24 08:40:13 UTC
(In reply to Seth from comment #3)
> Does this also explain the uncaught exceptions I'm seeing in the gpo CLI
> utility?

No, the gpodder.net web service is unmaintained and almost always returns that "
HTTP Error 500: Internal Server Error".
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:19 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 6 Brand Huntsman 2024-03-14 07:27:09 UTC
These patches fix this issue and https://bugs.gentoo.org/922991. The makefile patch will be in the next gpodder release.


--- a/makefile
+++ b/makefile
@@ -93,7 +93,9 @@ $(GPODDER_SERVICE_FILE): $(GPODDER_SERVICE_FILE_IN)
 %.desktop.in.h: %.desktop.in
 	intltool-extract --quiet --type=gettext/ini $<
 
-install: messages $(GPODDER_SERVICE_FILE) $(DESKTOP_FILES)
+build: messages $(GPODDER_SERVICE_FILE) $(DESKTOP_FILES)
+
+install: build
 	$(PYTHON) setup.py install --root=$(DESTDIR) --prefix=$(PREFIX) --optimize=1
 
 install-win: messages $(GPODDER_SERVICE_FILE) $(DESKTOP_FILES)




--- gpodder-3.11.4.ebuild	2024-03-07 13:08:04.334238937 -0700
+++ gpodder-3.11.4-r1.ebuild	2024-03-14 01:08:53.907616762 -0600
@@ -3,8 +3,8 @@
 
 EAPI=8
 
+DISTUTILS_USE_PEP517=setuptools
 DISTUTILS_SINGLE_IMPL=1
-DISTUTILS_USE_SETUPTOOLS=no
 PYTHON_COMPAT=( python3_{9..11} )
 PYTHON_REQ_USE="sqlite"
 
@@ -45,12 +45,18 @@
 	)
 "
 
+PATCHES=(
+	"${FILESDIR}"/${P}-make-build.patch
+)
+
 distutils_enable_tests pytest
 
 src_prepare() {
 	default
 
 	sed -i -e 's:--cov=gpodder::' makefile || die
+
+	emake PYTHON="${EPYTHON}" DESTDIR="${D}" build
 }
 
 python_test() {
@@ -64,8 +70,6 @@
 }
 
 src_install() {
-	emake PYTHON="${EPYTHON}" DESTDIR="${D}" install
-
 	distutils-r1_src_install
 
 	touch "${ED}"/usr/share/gpodder/no-update-check || die
Comment 7 Larry the Git Cow gentoo-dev 2024-11-06 08:01:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ac308f08029a00132d6989ceadb0bff5c7c3a05

commit 1ac308f08029a00132d6989ceadb0bff5c7c3a05
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-11-05 20:48:48 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-11-06 07:56:15 +0000

    media-sound/gpodder: add 3.11.4-r1
    
    Apply patch from bug.
    Clean up python_test. Use`PYTEST_DISABLE_PLUGIN_AUTOLOAD=1` and
    `EPYTEST_IGNORE`. Make `-p pytest_httpserver` explicit.
    
    Bug: https://bugs.gentoo.org/909991#c6
    Bug: https://bugs.gentoo.org/909991
    Bug: https://bugs.gentoo.org/922991
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/39215
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../gpodder/files/gpodder-3.11.4-make-build.patch  | 16 ++++
 media-sound/gpodder/gpodder-3.11.4-r1.ebuild       | 97 ++++++++++++++++++++++
 2 files changed, 113 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ac308f08029a00132d6989ceadb0bff5c7c3a05

commit 1ac308f08029a00132d6989ceadb0bff5c7c3a05
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-11-05 20:48:48 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-11-06 07:56:15 +0000

    media-sound/gpodder: add 3.11.4-r1
    
    Apply patch from bug.
    Clean up python_test. Use`PYTEST_DISABLE_PLUGIN_AUTOLOAD=1` and
    `EPYTEST_IGNORE`. Make `-p pytest_httpserver` explicit.
    
    Bug: https://bugs.gentoo.org/909991#c6
    Bug: https://bugs.gentoo.org/909991
    Bug: https://bugs.gentoo.org/922991
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/39215
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../gpodder/files/gpodder-3.11.4-make-build.patch  | 16 ++++
 media-sound/gpodder/gpodder-3.11.4-r1.ebuild       | 97 ++++++++++++++++++++++
 2 files changed, 113 insertions(+)