Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909906 - dev-java/javatoolkit-0.6.7-r1: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: dev-java/javatoolkit-0.6.7-r1: needs to use PEP517 build (DistutilsNonPEP517B...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:48 UTC by Michał Górny
Modified: 2024-06-08 17:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:48:33 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:52 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:18 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Larry the Git Cow gentoo-dev 2024-06-02 07:48:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c70bf44a9aa9973e6e08941c9b0bcdb7c8d4560

commit 5c70bf44a9aa9973e6e08941c9b0bcdb7c8d4560
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-06-02 07:47:53 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-06-02 07:48:19 +0000

    dev-java/javatoolkit: migrated to pep517
    
    Closes: https://bugs.gentoo.org/909906
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 dev-java/javatoolkit/javatoolkit-0.6.7.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2024-06-03 11:20:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80a512317dac9e26be293b7fddb4633fec6d5ff9

commit 80a512317dac9e26be293b7fddb4633fec6d5ff9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-03 11:18:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-03 11:19:51 +0000

    Revert "dev-java/javatoolkit: migrated to pep517"
    
    This reverts commit 5c70bf44a9aa9973e6e08941c9b0bcdb7c8d4560.
    
    The PEP517 port ends up not installing files to /usr/bin etc.
    
    Bug: https://bugs.gentoo.org/909906
    Closes: https://bugs.gentoo.org/933409
    CLoses: https://bugs.gentoo.org/933467
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{javatoolkit-0.6.7.ebuild => javatoolkit-0.6.7-r1.ebuild}         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Agostino Sarubbo gentoo-dev 2024-06-06 14:56:44 UTC
lto_tinderbox has reproduced this issue with version 0.6.7-r1 - Updating summary.
Comment 6 colton.reeder 2024-06-07 17:13:22 UTC
Running into this upgrading to python 3.12. Complains about missing distutils module and fails.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-08 17:08:17 UTC
(In reply to colton.reeder from comment #6)
> Running into this upgrading to python 3.12. Complains about missing
> distutils module and fails.

That's a separate issue I fixed yesterday:

commit 0eb3a18a76dc94fc574e4d82f821e16179daf7b2
Author: Sam James <sam@gentoo.org>
Date:   Fri Jun 7 17:18:53 2024 +0100

    dev-java/javatoolkit: add setuptools dep
    
    The ebuild needs fixing otherwise and I don't know why it has D_U_S=no
    but let's do a quick fix given it's an important package.
    
    Signed-off-by: Sam James <sam@gentoo.org>