Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909876 - app-emulation/virt-manager: needs to use PEP517 build (DistutilsNonPEP517Build)
Summary: app-emulation/virt-manager: needs to use PEP517 build (DistutilsNonPEP517Build)
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Virtualization Team
URL: https://github.com/virt-manager/virt-...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: pep517-porting
  Show dependency tree
 
Reported: 2023-07-08 06:45 UTC by Michał Górny
Modified: 2024-11-13 19:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 06:45:21 UTC
This package still uses the legacy eclass code paths.  These paths are deprecated and pose a significant maintenance cost.  Please update the package to use PEP517 build mode.  For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-08 20:40:56 UTC
[Adding this comment en-masse, sorry for the noise, but it's important.)

1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc.

2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-03-06 15:30:19 UTC
Final ping.  Please note that we will not hesitate to last rite low profile packages over this.
Comment 3 Sebastian Pipping gentoo-dev 2024-04-11 22:04:16 UTC
Still using distutils as of 4.1.0, some related progress upstream, asking for a release with Setuptools upstream…

(In reply to Michał Górny from comment #2)
> Final ping.  Please note that we will not hesitate to last rite low profile
> packages over this.

Would like to clarify as "not low profile". I understand this was copy-n-paste.
Comment 4 Larry the Git Cow gentoo-dev 2024-11-13 19:09:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5ca13d818262729e691e4d23487cb427b50665d

commit c5ca13d818262729e691e4d23487cb427b50665d
Author:     Michal Privoznik <michal.privoznik@gmail.com>
AuthorDate: 2024-11-13 15:13:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-13 19:08:43 +0000

    app-emulation/virt-manager: Update live ebuild
    
    Virt-manager just switched to meson [1]. Adapt our live ebuild to
    it.  Oh, and while at it - drop test useflag. Running tests
    doesn't make much sense for virt-manger since the even the
    current ebuild ignores pretty much all of them (as it ignores
    failed tests from test_cli.py where pretty much 90% of test suite
    lives).
    
    The referenced bug below is not closed with this just yet, as
    this is just live ebuild. But we can expect new release soon, in
    which case the bug will be fixed.
    
    1: https://github.com/virt-manager/virt-manager/commit/cbd2a7ef925cd11e525448561174ce6cc0e14e9a
    Bug: https://bugs.gentoo.org/909876
    Signed-off-by: Michal Privoznik <michal.privoznik@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/39305
    Signed-off-by: Sam James <sam@gentoo.org>

 .../virt-manager/virt-manager-9999.ebuild          | 43 +++++++---------------
 1 file changed, 14 insertions(+), 29 deletions(-)