Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909565 - net-irc/weechat-4.0.2 version bump
Summary: net-irc/weechat-4.0.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Georgy Yakovlev
URL: https://github.com/weechat/weechat/bl...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-03 13:18 UTC by bugs.gentoo.org
Modified: 2023-07-27 19:27 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-irc/weechat.4.0.2.patch - Version bump, fixes various build issues. (weechat.4.0.2.patch,5.86 KB, patch)
2023-07-27 08:29 UTC, bugs.gentoo.org
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bugs.gentoo.org 2023-07-03 13:18:47 UTC
net-irc/weechat has had a major version release (4.0.0) as well as a minor (4.0.1).

I've linked the release notes for 4.0.0 build changes. The main relevant change I see is regarding building documentation. The other changes (autotools/cmake, tarballs, and cpack) does not as far as I can see make any difference for current ebuild.

One major thing to note is that 4.0.0 introduces some breaking changes to config settings. When running weechat, after upgrading, config settings will be updated and config files will not be backwards compatible with earlier weechat versions. Changes in key bindings will result in a nonfunctional (keys such as <enter> not working) weechat.

I've not done any tests myself, still running 3.8.
Comment 1 bugs.gentoo.org 2023-07-27 08:29:43 UTC
Created attachment 866380 [details, diff]
net-irc/weechat.4.0.2.patch - Version bump, fixes various build issues.

Bumping the old 3.8 ebuild file to 4.0.2 failed to build. Same with current live build (9999). Issue is caused by some of the CMakeLists.txt files having been refactored/consolidated, and no longer matching regular expressions used by the ebuild.

Changes made (descending order in patch):
- New weechat-4.0.2.ebuild based of 3.8.
- Changed all keywords back to unstable.
- Dropped dev-lang/ruby:2.7 as a dependency since it's no longer in the repo.
- Dropped weechat-3.9-gettext-0.22.patch since it's been applied upstream.
- Fixed commands and regex for removing unwanted languages for building documentation.
- Fixed command for setting correct installation directory of docs.
- Turned off -DENABLE_DOC and added -DENABLE_DOC_INCOMPLETE using doc flag.
- Made the same above changes to the weechat-9999.ebuild file (where applicable).

Both 4.0.2 and 9999 now builds, installs, and runs without any errors. Tested with and without doc flag.

Oh, and since I didn't realize ahead of time it was needed, I'll add the GCO signoff here this time.
Signed-off-by: "Bo Osterud" <git@conjuro.net>
Comment 2 Larry the Git Cow gentoo-dev 2023-07-27 19:27:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ceab3b3a44fa6368dde2f3238182bba294699fb

commit 8ceab3b3a44fa6368dde2f3238182bba294699fb
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2023-07-27 19:21:24 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-07-27 19:26:39 +0000

    net-irc/weechat: add 4.0.2
    
    Thanks to Bo Osterud for providing a patch [1] upon which this is based.
    
    1: https://bugs.gentoo.org/909565#c1
    
    Closes: https://bugs.gentoo.org/909565
    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    Co-authored-by: Bo Osterud <git@conjuro.net>
    Signed-off-by: Bo Osterud <git@conjuro.net>

 net-irc/weechat/Manifest             |   2 +
 net-irc/weechat/weechat-4.0.2.ebuild | 195 +++++++++++++++++++++++++++++++++++
 2 files changed, 197 insertions(+)