Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909508 - net-misc/freerdp-9999 has missing dependency on dev-libs/pkcs11-helper
Summary: net-misc/freerdp-9999 has missing dependency on dev-libs/pkcs11-helper
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-02 07:53 UTC by Daniel Rozsnyo
Modified: 2023-09-01 13:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rozsnyo 2023-07-02 07:53:59 UTC
When doing my reqular updates, I have noticed that GIT version of freerdp does not compile anymore, as it looks for a libpkcs11 package. My USE set is:

[ebuild   R   *] net-misc/freerdp-9999:0/2::gentoo  USE="X alsa ffmpeg jpeg kerberos usb wayland xinerama xv -cups -debug -doc -gstreamer -openh264 -pulseaudio -server -smartcard -systemd -test -valgrind" 0 KiB

Fails with:

-- Checking for module 'libpkcs11-helper-1'
--   Package 'libpkcs11-helper-1', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Pkcs11 (missing: Pkcs11_FOUND)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindPkcs11.cmake:27 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  winpr/CMakeLists.txt:289 (find_package)


-- Configuring incomplete, errors occurred!
 * ERROR: net-misc/freerdp-9999::gentoo failed (configure phase):
 *   cmake failed



So I did:

# esearch pkcs11-helper

[ Results for search key : pkcs11-helper ]
[ Applications found : 1 ]

*  dev-libs/pkcs11-helper
      Latest version available: 1.29.0-r1
      Latest version installed: [ Not Installed ]
      Size of downloaded files: 412 kB
      Homepage:    https://github.com/OpenSC/pkcs11-helper
      Description: PKCS#11 helper library
      License:     || ( BSD GPL-2 )


Then installed it, and the freerdp finally compiles.

I do not know if libpkcs11 depends on any of the use flags, or its an always active requirement.
Comment 1 jospezial 2023-08-01 07:22:51 UTC
now dependency on media-libs/sdl2-ttf too:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find SDL2TTF (missing: SDL2TTF_LIBRARY SDL2TTF_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindSDL2TTF.cmake:172 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  client/SDL/dialogs/CMakeLists.txt:3 (find_package)

There may be more sdl dependencies.

https://github.com/FreeRDP/FreeRDP/releases/tag/3.0.0-beta1
says:
"New reference client based on SDL2 (work in progress)"
Comment 2 Larry the Git Cow gentoo-dev 2023-08-31 19:49:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f987b782ed7a6cb0d46bc2f971118ae593fb1a7

commit 8f987b782ed7a6cb0d46bc2f971118ae593fb1a7
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-08-31 19:36:31 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-08-31 19:49:33 +0000

    net-misc/freerdp: add sdl USE flag
    
    Closes: https://bugs.gentoo.org/909508
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-misc/freerdp/freerdp-9999.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f21264632e7298da2ca0fe0bdb9155d572aba565

commit f21264632e7298da2ca0fe0bdb9155d572aba565
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-08-31 19:26:10 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-08-31 19:49:33 +0000

    net-misc/freerdp: add pkcs11 USE flag
    
    Bug: https://bugs.gentoo.org/909508
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-misc/freerdp/freerdp-9999.ebuild | 4 +++-
 net-misc/freerdp/metadata.xml        | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)
Comment 3 jospezial 2023-09-01 04:08:52 UTC
"PCSC is required for smartcard redirection, pkcs11 for NLA smartcard logon support"

Shouldn't pkcs11 be dependency behind smartcard USE flag?
Comment 4 Mike Gilbert gentoo-dev 2023-09-01 13:29:19 UTC
There are two separate features here, though I suppose we could control both with the same USE flag.
Comment 5 Larry the Git Cow gentoo-dev 2023-09-01 13:32:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2522bdd5666624ca1300a3868d8989d3ea313e4f

commit 2522bdd5666624ca1300a3868d8989d3ea313e4f
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-09-01 13:31:45 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-09-01 13:31:45 +0000

    net-misc/freerdp: replace 'pkcs11' with 'smartcard' USE flag
    
    Bug: https://bugs.gentoo.org/909508
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-misc/freerdp/freerdp-9999.ebuild | 12 +++++++-----
 net-misc/freerdp/metadata.xml        |  1 -
 2 files changed, 7 insertions(+), 6 deletions(-)