Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909445 - sys-apps/sandbox-2.33 fails tests fchmod/1 and fchown/1
Summary: sys-apps/sandbox-2.33 fails tests fchmod/1 and fchown/1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sandbox Maintainers
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2023-07-01 15:13 UTC by tka
Modified: 2023-07-01 23:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,225.81 KB, text/plain)
2023-07-01 15:15 UTC, tka
Details
environment (environment,87.28 KB, text/plain)
2023-07-01 15:15 UTC, tka
Details
tests/testsuite.log (testsuite.log,250.86 KB, text/plain)
2023-07-01 15:16 UTC, tka
Details
build.log (sandbox-2.32) (build.log,224.78 KB, text/plain)
2023-07-01 16:02 UTC, tka
Details
tests/testsuite.log (sandbox-2.32) (testsuite.log,9.55 KB, text/plain)
2023-07-01 16:03 UTC, tka
Details
0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch (0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch,2.08 KB, patch)
2023-07-01 21:03 UTC, Michael Orlitzky
Details | Diff
0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch (0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch,2.12 KB, patch)
2023-07-01 21:10 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tka 2023-07-01 15:13:25 UTC
make  check-local
make[1]: Circular /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/testsuite.list.at <- /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/testsuite.list.at dependency dropped.
cd tests && /bin/sh '/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/testsuite' AUTOTEST_PATH='src:tests' --jobs=1
## ------------------------ ##
## sandbox 2.33 test suite. ##
## ------------------------ ##
  1: access/1                                        ok
  2: chmod/1                                         ok
  3: chown/1                                         ok
  4: execv/1                                         ok
  5: fchmod/1                                        FAILED (fchmod.at:1)
  6: fchmod/2                                        ok
  7: fchmodat/1                                      ok
  8: fchown/1                                        FAILED (fchown.at:1)
  9: fchown/2                                        ok
 10: fchownat/1                                      ok
 11: fchownat/2                                      ok
 12: futimesat/1                                     ok
 13: futimesat/2                                     ok
 14: futimesat/3                                     ok
 15: lchown/1                                        ok
 16: link/1                                          ok
 17: linkat/1                                        ok
 18: linkat/2                                        ok
 19: linkat_static/1                                 ok
 20: linkat_static/2                                 ok
 21: lutimes/1                                       ok
 22: malloc/1                                        ok
 23: malloc/2                                        ok
 24: mkdir/1                                         ok
 25: mkdir/2                                         ok
 26: mkdir/3                                         ok
 27: mkdir_static/1                                  ok
 28: mkdirat/1                                       ok
 29: mkdirat/2                                       ok
 30: mkdirat/3                                       ok
 31: mkdtemp/1                                       ok
 32: mkfifo/1                                        ok
 33: mkfifoat/1                                      ok
 34: mknod/1                                         ok
 35: mknodat/1                                       ok
 36: mkostemp/1                                      ok
 37: mkostemp64/1                                    ok
 38: mkostemps/1                                     ok
 39: mkostemps64/1                                   ok
 40: mkstemp/1                                       ok
 41: mkstemp64/1                                     ok
 42: mkstemps/1                                      ok
 43: mkstemps64/1                                    ok
 44: open/1                                          ok
 45: open/2                                          ok
 46: open_static/1                                   ok
 47: openat/1                                        ok
 48: openat/2                                        ok
 49: openat_static/1                                 ok
 50: openat_static/2                                 ok
 51: opendir/1                                       ok
 52: remove/1                                        ok
 53: removexattr/1                                   skipped (removexattr.at:1)
 54: rename/1                                        ok
 55: renameat/1                                      ok
 56: renameat/2                                      ok
 57: renameat/3                                      ok
 58: renameat2/1                                     ok
 59: renameat2/2                                     ok
 60: renameat2/3                                     ok
 61: rmdir/1                                         ok
 62: rmdir/2                                         ok
 63: sb_printf                                       ok
 64: script/1                                        ok
 65: script/2                                        ok
 66: script/3                                        ok
 67: script/4                                        ok
 68: script/5                                        ok
 69: script/6                                        ok
 70: script/7                                        ok
 71: script/8                                        ok
 72: script/9                                        ok
 73: script/10                                       ok
 74: script/11                                       ok
 75: script/12                                       ok
 76: script/13                                       ok
 77: script/14                                       ok
 78: script/15                                       ok
 79: script/16                                       ok
 80: setxattr/1                                      skipped (setxattr.at:1)
 81: signal_static/1                                 ok
 82: symlink/1                                       ok
 83: symlinkat/1                                     ok
 84: symlinkat/2                                     ok
 85: symlinkat/3                                     ok
 86: unlink/1                                        ok
 87: unlink_static/1                                 ok
 88: unlinkat/1                                      ok
 89: unlinkat/2                                      ok
 90: unlinkat/3                                      ok
 91: unlinkat/4                                      ok
 92: utimensat/1                                     ok
 93: utimensat/2                                     ok
 94: utimensat/3                                     ok
 95: utimensat/4                                     ok
 96: utimensat64/1                                   ok
 97: utimensat64_static/1                            ok
 98: utimensat_static/1                              ok
 99: utimensat_static/2                              ok
100: vfork/1                                         ok

## ------------- ##
## Test results. ##
## ------------- ##

ERROR: 98 tests were run,
2 failed unexpectedly.
2 tests were skipped.
## -------------------------- ##
## testsuite.log was created. ##
## -------------------------- ##

Please send `tests/testsuite.log' and all information you think might help:

   To: <sandbox@gentoo.org>
   Subject: [sandbox 2.33] testsuite: 5 8 failed

You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point.  Its output may
be found below `tests/testsuite.dir'.

make[1]: *** [Makefile:3225: check-local] Error 1
make: *** [Makefile:2743: check-am] Error 2
 * ERROR: sys-apps/sandbox-2.33::gentoo failed (test phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=sys-apps/sandbox-2.33::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-apps/sandbox-2.33::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/sys-apps/sandbox-2.33/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-apps/sandbox-2.33/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64'
 * S: '/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33'
 * If configure failed with a 'cannot run C compiled programs' error, try this:
 * FEATURES='-sandbox -usersandbox' emerge sandbox

>>> Failed to emerge sys-apps/sandbox-2.33, Log file:

>>>  '/var/tmp/portage/sys-apps/sandbox-2.33/temp/build.log'


Reproducible: Always
Comment 1 tka 2023-07-01 15:15:00 UTC
Created attachment 864972 [details]
build.log

# emerge -pqv '=sys-apps/sandbox-2.33::gentoo'
[ebuild     U ] sys-apps/sandbox-2.33 [2.32] USE="nnp" 


# emerge --info '=sys-apps/sandbox-2.33::gentoo'
Portage 3.0.49 (python 3.11.4-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-13, glibc-2.37-r3, 6.4.1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-6.4.1-x86_64-Intel-R-_Core-TM-_i7-4810MQ_CPU_@_2.80GHz-with-glibc2.37
KiB Mem:    16284664 total,  12438100 free
KiB Swap:   20971516 total,  20971516 free
Timestamp of repository gentoo: Sat, 01 Jul 2023 14:30:01 +0000
Head commit of repository gentoo: 86b1e06a8974554c96923ec597f666d265339dc0
sh bash 5.2_p15-r6
ld GNU ld (Gentoo 2.40 p5) 2.40.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r6::gentoo
dev-java/java-config:      2.3.1-r1::gentoo
dev-lang/perl:             5.36.1-r2::gentoo
dev-lang/python:           3.11.4::gentoo, 3.12.0_beta2::gentoo
dev-lang/rust:             1.69.0-r1::gentoo
dev-util/cmake:            3.26.4-r1::gentoo
dev-util/meson:            1.1.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/openrc:           0.47.1::gentoo
sys-apps/sandbox:          2.32::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.71-r6::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.40-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r3::gentoo, 16.0.6::gentoo
sys-devel/gcc:             13.1.1_p20230527::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo
sys-devel/llvm:            15.0.7-r3::gentoo, 16.0.6::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.4::gentoo (virtual/os-headers)
sys-libs/glibc:            2.37-r3::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: True
    sync-rsync-extra-opts: --new-compress
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

local
    location: /var/lib/portage-local/local
    masters: gentoo
    priority: 0
    volatile: True

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LEX="flex"
LINGUAS=""
MAKEOPTS="-j8"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--new-compress"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 acl acpi alsa amd64 avx bzip2 cairo caps cdda cddb cdparanoia cli crypt cups dbus dri dts dvd elogind fam ffmpeg fftw flac fontconfig gdbm gif gimp gmp gnutls gtk hardened iconv icu idn ipv6 jpeg lame lcms libnotify libtirpc lzma mad matroska mmap mmx mmxext mp3 mpeg ncurses networkmanager nptl ogg opengl openmp pam pcre pie png policykit ppds readline sasl sdl seccomp split-usr sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg test test-rust theora threads tiff truetype udev udisks unicode upower vaapi verify-sig vorbis wayland x264 xattr xcb xinerama xml xtpax xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby31" VIDEO_CARDS="crocus intel nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LANG, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 2 tka 2023-07-01 15:15:16 UTC
Created attachment 864973 [details]
environment
Comment 3 tka 2023-07-01 15:16:46 UTC
Created attachment 864974 [details]
tests/testsuite.log
Comment 4 tka 2023-07-01 15:17:53 UTC
## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##

#                             -*- compilation -*-
5. fchmod.at:1: testing fchmod/1 ...
/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchmod.at:1: \
        env \
                SANDBOX_LOG="$PWD/sandbox.log" \
                sandbox.sh -c \
                        addpredict / \; \
                        addwrite "${PWD%/*}" \; \
                        set -x \; \
 . $abs_top_srcdir/tests/fchmod-1.sh
stderr:
+ . /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchmod-1.sh
++ addwrite /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/005
++ export SANDBOX_WRITE=/dev/fd:/proc/self/fd:/dev/zero:/dev/null:/dev/full:/dev/console:/dev/tty:/dev/vc/:/dev/pty:/dev/tts:/dev/ptmx:/dev/pts/:/dev/shm:/tmp/:/var/tmp/:/usr/tmp/:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history::/dev/console:/dev/fd:/dev/full:/dev/null:/dev/ptmx:/dev/pts/:/dev/pty:/dev/sh
m:/dev/tts:/dev/tty:/dev/vc/:/dev/zero:/proc/self/fd:/tmp/:/usr/lib/cf:/usr/lib/conftest:/usr/lib32/cf:/usr/lib32/conftest:/usr/lib64/cf:/usr/lib64/conftest:/usr/tmp/:/usr/tmp/cf:/usr/tmp/conftest:/var/tmp/:/var/tmp/portage:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history:/var/tmp/portage/sys-apps/sandbox-
2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/005
++ SANDBOX_WRITE=/dev/fd:/proc/self/fd:/dev/zero:/dev/null:/dev/full:/dev/console:/dev/tty:/dev/vc/:/dev/pty:/dev/tts:/dev/ptmx:/dev/pts/:/dev/shm:/tmp/:/var/tmp/:/usr/tmp/:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history::/dev/console:/dev/fd:/dev/full:/dev/null:/dev/ptmx:/dev/pts/:/dev/pty:/dev/shm:/dev/
tts:/dev/tty:/dev/vc/:/dev/zero:/proc/self/fd:/tmp/:/usr/lib/cf:/usr/lib/conftest:/usr/lib32/cf:/usr/lib32/conftest:/usr/lib64/cf:/usr/lib64/conftest:/usr/tmp/:/usr/tmp/cf:/usr/tmp/conftest:/var/tmp/:/var/tmp/portage:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history:/var/tmp/portage/sys-apps/sandbox-2.33/wo
rk/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/005
+++ stat --format=%#04a ../..
++ fchmod-0 0755 ../..
++ exit 1
stdout:
/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchmod.at:1: exit code was 1, expected 0
5. fchmod.at:1: 5. fchmod/1 (fchmod.at:1): FAILED (fchmod.at:1)

#                             -*- compilation -*-
8. fchown.at:1: testing fchown/1 ...
/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchown.at:1: \
        env \
                SANDBOX_LOG="$PWD/sandbox.log" \
                sandbox.sh -c \
                        addpredict / \; \
                        addwrite "${PWD%/*}" \; \
                        set -x \; \
 . $abs_top_srcdir/tests/fchown-1.sh
stderr:
+ . /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchown-1.sh
++ addwrite /var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/008
++ export SANDBOX_WRITE=/dev/fd:/proc/self/fd:/dev/zero:/dev/null:/dev/full:/dev/console:/dev/tty:/dev/vc/:/dev/pty:/dev/tts:/dev/ptmx:/dev/pts/:/dev/shm:/tmp/:/var/tmp/:/usr/tmp/:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history::/dev/console:/dev/fd:/dev/full:/dev/null:/dev/ptmx:/dev/pts/:/dev/pty:/dev/shm:/dev/tts:/dev/tty:/dev/vc/:/dev/zero:/proc/self/fd:/tmp/:/usr/lib/cf:/usr/lib/conftest:/usr/lib32/cf:/usr/lib32/conftest:/usr/lib64/cf:/usr/lib64/conftest:/usr/tmp/:/usr/tmp/cf:/usr/tmp/conftest:/var/tmp/:/var/tmp/portage:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/008
++ SANDBOX_WRITE=/dev/fd:/proc/self/fd:/dev/zero:/dev/null:/dev/full:/dev/console:/dev/tty:/dev/vc/:/dev/pty:/dev/tts:/dev/ptmx:/dev/pts/:/dev/shm:/tmp/:/var/tmp/:/usr/tmp/:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history::/dev/console:/dev/fd:/dev/full:/dev/null:/dev/ptmx:/dev/pts/:/dev/pty:/dev/shm:/dev/tts:/dev/tty:/dev/vc/:/dev/zero:/proc/self/fd:/tmp/:/usr/lib/cf:/usr/lib/conftest:/usr/lib32/cf:/usr/lib32/conftest:/usr/lib64/cf:/usr/lib64/conftest:/usr/tmp/:/usr/tmp/cf:/usr/tmp/conftest:/var/tmp/:/var/tmp/portage:/var/tmp/portage/sys-apps/sandbox-2.33/homedir/.bash_history:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir:/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33-abi_x86_64.amd64/tests/testsuite.dir/008
++ fchown-0 250 250 ../..
++ exit 1
stdout:
/var/tmp/portage/sys-apps/sandbox-2.33/work/sandbox-2.33/tests/fchown.at:1: exit code was 1, expected 0
8. fchown.at:1: 8. fchown/1 (fchown.at:1): FAILED (fchown.at:1)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-01 15:32:53 UTC
Can you attach tests/testsuite.log in full too please for completeness?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-01 15:32:59 UTC
(In reply to Sam James from comment #5)
> Can you attach tests/testsuite.log in full too please for completeness?

Also, did previous versions work (or not)?
Comment 7 tka 2023-07-01 16:02:27 UTC
Created attachment 864978 [details]
build.log (sandbox-2.32)

(In reply to Sam James from comment #6)
> (In reply to Sam James from comment #5)
> > Can you attach tests/testsuite.log in full too please for completeness?

tests/testsuite.log is already attached.

> Also, did previous versions work (or not)?

There are no test failures with sys-apps/sandbox-2.32:

## Test results. ##
## ------------- ##

94 tests were successful.
2 tests were skipped.
>>> Completed testing sys-apps/sandbox-2.32

But I don't see any mention of the tests "fchmod/1" and "fchown/1" in that version. I will attach the sandbox-2.32 build.log and testsuite.log for comparison.
Comment 8 tka 2023-07-01 16:03:54 UTC
Created attachment 864979 [details]
tests/testsuite.log (sandbox-2.32)
Comment 9 Mike Gilbert gentoo-dev 2023-07-01 18:42:37 UTC
The relevant code and tests are new to 2.33. Copying the author (mjo).
Comment 10 Michael Orlitzky gentoo-dev 2023-07-01 19:21:23 UTC
I can reproduce the problem, it only happens during a portage install (i.e. not from a git checkout). I was using these in /etc/portage/patches for a while without issues so that's a hint. I should have a fix in a day or two.
Comment 11 Mike Gilbert gentoo-dev 2023-07-01 20:24:25 UTC
I think I have found the problem.

Portage always adds PORTAGE_TMPDIR to SANDBOX_WRITE.

The new tests assume that access will be denied by default, but the tests are run in a subdirectory of PORTAGE_TMPDIR.
Comment 12 Mike Gilbert gentoo-dev 2023-07-01 20:25:58 UTC
It looks like other test scripts explicitly call adddeny to avoid this issue.
Comment 13 Michael Orlitzky gentoo-dev 2023-07-01 20:50:55 UTC
(In reply to Mike Gilbert from comment #11)
> I think I have found the problem.
> 
> Portage always adds PORTAGE_TMPDIR to SANDBOX_WRITE.
> 

Ah, thanks. I had figured out *what* was happening, but couldn't get why.
Comment 14 Michael Orlitzky gentoo-dev 2023-07-01 21:03:59 UTC
Created attachment 864985 [details, diff]
0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch

Works both under portage and in git, and with/without SANDBOX_PROC_SELF_FD.
Comment 15 Michael Orlitzky gentoo-dev 2023-07-01 21:10:44 UTC
Created attachment 864986 [details, diff]
0001-tests-use-explicit-adddeny-calls-in-fchmod-and-fchow.patch

forgot signoff
Comment 16 tka 2023-07-01 22:06:21 UTC
Confirmed. The patch lets the tests pass:

## ------------- ##
## Test results. ##
## ------------- ##

98 tests were successful.
2 tests were skipped.
>>> Completed testing sys-apps/sandbox-2.33
Comment 17 Mike Gilbert gentoo-dev 2023-07-01 23:50:27 UTC
Thanks, I'll get it released shortly.
Comment 18 Larry the Git Cow gentoo-dev 2023-07-01 23:52:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=e5032c6b89621db0475e36fb06c2905b6a9c024c

commit e5032c6b89621db0475e36fb06c2905b6a9c024c
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-07-01 20:52:34 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-07-01 23:51:18 +0000

    tests: use explicit adddeny() calls in fchmod and fchown tests.
    
    When running the test suite under portage, the entire build directory
    will be writable because portage adds PORTAGE_TMPDIR to SANDBOX_WRITE
    (thanks floppym). This breaks the tests for these two wrappers, since
    they expect to fail when trying to write above $PWD.
    
    To avoid that, we create a new file to call fchown/fchmod on, and then
    explicitly deny access to it.
    
    Closes: https://bugs.gentoo.org/909445
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 tests/fchmod-1.sh | 6 +++++-
 tests/fchown-1.sh | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)