Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909315 - sys-fs/eudev does not depend on acct-group packages necessary for udev rules
Summary: sys-fs/eudev does not depend on acct-group packages necessary for udev rules
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: eudev team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 21:52 UTC by Gil Kloepfer
Modified: 2023-08-20 20:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-sys-fs-eudev-add-missing-RDEPEND-udev-rules-909315.patch (0001-sys-fs-eudev-add-missing-RDEPEND-udev-rules-909315.patch,2.97 KB, patch)
2023-08-20 19:19 UTC, unlord
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gil Kloepfer 2023-06-27 21:52:37 UTC
sys-apps/systemd-utils[udev] creates dependencies on appropriate acct-group entries needed for the udev rules contained within the package.  The sys-fs/eudev ebuild does not contain these dependencies, and so the dependency tracking of the groups is not maintained.

This is not critical as Gentoo OpenRC stage3 blobs are distributed with sys-apps/systemd-utils[udev] and the groups are created as already as a result.  However, for completeness, the groups should be handled the same as any other udev provider.

Reproducible: Always

Steps to Reproduce:
1.  Install new Gentoo system from a fresh OpenRC stage3
2.  Switch from systemd-utils[udev] to eudev
3.  emerge --depclean --with-bdeps=y
Actual Results:  
The following group packages are removed by depclean (removed "=acct-group/" for brevity):
dialout-0-r1 kmem-0-r1 sgx-0 tape-0-r1 cdrom-0-r1 lp-0-r1 floppy-0 video-0-r1 usb-0-r1 disk-0-r1 audio-0-r1 tty-0-r1

Expected Results:  
These group packages are being removed (and SHOULD NOT be removed, as they are used in eudev udev rules):
kmem, tape, cdrom, lp, floppy, video, usb, disk, audio, tty

These group packages are NOT apparently used within eudev udev rules (and CAN be removed):
dialout, sgx

For each of the groups listed, went to /lib/udev/rules.d, and did a:
grep GROUP * | grep {group-name}

Verified those groups that were actually used in eudev's udev rules.

Will provide additional information (such as emerge --info) upon request, in order to keep this report as brief as possible.

I have checked the ebuilds for all current sys-fs/eudev and they are all missing these acct-group/* dependencies.  Thee additional dependencies (RDEPENDs) should follow the ones in the ebuilds for acct-group/{input,kvm,render}.

Specifically:
acct-group/audio
acct-group/cdrom
acct-group/disk
acct-group/floppy
acct-group/kmem
acct-group/lp
acct-group/usb
acct-group/tape
acct-group/tty
acct-group/video

This would keep the ebuild for eudev consistent with the one for systemd-utils.
Comment 1 Gil Kloepfer 2023-06-27 21:56:32 UTC
I just re-re-read my description and the last part may be slightly unclear - I am suggesting that the RDEPENDs in the ebuilds for sys-fs/eudev be modified, not the ones for acct-group.

Just to make sure that this is clear.  Sorry for the followup.
Comment 2 unlord 2023-08-20 19:19:06 UTC
Created attachment 868276 [details, diff]
0001-sys-fs-eudev-add-missing-RDEPEND-udev-rules-909315.patch
Comment 3 Larry the Git Cow gentoo-dev 2023-08-20 20:09:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b2c0f79d0ea65150ccb75cbc294f20fbb0f9235

commit 2b2c0f79d0ea65150ccb75cbc294f20fbb0f9235
Author:     Nathan E. Egge <unlord@xiph.org>
AuthorDate: 2023-08-20 19:07:28 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-08-20 20:09:31 +0000

    sys-fs/eudev: add missing RDEPEND udev rules
    
    Closes: https://bugs.gentoo.org/909315
    Closes: https://github.com/gentoo/gentoo/pull/32399
    Signed-off-by: Nathan E. Egge <unlord@xiph.org>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../{eudev-3.2.11-r2.ebuild => eudev-3.2.11-r4.ebuild}  | 17 ++++++++++++++++-
 .../{eudev-3.2.11-r3.ebuild => eudev-3.2.11-r5.ebuild}  | 17 ++++++++++++++++-
 .../{eudev-3.2.12.ebuild => eudev-3.2.12-r1.ebuild}     | 15 +++++++++++++++
 sys-fs/eudev/eudev-9999.ebuild                          | 15 +++++++++++++++
 4 files changed, 62 insertions(+), 2 deletions(-)