Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909280 - media-libs/openimageio-2.4.12.0 one or more CMake variables were not used by the project
Summary: media-libs/openimageio-2.4.12.0 one or more CMake variables were not used by ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 06:56 UTC by Agostino Sarubbo
Modified: 2023-06-27 11:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,259.40 KB, text/plain)
2023-06-27 06:56 UTC, Agostino Sarubbo
Details
Proposed patch (oiio-2.4.12.0-use_opengl.patch,467 bytes, patch)
2023-06-27 09:40 UTC, Paul Zander
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-06-27 06:56:35 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/openimageio-2.4.12.0 one or more CMake variables were not used by the project.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-06-27 06:56:37 UTC
CC'ing also the author of the commit (f2cfc93fb3528b3701eb9cc09f256f2aff9c605d)
Comment 2 Agostino Sarubbo gentoo-dev 2023-06-27 06:56:38 UTC
Created attachment 864687 [details]
build.log

build log and emerge --info
Comment 3 Paul Zander 2023-06-27 09:40:50 UTC
Created attachment 864702 [details, diff]
Proposed patch

This is caused by https://github.com/OpenImageIO/oiio/blob/v2.4.12.0/src/cmake/externalpackages.cmake#L253C37-L253C37:

> # Qt -- used for iv
> option (USE_QT "Use Qt if found" ON)
> if (USE_QT)
>     checked_find_package (OpenGL)   # used for iv
> endif ()
> if (USE_QT AND OPENGL_FOUND)

Which contradicts https://github.com/OpenImageIO/oiio/blob/v2.4.12.0/INSTALL.md?plain=1#L235:
> | make USE_OPENGL=0 ...     |  Skip anything that needs OpenGL               |

I added a patch that I would send upstream.

Can anyone make a decision how we want to handle this?
We could drop "-DUSE_OPENGL" for now and reintroduce it later or add my patch and leave it in.
Comment 4 Andrew Nowa Ammerlaan gentoo-dev 2023-06-27 11:35:32 UTC
Lets just drop "-DUSE_OPENGL=OFF", it is the easier solution. We can add it back later if necessary.
Comment 5 Larry the Git Cow gentoo-dev 2023-06-27 11:38:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ec1a0124b63060022b8d6e5babd0cd9338666ee

commit 5ec1a0124b63060022b8d6e5babd0cd9338666ee
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2023-06-27 11:36:39 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2023-06-27 11:38:01 +0000

    media-libs/openimageio: correct dependency on opengl
    
    and fix an unused cmake variable warning
    
    Closes: https://bugs.gentoo.org/909280
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 media-libs/openimageio/openimageio-2.4.12.0.ebuild | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)