Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 909092 - Unneeded dependencies in x11-base/xorg-server
Summary: Unneeded dependencies in x11-base/xorg-server
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-24 19:12 UTC by stefan11111
Modified: 2023-10-25 15:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description stefan11111 2023-06-24 19:12:49 UTC
See: https://forums.gentoo.org/viewtopic-t-1163922.html
Xorg depends on x11-apps/rgb.
Xorg doesn't need that package to build and run properly.
For those who don't want to read that thread, there seems to even be a commit upstream from 15 years ago removing all rgb stuff from xorg.
https://gitlab.freedesktop.org/xorg/xserver/-/commit/dda10c9066a660b647384179f82e1da8e063264f
Comment 1 Mike Gilbert gentoo-dev 2023-09-05 17:42:55 UTC
It looks like rgb.txt hasn't really been used by the X server since this commit:

https://gitlab.freedesktop.org/xorg/xserver/-/commit/8987b2c1efc9a4667e278e6ba411772ba2a4a4e6

From the commit message: "Replace rgb text file loading with static rgb color table."

I think we could remove it and see if anyone reports any problems.
Comment 2 stefan11111 2023-09-05 19:30:24 UTC
> I think we could remove it and see if anyone reports any problems.
+1
Comment 3 Larry the Git Cow gentoo-dev 2023-09-06 12:23:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49c1927f2412e475352bf83f4c6a7aa0a1fb25a7

commit 49c1927f2412e475352bf83f4c6a7aa0a1fb25a7
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-09-06 12:22:45 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-09-06 12:23:11 +0000

    x11-base/xorg-server: Drop dependency on x11-apps/rgb
    
    Bug: https://bugs.gentoo.org/909092
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-base/xorg-server/xorg-server-9999.ebuild | 1 -
 1 file changed, 1 deletion(-)
Comment 4 Matt Turner gentoo-dev 2023-09-06 12:24:31 UTC
Thanks! I've dropped it from -9999. I'll drop it from a non-live ebuild the next time we have a version or revision bump.
Comment 5 Larry the Git Cow gentoo-dev 2023-10-25 15:41:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b4db39b0d72f93d5c46898cb262d8c5349542cc

commit 9b4db39b0d72f93d5c46898cb262d8c5349542cc
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-10-25 15:29:54 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-10-25 15:41:30 +0000

    x11-base/xorg-server: Version bump to 21.1.9
    
    Bug: https://bugs.gentoo.org/916254
    Closes: https://bugs.gentoo.org/884221
    Closes: https://bugs.gentoo.org/909092
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-base/xorg-server/Manifest                      |   1 +
 ...1.9-xephyr-Don-t-check-for-SeatId-anymore.patch |  66 +++++++
 x11-base/xorg-server/xorg-server-21.1.9.ebuild     | 194 +++++++++++++++++++++
 3 files changed, 261 insertions(+)