Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 908817 - net-misc/iputils-20221126-r1 unconditionally depends on docbook/libxslt
Summary: net-misc/iputils-20221126-r1 unconditionally depends on docbook/libxslt
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-19 00:30 UTC by Piotr Michalczyk
Modified: 2024-10-03 07:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Michalczyk 2023-06-19 00:30:43 UTC
iputils has "doc" USE flag, but unconditionally depends on:

BDEPEND="
        app-text/docbook-xml-dtd:4.2
        app-text/docbook-xml-dtd:4.5
        app-text/docbook-xsl-ns-stylesheets
        app-text/docbook-xsl-stylesheets
        dev-libs/libxslt

which are used only for documentation building.


This should be replaced with:

BDEPEND="
        doc? (
                app-text/docbook-xml-dtd:4.2
                app-text/docbook-xml-dtd:4.5
                app-text/docbook-xsl-ns-stylesheets
                app-text/docbook-xsl-stylesheets
                dev-libs/libxslt
        )
Comment 1 Mike Gilbert gentoo-dev 2023-06-20 01:19:46 UTC
That's my doing. Those deps are needed to build the man pages.

commit 31dcb27958c21cfb89f1dc3d84fa67861d230d9f
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Mon Feb 20 13:23:47 2023 -0500

    net-misc/iputils: simplify manpage handling

    Always build manpages from source instead of hacking in prebuilt copies
    from an auxiliary tarball.

    Closes: https://bugs.gentoo.org/895160
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-20 05:15:28 UTC
Please ask upstream to add man pages to their dist tarballs.
Comment 3 Piotr Michalczyk 2023-06-24 23:04:24 UTC
Ok, I confirm my mistake. These dependencies are required for building man pages.

One thing bothers me though: I'm building iputils using FEATURES="noman". Isn't there some way to transmit this setting to ebuild and base dependencies on it (e.g. in a similar way as FEATURES="test" does work)? It's of no use to build dependencies and then man pages only to have man pages removed from installation in last step. As far as I understand FEATURES shouldn't/can't be used directly inside ebuilds.

It seems wasteful to have e.g. 50MB of app-text/docbook-xsl-ns-stylesheets installed in Docker image with FEATURES="noman" set, as a result of adding 180KB iputils package - when the man pages are finally not installed anyway.
Comment 4 Mike Gilbert gentoo-dev 2023-06-24 23:39:52 UTC
(In reply to Piotr Michalczyk from comment #3)

I would suggest using a binhost if you are deploying Gentoo in containers. You can bypass all of the build-time deps that way, including the docbook stuff.
Comment 5 Piotr Michalczyk 2023-06-25 00:12:58 UTC
(In reply to Mike Gilbert from comment #4)

Thank you for hint. I'm not familiar with 'binhost' configuration yet and I will need to check if it fits my requirements.

As a quick workaround I'm going to put man-related packages into package.provided and avoid installing them. At least iputils seem to compile fine even when some dependencies listen in ebuild are not installed.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-25 04:05:20 UTC
I filed https://github.com/iputils/iputils/issues/479, let's see where it goes.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-30 10:33:20 UTC
(In reply to Sam James from comment #6)
> I filed https://github.com/iputils/iputils/issues/479, let's see where it
> goes.

Upstream are going to product doc tarballs for the next release onwards! \o/
Comment 8 Larry the Git Cow gentoo-dev 2023-12-23 19:01:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=347e0109b475a12b97e91ed8948cf6aaf9db671f

commit 347e0109b475a12b97e91ed8948cf6aaf9db671f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-23 19:00:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-23 19:00:28 +0000

    net-misc/iputils: add 20231222
    
    Closes: https://bugs.gentoo.org/908817
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/iputils/Manifest                |   1 +
 net-misc/iputils/iputils-20231222.ebuild | 141 +++++++++++++++++++++++++++++++
 net-misc/iputils/iputils-99999999.ebuild |  26 ++++--
 3 files changed, 160 insertions(+), 8 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2024-10-03 07:31:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91046f11889af3d05a54ba858e5b85506e121d96

commit 91046f11889af3d05a54ba858e5b85506e121d96
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-03 06:59:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-03 07:04:47 +0000

    net-misc/iputils: add 20240905
    
    This also essentially reverts commit 8fd3bbe19eb695fb5ca88375e4d814070ab33639
    (brings back the doc/man page logic as it's now in an upstream release).
    
    Includes a patch from Eli (https://github.com/iputils/iputils/pull/556).
    
    Bug: https://bugs.gentoo.org/908817
    Closes: https://bugs.gentoo.org/920901
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/iputils/Manifest                          |   1 +
 .../iputils/files/iputils-20240905-man-pages.patch |  30 +++++
 net-misc/iputils/iputils-20240905.ebuild           | 145 +++++++++++++++++++++
 net-misc/iputils/iputils-99999999.ebuild           |  26 ++--
 4 files changed, 194 insertions(+), 8 deletions(-)