908793 – sys-libs/libblockdev, sys-apps/nvme-cli, sys-libs/libnvme sparc keyword request

Bug 908793 - sys-libs/libblockdev, sys-apps/nvme-cli, sys-libs/libnvme sparc keyword request

Summary: sys-libs/libblockdev, sys-apps/nvme-cli, sys-libs/libnvme sparc keyword request

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Keywording (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:	CC-ARCHES, PullRequest

Depends on:
Blocks:	930256
	Show dependency tree

Reported:	2023-06-18 14:49 UTC by Nick Bowler
Modified:	2024-04-20 13:22 UTC (History)
CC List:	4 users (show)

See Also:	https://github.com/linux-nvme/libnvme/pull/732 https://github.com/gentoo/gentoo/pull/34304
Package list:	sys-libs/libblockdev ~sparc sys-apps/nvme-cli ~sparc sys-libs/libnvme ~sparc
Runtime testing required:	---

Flags:	nattka: sanity-check+

Attachments
sys-libs/libnvme-1.5-r2 build log w/ FEATURES=test (sys-libs:libnvme-1.5-r2:20231112-210831.log,58.94 KB, text/plain) 2023-11-12 21:48 UTC, Nick Bowler	no flags	Details
sys-apps/nvme-cli-2.5 build log w/ FEATURES=test (sys-apps:nvme-cli-2.5:20231112-211657.log,172.76 KB, text/plain) 2023-11-12 21:49 UTC, Nick Bowler	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nick Bowler 2023-06-18 14:49:27 UTC

Hi,

The nvme-cli package contains the basic userspace administrative tools for
NVMe devices.

It compiles and seems to work fine on my sparc without any obvious problem.
Please consider adding sparc keywords to nvme-cli (and its direct dependency,
libnvme).  Thanks!

Portage 3.0.45.3 (python 3.11.3-final-0, default/linux/sparc/17.0, gcc-12, glibc-2.36-r7, 6.3.6-00002-ga55a66d2bc3a sparc64)
=================================================================
System uname: Linux-6.3.6-00002-ga55a66d2bc3a-sparc64-sun4u-with-glibc2.36
KiB Mem:      505528 total,    161400 free
KiB Swap:    1048568 total,   1031160 free
Timestamp of repository gentoo: Sat, 17 Jun 2023 00:45:01 +0000
Head commit of repository gentoo: 5d408bd0436acd30fdfa84c8b48045f45c270bb7
sh bash 5.1_p16-r4
ld GNU ld (Gentoo 2.37_p1 p2) 2.37
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r4::gentoo
dev-lang/perl:             5.36.0-r2::gentoo
dev-lang/python:           3.10.12::gentoo, 3.11.3::gentoo
dev-util/cmake:            3.26.3::gentoo
dev-util/meson:            1.1.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/openrc:           0.46::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-devel/autoconf:        2.71-r5::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.37_p1-r2::gentoo, 2.39-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/gcc:             11.3.1_p20221209::gentoo, 12.2.1_p20230428-r1::gentoo
sys-devel/gcc-config:      2.10::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r7::gentoo
Repositories:

gentoo
    location: /srv/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://athena.draconx.ca/gentoo-portage
    priority: -1000
    volatile: True
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no

gentoo-draconx
    location: /srv/repos/gentoo-draconx
    masters: gentoo
    volatile: True

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="@FREE"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-Os -mcpu=ultrasparc -pipe"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -mcpu=ultrasparc -pipe"
DISTDIR="/srv/mirror/gentoo/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --dynamic-deps=n --autounmask=n --autounmask-write=n --unordered-display --verbose-conflicts --binpkg-respect-use=y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-Os -mcpu=ultrasparc -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-Os -mcpu=ultrasparc -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/etc/gssproxy/??-*.conf"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j2"
PKGDIR="/var/cache/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/zsh"
USE="acl alsa big-endian bzip2 cli crypt dri fortran gdbm iconv ipv6 libtirpc llvm-libunwind ncurses nls nptl openmp pam pcre readline sparc split-usr ssl unicode xattr zlib" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" RUBY_TARGETS="ruby30 ruby31" VIDEO_CARDS="fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

Comment 1 Sam James archtester

2023-06-18 14:54:31 UTC

Thanks!

Comment 2 NATTkA bot gentoo-dev

2023-06-18 14:56:14 UTC Comment hidden (obsolete)

Sanity check failed:

> sys-apps/nvme-cli-2.4-r2
>   depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     sys-libs/libhugetlbfs:=
>   rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     sys-libs/libhugetlbfs:=

Comment 3 NATTkA bot gentoo-dev

2023-06-30 23:16:16 UTC Comment hidden (obsolete)

Sanity check failed:

> sys-apps/nvme-cli-2.5
>   depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     sys-libs/libhugetlbfs:=
>   rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     sys-libs/libhugetlbfs:=

Comment 4 NATTkA bot gentoo-dev

2023-06-30 23:24:16 UTC Comment hidden (obsolete)

All sanity-check issues have been resolved

Comment 5 Sam James archtester

2023-07-09 02:28:28 UTC

libhugetlbfs remains horribly broken w/ newer glibc, so let's mask it here

Comment 6 Larry the Git Cow gentoo-dev

2023-07-09 02:31:52 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a43629357609b4fc45137c24dc47dd68d7947e85

commit a43629357609b4fc45137c24dc47dd68d7947e85
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-07-09 02:30:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-09 02:31:24 +0000

    profiles/arch/base: mask nvme-cli[hugepages]
    
    Needs <glibc-2.34.
    
    Bug: https://bugs.gentoo.org/806079
    Bug: https://bugs.gentoo.org/908793
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/base/package.use.mask   | 4 ++++
 profiles/base/package.use.stable.mask | 6 ------
 2 files changed, 4 insertions(+), 6 deletions(-)

Comment 7 Sam James archtester

2023-11-12 19:13:16 UTC

Did you run the test suite for libnvme/nvme-cli?

glaubitz from Debian mentioned a lot of alignment problems. Fortunatley, they're all fixed in master as upstream recently adopted ubsan.

See https://github.com/linux-nvme/libnvme/pull/732.

Comment 8 Nick Bowler 2023-11-12 21:41:47 UTC

I didn't run the test previously but libnvme-1.5-r2 and nvme-cli-2.5 tests
indeed fail:

  libnvme:
  Summary of Failures:
  
   2/14 mi-mctp                    FAIL            0.14s   killed by signal 10 SIGBUS
   6/14 NBFT-auto-ipv6             FAIL            0.21s   exit status 1
   7/14 NBFT-dhcp-ipv6             FAIL            0.25s   exit status 1
   8/14 NBFT-rhpoc                 FAIL            0.20s   exit status 1
   9/14 NBFT-static-ipv4           FAIL            0.20s   exit status 1
  10/14 NBFT-static-ipv4-discovery FAIL            0.20s   exit status 1
  11/14 NBFT-static-ipv6           FAIL            0.21s   exit status 1
  
  Ok:                 5
  Expected Fail:      2
  Fail:               7
  Unexpected Pass:    0
  Skipped:            0
  Timeout:            0

  nvme-cli:
  Summary of Failures:

  5/5 argconfig_parse     FAIL            0.11s   exit status 1
  
  Ok:                 4   
  Expected Fail:      0   
  Fail:               1   
  Unexpected Pass:    0   
  Skipped:            0   
  Timeout:            0   

Not sure what exact features these are testing.  This tool clearly has a
gigantic number of capabilities so I guess there might be some feature
that maybe won't work.

I am only using nvme-pci and only really interested in basic administration
like retrieving the error logs which all seems to be ok.

Comment 9 Nick Bowler 2023-11-12 21:48:45 UTC

Created attachment 874613 [details]
sys-libs/libnvme-1.5-r2 build log w/ FEATURES=test

Comment 10 Nick Bowler 2023-11-12 21:49:21 UTC

Created attachment 874614 [details]
sys-apps/nvme-cli-2.5 build log w/ FEATURES=test

Comment 11 matoro archtester

2023-12-09 21:15:24 UTC

Wow, that patch actually does fix it.

Comment 12 Larry the Git Cow gentoo-dev

2023-12-16 02:45:12 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1aed182daa661b3e80faa5dabe8aa55d742ff2f4

commit 1aed182daa661b3e80faa5dabe8aa55d742ff2f4
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-12-16 00:21:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-16 02:43:10 +0000

    sys-libs/libnvme: add ubsan fixes patch
    
    See: https://github.com/linux-nvme/libnvme/pull/732
    Bug: https://bugs.gentoo.org/908793
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Closes: https://github.com/gentoo/gentoo/pull/34304
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/libnvme/Manifest              |  1 +
 sys-libs/libnvme/libnvme-1.6-r2.ebuild | 84 ++++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+)

Comment 13 matoro archtester

2023-12-21 00:11:02 UTC

sparc done

all arches done

Comment 14 Andreas Sturmlechner gentoo-dev

2024-04-20 11:46:59 UTC

(In reply to Sam James from bug #910073#c2)
> farming sparc out to bug 908793
Seems like that never happened?

Comment 15 Sam James archtester

2024-04-20 13:19:51 UTC

sparc done

all arches done