Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 908690 - media-sound/guitarix: restore parallel build
Summary: media-sound/guitarix: restore parallel build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Miroslav Šulc
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-06-17 16:13 UTC by Alexander Tsoy
Modified: 2024-01-05 10:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2023-06-17 16:13:00 UTC
If --jobs option is passed to waf configure, then build system ignores --jobs passed to waf build. And since waf-utils.eclass always pass --jobs=1 to waf configure we are always building using only 1 job. This is a result of these changes:

https://github.com/brummer10/guitarix/commit/a5917a8a7274a57e1ce40aa297d73ad45853a473
https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/waf-utils.eclass?id=c8bbd4cf6d3b4f87a78dddf7d85fabe68fc27b20
Comment 1 Larry the Git Cow gentoo-dev 2024-01-05 10:36:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1d7684da16b55f8e0f3b9283e757167b399951b

commit b1d7684da16b55f8e0f3b9283e757167b399951b
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2024-01-03 12:32:26 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-01-05 10:32:53 +0000

    media-sound/guitarix: restore parallel build
    
    Build system messes with the build jobs count, so that waf build
    always respects the number of jobs passed to waf configure. And
    since waf-utils eclass passes --jobs=1 to waf configure, we are
    always building using only 1 job.
    
    Pass --jobs with the correct number of jobs to waf configure as a
    workaround.
    
    Closes: https://bugs.gentoo.org/908690
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/34639
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../{guitarix-0.41.0-py3.11.patch => guitarix-0.44.1-py3.11.patch} | 0
 media-sound/guitarix/guitarix-0.44.1.ebuild                        | 7 ++++---
 media-sound/guitarix/guitarix-9999.ebuild                          | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)