Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 908557 (CVE-2023-34453, CVE-2023-34454, CVE-2023-34455) - <dev-java/snappy-1.1.10.1: multiple vulnerabilities
Summary: <dev-java/snappy-1.1.10.1: multiple vulnerabilities
Status: IN_PROGRESS
Alias: CVE-2023-34453, CVE-2023-34454, CVE-2023-34455
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Security
URL:
Whiteboard: B3 [glsa?]
Keywords: PullRequest
Depends on: 916061
Blocks:
  Show dependency tree
 
Reported: 2023-06-16 02:49 UTC by John Helmert III
Modified: 2023-11-25 08:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2023-06-16 02:49:43 UTC
CVE-2023-34453 (https://github.com/xerial/snappy-java/security/advisories/GHSA-pqr6-cmr2-h8hf):

snappy-java is a fast compressor/decompressor for Java. Due to unchecked multiplications, an integer overflow may occur in versions prior to 1.1.10.1, causing a fatal error.

The function `shuffle(int[] input)` in the file `BitShuffle.java` receives an array of integers and applies a bit shuffle on it. It does so by multiplying the length by 4 and passing it to the natively compiled shuffle function. Since the length is not tested, the multiplication by four can cause an integer overflow and become a smaller value than the true size, or even zero or negative. In the case of a negative value, a `java.lang.NegativeArraySizeException` exception will raise, which can crash the program. In a case of a value that is zero or too small, the code that afterwards references the shuffled array will assume a bigger size of the array, which might cause exceptions such as `java.lang.ArrayIndexOutOfBoundsException`.

The same issue exists also when using the `shuffle` functions that receive a double, float, long and short, each using a different multiplier that may cause the same issue.

Version 1.1.10.1 contains a patch for this vulnerability.

CVE-2023-34454 (https://github.com/xerial/snappy-java/security/advisories/GHSA-fjpj-2g6w-x25r):

snappy-java is a fast compressor/decompressor for Java. Due to unchecked multiplications, an integer overflow may occur in versions prior to 1.1.10.1, causing an unrecoverable fatal error.

The function `compress(char[] input)` in the file `Snappy.java` receives an array of characters and compresses it. It does so by multiplying the length by 2 and passing it to the rawCompress` function.

Since the length is not tested, the multiplication by two can cause an integer overflow and become negative. The rawCompress function then uses the received length and passes it to the natively compiled maxCompressedLength function, using the returned value to allocate a byte array.

Since the maxCompressedLength function treats the length as an unsigned integer, it doesn’t care that it is negative, and it returns a valid value, which is casted to a signed integer by the Java engine. If the result is negative, a `java.lang.NegativeArraySizeException` exception will be raised while trying to allocate the array `buf`. On the other side, if the result is positive, the `buf` array will successfully be allocated, but its size might be too small to use for the compression, causing a fatal Access Violation error.

The same issue exists also when using the `compress` functions that receive double, float, int, long and short, each using a different multiplier that may cause the same issue. The issue most likely won’t occur when using a byte array, since creating a byte array of size 0x80000000 (or any other negative value) is impossible in the first place.

Version 1.1.10.1 contains a patch for this issue.

CVE-2023-34455 (https://github.com/xerial/snappy-java/security/advisories/GHSA-qcwq-55hx-v3vh):

snappy-java is a fast compressor/decompressor for Java. Due to use of an unchecked chunk length, an unrecoverable fatal error can occur in versions prior to 1.1.10.1.

The code in the function hasNextChunk in the fileSnappyInputStream.java checks if a given stream has more chunks to read. It does that by attempting to read 4 bytes. If it wasn’t possible to read the 4 bytes, the function returns false. Otherwise, if 4 bytes were available, the code treats them as the length of the next chunk.

In the case that the `compressed` variable is null, a byte array is allocated with the size given by the input data. Since the code doesn’t test the legality of the `chunkSize` variable, it is possible to pass a negative number (such as 0xFFFFFFFF which is -1), which will cause the code to raise a `java.lang.NegativeArraySizeException` exception. A worse case would happen when passing a huge positive value (such as 0x7FFFFFFF), which would raise the fatal `java.lang.OutOfMemoryError` error.

Version 1.1.10.1 contains a patch for this issue.

Fixes in 1.1.10.1, please bump.
Comment 1 Larry the Git Cow gentoo-dev 2023-09-21 06:41:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fbc771aba4be60c25e01147b4c2790b4eb5ef0e

commit 5fbc771aba4be60c25e01147b4c2790b4eb5ef0e
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-06-16 14:55:12 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-09-21 06:39:36 +0000

    dev-java/snappy: add 1.1.10.1 - CVE-2023-34453, CVE-2023-34454, CVE-2023-34455
    
    Bug: https://bugs.gentoo.org/908557
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/31515
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 dev-java/snappy/Manifest                           |   2 +
 .../snappy-1.1.10.1-SnappyOutputStreamTest.patch   |  26 +++++
 .../files/snappy-1.1.10.1-unbundle-snappy.patch    |  51 +++++++++
 dev-java/snappy/snappy-1.1.10.1.ebuild             | 124 +++++++++++++++++++++
 4 files changed, 203 insertions(+)
Comment 2 Miroslav Šulc gentoo-dev 2023-11-25 08:41:36 UTC
the tree is clean now, you can proceed