Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 908349 - net-irc/ngircd-26.1-r5: config file permissions can be improved
Summary: net-irc/ngircd-26.1-r5: config file permissions can be improved
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Zhixu Liu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-11 09:55 UTC by Rolf Eike Beer
Modified: 2024-12-27 17:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2023-06-11 09:55:16 UTC
/etc/ngircd is 755 root:root
/etc/ngircd/ngircd.conf is 600 ngircd:ngircd

Since the daemon never needs to write the config file I suggest changing it to:
/etc/ngircd/ngircd.conf 640 root:ngircd

If the proper directory permissions are 750 root:ngircd depends on the own paranioa.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2024-12-27 08:11:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fb4e36919add48669f8bff8471d7a0b4843fe04

commit 7fb4e36919add48669f8bff8471d7a0b4843fe04
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-27 08:11:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-27 08:11:04 +0000

    profiles: last rite net-irc/ngircd
    
    Unfixable modern C issues because of reliance on ancient automake.
    Out of date. See bug #946998. Removal on 2025-01-27.
    
    Bug: https://bugs.gentoo.org/719256
    Bug: https://bugs.gentoo.org/900082
    Bug: https://bugs.gentoo.org/908349
    Bug: https://bugs.gentoo.org/946998
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-12-27 15:11:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2704d5b853084e665c12d85e8129357b96780ca3

commit 2704d5b853084e665c12d85e8129357b96780ca3
Author:     Z. Liu <zhixu.liu@gmail.com>
AuthorDate: 2024-12-27 10:40:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-27 15:10:05 +0000

    net-irc/ngircd: fix several bugs
    
    1. USE="irc-plus" is default enabled now
    2. /etc/ngircd/{,ngircd.conf} owned by root:ngircd, and update permissions
    3. configure report getaddrinfo not works because of stricter compiler check:
         checking whether getaddrinfo() works... no
         configure:6303: x86_64-pc-linux-gnu-gcc -o conftest -g -O2 -pipe -W -Wall -Wpointer-arith -Wstrict-prototypes -fstack-protector -DSYSCONFDIR='"$(sysconfdir)"' -DDOCDIR='"$(docdir)"'   conftest.c  >&5
         conftest.c: In function 'main':
         conftest.c:99:9: error: implicit declaration of function 'memset' [-Wimplicit-function-declaration]
    
       configure.ac still use de-ANSI-fication (which is only available in
       old automake) in order to support old systems. So we can't patch
       configure.ac and run eautoreconf. see
       https://github.com/ngircd/ngircd/issues/261
    
       It's important to make sure ngircd-26.1-configure-getaddrinfo.patch
       works correctly for each new release.
    
    [sam: Committing as stable here given the IPv6 issue is bad and currently
    broken in stable.]
    
    Closes: https://bugs.gentoo.org/719256
    Closes: https://bugs.gentoo.org/900082
    Closes: https://bugs.gentoo.org/908349
    Closes: https://bugs.gentoo.org/946998
    Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/39860
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/ngircd-26.1-configure-getaddrinfo.patch  |  23 ++++
 net-irc/ngircd/metadata.xml                        |   9 +-
 net-irc/ngircd/ngircd-26.1-r6.ebuild               | 130 +++++++++++++++++++++
 3 files changed, 161 insertions(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-12-27 17:37:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0af09bee7ccb2a75489b0dbfb08125b04b9efae4

commit 0af09bee7ccb2a75489b0dbfb08125b04b9efae4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-27 17:37:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-27 17:37:10 +0000

    profiles: unmask ngircd
    
    It's been adopted & fixed by someone in 2704d5b853084e665c12d85e8129357b96780ca3.
    
    Bug: https://bugs.gentoo.org/719256
    Bug: https://bugs.gentoo.org/900082
    Bug: https://bugs.gentoo.org/908349
    Bug: https://bugs.gentoo.org/946998
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)