Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 908291 - dev-qt/qtwidgets[gtk]: should depend on x11-libs/gtk+[X]
Summary: dev-qt/qtwidgets[gtk]: should depend on x11-libs/gtk+[X]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-11 03:54 UTC by Leonardo Hernández Hernández
Modified: 2023-06-22 16:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
The build log (build.log.xz,20.29 KB, application/x-xz)
2023-06-11 04:00 UTC, Leonardo Hernández Hernández
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Hernández Hernández 2023-06-11 03:54:47 UTC
qtwidgets includes a header (gdk/gdkx.h) that is only installed when gtk+ is installed with x11 support

Reproducible: Always

Steps to Reproduce:
1. Install x11-libs/gtk+[-X]
2. Try to compile dev-qt/qtwidgets[gtk]
Actual Results:  
qtwidgets fails to compile

Expected Results:  
qtwidgets should declare a dependency on gtk+[X]
Comment 1 Leonardo Hernández Hernández 2023-06-11 04:00:00 UTC
Created attachment 863688 [details]
The build log
Comment 2 Andreas Sturmlechner gentoo-dev 2023-06-19 20:54:34 UTC
I find that to be true.

Anyone interested may look into backporting upstream/dev commit edee40a179021323ebc0f7aafff506be3d34ef55 to Qt5's qmake buildsys.
Comment 3 Larry the Git Cow gentoo-dev 2023-06-19 20:56:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=6bb028064b2c4f98de7e4a9b58915bb438d6226d

commit 6bb028064b2c4f98de7e4a9b58915bb438d6226d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-06-19 20:55:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-06-19 20:55:28 +0000

    dev-qt/qtwidgets: Add missing x11-libs/gtk+[X] USEdep
    
    src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp includes gdk/gdkx.h
    
    Bug: https://bugs.gentoo.org/908291
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtwidgets/qtwidgets-5.15.10.9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2023-06-22 16:09:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b13367fc95dd3a12ecf2711fcb10ed164135c0a3

commit b13367fc95dd3a12ecf2711fcb10ed164135c0a3
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-06-19 20:55:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-06-22 16:09:23 +0000

    dev-qt/qtwidgets: Add missing x11-libs/gtk+[X] USEdep
    
    src/plugins/platformthemes/gtk3/qgtk3dialoghelpers.cpp includes gdk/gdkx.h
    
    Closes: https://bugs.gentoo.org/908291
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../qtwidgets/{qtwidgets-5.15.10.ebuild => qtwidgets-5.15.10-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)