Created attachment 863517 [details, diff] Patch adding support for Crosscode DLC Hi, the studio developping Crosscode has released a DLC (https://radicalfishgames.itch.io/crosscode-a-new-home). Since it has to be installed inside the game files, it seems better to me to allow its installation through a USE flag rather with a new package. I have attached a patch solving this issue. It has been tested and works perfectly fine.
It's nice to see someone using the CrossCode package. I do sometimes wonder whether anyone plays the games I add. Thanks for this. I would have added it myself, but CrossCode is a game I have a love/hate relationship with. I felt the need to finish it, but I simply cannot face the DLC. I don't agree with the approach taken here though. I suspect one download may change without the other, which would mean pointless reinstalls. It also doesn't matter that the DLC is installed within the wider game. They are still separate files. Even then, you could add an RDEPEND.
I’m fine with making a separate ebuild. Just how did you figure out the version number? ^^’
It's shown in the bottom right of the title screen. Maybe there's no equivalent for the DLC. A date-based version like 0_p20230619 will suffice if needs be.
Created attachment 864709 [details, diff] Patch adding games-rpg/crosscode-a-new-home Here is a patch adding a new package games-rpg/crosscode-a-new-home. In the metadata.xml file, I’ve assigned the games project as maintainer. For the version number, I’ve used a date-based version as advised, with the recorded upload date as shown on itch.
Created attachment 864793 [details, diff] Patch adding crosscode-a-new-home with proper install path The previous patch installed game files in a wrong location. Sorry for the noise, I should have tested before uploading. This one is tested and works properly. ;)
Hi, should I send this patch somewhere else where it’ll be easier for you to review it and integrate it? I don’t have a github account but I can use git-send-email to send it to the mailing-list (or email address) of your liking.
Sorry for sitting on this, we get a lot of mail. The patch is fine, but unfortunately we need a Signed-off-by line for legal reasons. Please amend the commit with the -s option. I'll get it merged right after that. https://www.gentoo.org/glep/glep-0076.html
Created attachment 873065 [details, diff] Signed-off patch adding crosscode-a-new-home No worries, there’s no emergency regarding this bug, I just wanted to make sure you did not forgot about it. ;) I’ve uploaded the signed-off patch. Feel free to reach out if anything is amiss.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9165ac02ee3e56655309a810d3c0dc69d4db0b70 commit 9165ac02ee3e56655309a810d3c0dc69d4db0b70 Author: Hoël Bézier <hoelbezier@riseup.net> AuthorDate: 2023-06-27 11:16:24 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2023-10-17 22:26:49 +0000 games-rpg/crosscode-a-new-home: new package, add 0_p20220419 Closes: https://bugs.gentoo.org/908027 Signed-off-by: Hoël Bézier <hoelbezier@riseup.net> Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-rpg/crosscode-a-new-home/Manifest | 1 + .../crosscode-a-new-home-0_p20220419.ebuild | 35 ++++++++++++++++++++++ games-rpg/crosscode-a-new-home/metadata.xml | 8 +++++ 3 files changed, 44 insertions(+)
