Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 907963 - www-client/firefox: breaks with RUSTFLAGS set to multiple values (mozbuild.configure.options.InvalidOptionError: RUSTFLAGS takes 1 value)
Summary: www-client/firefox: breaks with RUSTFLAGS set to multiple values (mozbuild.co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-06 20:57 UTC by Sam James
Modified: 2023-07-19 07:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_907963.txt,16.95 KB, text/plain)
2023-06-06 20:57 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-06 20:57:19 UTC
Created attachment 863434 [details]
build.log

Setting RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"  breaks Firefox.

In this particular case, DT_RELR doesn't matter here because (thanks q66/psykose for pointing this out) the C++ compiler is used for linking rather than Rust, but the principle of it is still important for other RUSTFLAGS.

--

 0:01.26 checking whether cross compiling... no
 0:01.43 Traceback (most recent call last):
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/configure.py", line 343, in <module>
 0:01.43     sys.exit(main(sys.argv))
 0:01.43              ^^^^^^^^^^^^^^
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/configure.py", line 126, in main
 0:01.43     sandbox.run(os.path.join(os.path.dirname(__file__), "moz.configure"))
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/configure/__init__.py", line 514, in run
 0:01.43     self._value_for(option)
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/configure/__init__.py", line 619, in _value_for
 0:01.43     return self._value_for_option(obj)
 0:01.43            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/util.py", line 1064, in method_call
 0:01.43     cache[args] = self.func(instance, *args)
 0:01.43                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/configure/__init__.py", line 654, in _value_for_option
 0:01.43     value, option_string = self._helper.handle(option)
 0:01.43                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/configure/options.py", line 591, in handle
 0:01.43     ret = option.get_value(arg, origin)
 0:01.43           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:01.43   File "/var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/python/mozbuild/mozbuild/configure/options.py", line 448, in get_value
 0:01.43     raise InvalidOptionError(
 0:01.43 mozbuild.configure.options.InvalidOptionError: RUSTFLAGS takes 1 value
*** Fix above errors and then restart with "./mach build"
 * ERROR: www-client/firefox-114.0::gentoo failed (configure phase):
 *   (no error message)
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-06 20:58:54 UTC
$ emerge --info
Portage 3.0.48 (python 3.12.0-beta-1, default/linux/amd64/17.1/hardened, gcc-13, glibc-2.37-r3, 6.1.32-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-6.1.32-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.37
KiB Mem:    65746048 total,  45832872 free
KiB Swap:   16662520 total,  16662520 free
Timestamp of repository gentoo: Tue, 06 Jun 2023 19:32:02 +0000
Head commit of repository gentoo: 183961e89c9b454cd225dc87e775a94b805ab95f

Timestamp of repository emacs: Mon, 29 May 2023 18:33:26 +0000
Head commit of repository emacs: f7ddf4a58ffefd181b7bc5d13978f8451567a168

Timestamp of repository kde: Tue, 06 Jun 2023 16:46:55 +0000
Head commit of repository kde: 13de4915bd0e796f7e11864167e745258810ed5a

Timestamp of repository qt: Tue, 06 Jun 2023 19:02:08 +0000
Head commit of repository qt: 811316350d48b6eb80ed9d56698a4115106d38a5

Timestamp of repository sam_c: Mon, 05 Jun 2023 16:17:05 +0000
Head commit of repository sam_c: c4b94b8b73fb77ff51b91c000b7e0b1c92255d1f

Timestamp of repository steam-overlay: Tue, 06 Jun 2023 18:02:22 +0000
Head commit of repository steam-overlay: 353d672ef461a3ec85708b960a5ffb3cecfe969a

sh dash 0.5.12
ld GNU ld (Gentoo 2.40 p5) 2.40.0
ccache version 4.8 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r3::gentoo
dev-java/java-config:      2.3.1-r1::gentoo
dev-lang/perl:             5.36.1-r2::gentoo
dev-lang/python:           3.10.11::gentoo, 3.11.3::gentoo, 3.12.0_beta1_p4::gentoo
dev-lang/rust:             1.69.0-r1::gentoo
dev-util/ccache:           4.8-r2::gentoo
dev-util/cmake:            3.26.4-r1::gentoo
dev-util/meson:            1.1.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-apps/systemd:          253.5::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.69-r9::gentoo, 2.71-r6::gentoo, 9999::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r5::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r3::gentoo, 16.0.5::gentoo, 17.0.0_pre20230602::gentoo
sys-devel/gcc:             10.4.1_p20230531::gentoo, 11.4.1_p20230601::gentoo, 12.3.1_p20230602::gentoo, 13.1.1_p20230603::gentoo, 14.0.0_pre20230529::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo, 17.0.0_pre20230602::gentoo
sys-devel/llvm:            15.0.7-r3::gentoo, 16.0.5::gentoo, 17.0.0_pre20230602::gentoo
sys-devel/make:            4.4.1-r1::gentoo
sys-kernel/linux-headers:  6.3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.37-r3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

emacs
    location: /var/db/repos/emacs
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/emacs.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

test
    location: /var/db/repos/test
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

Installed sets: @sam-emacs, @sam-fonts, @sam-fortune
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg cgroup clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
GENTOO_MIRRORS="http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 --output-sync=line"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libnotify libtirpc lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 pypy3 python3_10 python3_12" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc ppc64 ppc64le sparc sparc64" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-06 20:59:42 UTC
Fedora do https://src.fedoraproject.org/rpms/firefox/blob/rawhide/f/firefox-112.0-commasplit.patch but psykose mentioned we might be able to do  mk_add_options RUSTFLAGS=$RUSTFLAGS, not tried it (yet?)
Comment 3 Joonas Niilola gentoo-dev 2023-06-08 08:24:25 UTC
Hmmm I'm pretty sure I tested this after seeing https://old.reddit.com/r/Gentoo/comments/13nq5rt/firefox_rustflags_issue/ and it looked fine. Well at least with 

  RUSTFLAGS="-C target-cpu=native -C opt-level=3"

so link-arg is broken because the build system handles that via configure, and not via *FLAGS I presume?
Comment 4 Larry the Git Cow gentoo-dev 2023-07-04 16:58:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd5adc443754e0a0c7f28cbbac70a21d6953ef85

commit bd5adc443754e0a0c7f28cbbac70a21d6953ef85
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-07-04 16:50:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-07-04 16:58:22 +0000

    www-client/firefox: include Fedora's RUSTFLAGS patch in 115.0
    
    Bug: https://bugs.gentoo.org/907963
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest             | 2 +-
 www-client/firefox/firefox-115.0.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 Joonas Niilola gentoo-dev 2023-07-04 17:01:03 UTC
* Current BINDGEN_CFLAGS:	no value set
 * Current CFLAGS:		-march=native -O2 -pipe -frecord-gcc-switches
 * Current CXXFLAGS:		-march=native -O2 -pipe -frecord-gcc-switches
 * Current LDFLAGS:		-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0
 * Current RUSTFLAGS:		-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs
 * Enforcing the use of clang due to USE=clang ...
 * Build BINDGEN_CFLAGS:	no value set
 * Build CFLAGS:		-march=native -pipe -frecord-gcc-switches
 * Build CXXFLAGS:		-march=native -pipe -frecord-gcc-switches
 * Build LDFLAGS:		-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,--compress-debug-sections=zlib -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags
 * Build RUSTFLAGS:		-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs

at least it doesn't break, but not sure if these do anything at all in the build system.
Comment 6 Larry the Git Cow gentoo-dev 2023-07-12 15:33:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a68115bb5494d9f85c23928a1547be25c7f3d0f4

commit a68115bb5494d9f85c23928a1547be25c7f3d0f4
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-07-12 15:30:03 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-07-12 15:33:39 +0000

    mail-client/thunderbird: add 115.0
    
    Bug: https://bugs.gentoo.org/910229
    Bug: https://bugs.gentoo.org/908993
    Bug: https://bugs.gentoo.org/907963
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/Manifest                 |   66 ++
 mail-client/thunderbird/thunderbird-115.0.ebuild | 1319 ++++++++++++++++++++++
 2 files changed, 1385 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2023-07-19 07:48:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5448a004c202c6bd69f3999db480a17537d9a8f

commit b5448a004c202c6bd69f3999db480a17537d9a8f
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-07-19 07:45:41 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-07-19 07:48:06 +0000

    www-client/firefox: add 115.0.3
    
     - note: this is the ESR version.
    
     - a great opportunity to push 115-esr into the tree as 115.0.3 only contains
       Windows-related fixes. This allows syncing 115+:rapid and 115+:esr in the
       tree when going forward for any ebuild-related updates.
     - pushed as unkeyworded because this is still a testing version. Keywords
       will be added when Mozilla encourages esr users to update from 102 into 115.
       The next major ESR, 115.1.0, will be package.masked.
    
    Closes: https://bugs.gentoo.org/903061
    Closes: https://bugs.gentoo.org/908992
    Closes: https://bugs.gentoo.org/907963
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               |  101 +++
 www-client/firefox/firefox-115.0.3.ebuild | 1406 +++++++++++++++++++++++++++++
 2 files changed, 1507 insertions(+)