Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 907404 - net-vpn/openfortivpn does not work with net-dialup/ppp-2.5.0-r2
Summary: net-vpn/openfortivpn does not work with net-dialup/ppp-2.5.0-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 904841
  Show dependency tree
 
Reported: 2023-05-30 10:14 UTC by Ville Oikarinen
Modified: 2023-07-04 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ville Oikarinen 2023-05-30 10:14:59 UTC
When I upgraded ppp from 2.4.9-r9, openfortivpn started failing connects, reporting "Peer refused to agree to his IP address".

Since the newer ppp requires 4 new kernel flags compared to the old version (PPP_SYNC_TTY, PPP_MPPE, PPPEO and PPPOATM), I enabled them and re-emerged several packages.

But I got back to a working VPN only by downgrading back to the older version.

That's the facts, and then some speculation: By diffing the ppp sources I saw that file ipcp.c has started requesting WINS addresses (if configured - I don't know how the gentoo package configures it) from the server. And the statement that prints the mentioned error message is new code here. So I speculate that the newer ppp requests WINS addresses, and when the server denies them, the client does not connect. (Who uses WINS addresses anyway?)

Reproducible: Always

Steps to Reproduce:
1. emerge ppp-2.5.0-r2 instead of ppp-2.4.9-r9
2. try to open VPN with openfortivpn
Actual Results:  
Openfortivpn prints "Peer refused to agree to his IP address" and fails to connect.

Expected Results:  
No errors, VPN connection established.
Comment 1 Mike Gilbert gentoo-dev 2023-05-30 15:52:24 UTC
The WINS address stuff is only enabled if the "usepeerwins" option is enabled via /etc/ppp/options or the pppd command line.
Comment 2 Mike Gilbert gentoo-dev 2023-05-30 15:55:48 UTC
What version of openfortivpn are you using?
Comment 3 Mike Gilbert gentoo-dev 2023-05-30 15:59:59 UTC
I would suggest working with openfortivpn upstream on this.
Comment 4 Mike Gilbert gentoo-dev 2023-05-30 19:34:20 UTC
Try adding these options to /etc/ppp/options:

ipcp-accept-local
ipcp-accept-remote
Comment 5 Mike Gilbert gentoo-dev 2023-05-30 20:40:04 UTC
I think this will fix it:

https://github.com/adrienverge/openfortivpn/pull/1111
Comment 6 Ville Oikarinen 2023-05-31 07:24:25 UTC
(In reply to Mike Gilbert from comment #2)
> What version of openfortivpn are you using?

I'm using openfortivpn-1.19.0.

I noticed that "emerge -avuDN --with-bdeps=y world" proposes now a newer 1.20.2 that depends on <net-dialup/ppp-2.5.0, so updating the world shouldn't break things, for now.
Comment 7 Larry the Git Cow gentoo-dev 2023-06-01 18:50:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44281f12d6e8cd62c1919b5a4fe8274346fc2cd9

commit 44281f12d6e8cd62c1919b5a4fe8274346fc2cd9
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-06-01 18:50:21 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-06-01 18:50:21 +0000

    net-vpn/openfortivpn: fix for ppp-2.5.0
    
    Closes: https://bugs.gentoo.org/907404
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 ...enfortivpn-1.20.3-pppd-ipcp-accept-remote.patch | 33 ++++++++++++++++++++++
 ...1.20.3.ebuild => openfortivpn-1.20.3-r1.ebuild} |  1 +
 2 files changed, 34 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2023-06-01 19:14:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6cb583d41625834a0e64d93c1fa095ab905df5b

commit d6cb583d41625834a0e64d93c1fa095ab905df5b
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-06-01 19:13:50 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-06-01 19:13:50 +0000

    net-vpn/openfortivpn: drop version cap on net-dialup/ppp
    
    Bug: https://bugs.gentoo.org/907404
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../{openfortivpn-1.20.3-r1.ebuild => openfortivpn-1.20.3-r2.ebuild}    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)