dev-python/txtorcon: missing tests, the ebuild emits QA warning about that dev-python/magic-wormhole-mailbox-server: fails to build w/ py3.11+: ValueError: invalid mode: 'rU' dev-python/spake2: fails to build w/ py3.12+: AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'? I didn't check the remaining dev-python/magic-wormhole* packages because of build failures above. This proves that the maintainer didn't even put sufficient effort to do build testing. Please revert.
I think it's okay for us to revert it now given it doesn't work at all (it's not just a "normal" QA issue with missing tests, rather it's incomplete and doesn't work).
+1 from me, the typical rU issue especially bother me now that we're on 3.11 default
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be1ced44becc934be572680a05dfee963d8a81e4 commit be1ced44becc934be572680a05dfee963d8a81e4 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:13:15 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:13:15 +0000 dev-python/hkdf: Revert "new package, add 0.0.3" Reverts: 5509b34dac1a41c8243c83777fe3d62bd3ed41e7 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/hkdf/Manifest | 1 - dev-python/hkdf/hkdf-0.0.3.ebuild | 17 ----------------- dev-python/hkdf/metadata.xml | 13 ------------- 3 files changed, 31 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24e89645ddaebeb2379cd08ee75a940301430212 commit 24e89645ddaebeb2379cd08ee75a940301430212 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:12:59 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:12:59 +0000 dev-python/spake2: Revert "new package, add 0.8" Reverts: 920c91353dcc85654169ab4ee461cece350addd5 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/spake2/Manifest | 1 - dev-python/spake2/metadata.xml | 13 ------------- dev-python/spake2/spake2-0.8.ebuild | 21 --------------------- 3 files changed, 35 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a1ce543850bdfa9f69bcf6c0984bd48cb03fdce commit 6a1ce543850bdfa9f69bcf6c0984bd48cb03fdce Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:12:40 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:12:40 +0000 dev-python/txtorcon: Revert "new package, add 23.5.0" Reverts: 08bdbf8f0f1fb4e813f3c6e790478fcf54d2bcfa Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/txtorcon/Manifest | 1 - dev-python/txtorcon/metadata.xml | 13 ------------- dev-python/txtorcon/txtorcon-23.5.0.ebuild | 21 --------------------- 3 files changed, 35 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67602751402c90e28193dd4140d6c89de52ae640 commit 67602751402c90e28193dd4140d6c89de52ae640 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:12:22 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:12:22 +0000 dev-python/magic-wormhole: Revert "new package, add 0.12.0" Reverts: f9d398f785276139faeb3634135792bfc18e87ab Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/magic-wormhole/Manifest | 1 - .../magic-wormhole/magic-wormhole-0.12.0.ebuild | 31 ---------------------- dev-python/magic-wormhole/metadata.xml | 13 --------- 3 files changed, 45 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18f6d32599baafaabd4457736e8f1742bc103ac2 commit 18f6d32599baafaabd4457736e8f1742bc103ac2 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:12:01 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:12:01 +0000 dev-python/magic-wormhole-transit-relay: Revert "new package, add 0.2.1" Reverts: b0e3e83e43d0bf5187dd4b2be05b924c06a0c28c Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/magic-wormhole-transit-relay/Manifest | 1 - .../magic-wormhole-transit-relay-0.2.1.ebuild | 20 -------------------- dev-python/magic-wormhole-transit-relay/metadata.xml | 13 ------------- 3 files changed, 34 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83d091ec30b5325a1ca15b423d03deb62ae7da5f commit 83d091ec30b5325a1ca15b423d03deb62ae7da5f Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-05-25 03:11:32 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-05-25 03:11:32 +0000 dev-python/magic-wormhole-mailbox-server: Revert "new package, add 0.4.1" Reverts: d94a5f976d1c356a129aabe889386a26907a9b92 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-python/magic-wormhole-mailbox-server/Manifest | 1 - .../magic-wormhole-mailbox-server-0.4.1.ebuild | 21 --------------------- .../magic-wormhole-mailbox-server/metadata.xml | 13 ------------- 3 files changed, 35 deletions(-)
(In reply to Michał Górny from comment #0) > This proves that the maintainer didn't even put sufficient effort to do > build testing. Please revert. *blink* Alright.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e8f09bb1a8303e079169766ea55130b9758a56d commit 9e8f09bb1a8303e079169766ea55130b9758a56d Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-25 21:17:32 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-25 21:20:54 +0000 dev-python/txtorcon: new package, add 23.5.0 Revision: - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/txtorcon/Manifest | 1 + dev-python/txtorcon/metadata.xml | 13 ++++++++++++ dev-python/txtorcon/txtorcon-23.5.0.ebuild | 32 ++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f902a3c33fda6222c1d761c46c1a6a86cd2c0caa commit f902a3c33fda6222c1d761c46c1a6a86cd2c0caa Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-25 20:57:16 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-25 21:20:54 +0000 dev-python/spake2: new package, add 0.8 Revision: - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/spake2/Manifest | 1 + dev-python/spake2/metadata.xml | 13 +++++++++++++ dev-python/spake2/spake2-0.8.ebuild | 24 ++++++++++++++++++++++++ 3 files changed, 38 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65cbedd4874bda39804ccb80cd64dde9b13e68ce commit 65cbedd4874bda39804ccb80cd64dde9b13e68ce Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-25 20:36:44 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-25 21:20:54 +0000 dev-python/hkdf: new package, add 0.0.3 Revision: - use proper SRC_URI downloading from github - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/hkdf/Manifest | 1 + dev-python/hkdf/hkdf-0.0.3.ebuild | 23 +++++++++++++++++++++++ dev-python/hkdf/metadata.xml | 13 +++++++++++++ 3 files changed, 37 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06217f827264db4a132d3f985f9fb354d669eae0 commit 06217f827264db4a132d3f985f9fb354d669eae0 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-24 22:23:11 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-25 23:12:23 +0000 dev-python/magic-wormhole-transit-relay: new package, add 0.2.1_p20230525 Revision: - move to latest upstream patches for python 3.11 support - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/magic-wormhole-transit-relay/Manifest | 1 + ...c-wormhole-transit-relay-0.2.1_p20230525.ebuild | 28 ++++++++++++++++++++++ .../magic-wormhole-transit-relay/metadata.xml | 13 ++++++++++ 3 files changed, 42 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b55e0b4edfc03e6112d96f9358eba57a491d30f0 commit b55e0b4edfc03e6112d96f9358eba57a491d30f0 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-24 22:36:49 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-25 23:12:23 +0000 dev-python/magic-wormhole-mailbox-server: new package, add 0.4.1_p20230525 Revision: - move to latest upstream patches for python 3.11 support - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/magic-wormhole-mailbox-server/Manifest | 1 + ...-wormhole-mailbox-server-0.4.1_p20230525.ebuild | 29 ++++++++++++++++++++++ .../magic-wormhole-mailbox-server/metadata.xml | 13 ++++++++++ 3 files changed, 43 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f841741e2f615652aa73bdc6cb435ec572a5ae6 commit 2f841741e2f615652aa73bdc6cb435ec572a5ae6 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-24 21:59:09 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 01:04:32 +0000 dev-python/magic-wormhole: new package, add 0.12.0_p20230525 Revision: - move to latest upstream patches for python 3.11 support - enable testsuite - verified that the package installs cleanly for 3.10 and 3.11 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/magic-wormhole/Manifest | 1 + .../magic-wormhole-0.12.0_p20230525.ebuild | 51 ++++++++++++++++++++++ dev-python/magic-wormhole/metadata.xml | 13 ++++++ 3 files changed, 65 insertions(+)
Packages were readded with further QA issues: - dev-python/hkdf with (unnecessary) dep on dev-python/nose that's on its way out - multiple unnecessary uses of vcs-snapshot - dev-python/magic-wormhole fails tests: ERROR src/wormhole/test/test_hints.py::describe_hint_obj - TypeError: describe_hint_obj() missing 3 required positional arguments: 'hin t', 'relay', and 'tor' ERROR src/wormhole/test/dilate/test_connector.py::describe_inbound - TypeError: describe_inbound() missing 1 required positional argume nt: 'addr'
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5aa395aaca8f48da1c6cc0b5c79e22e7e76154e8 commit 5aa395aaca8f48da1c6cc0b5c79e22e7e76154e8 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-26 07:59:39 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 08:00:13 +0000 dev-python/hkdf: treeclean Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/hkdf/Manifest | 1 - dev-python/hkdf/hkdf-0.0.3.ebuild | 23 ----------------------- dev-python/hkdf/metadata.xml | 13 ------------- 3 files changed, 37 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=825af0a2600cbe7454c0eed9c7034bbb867e0c6b commit 825af0a2600cbe7454c0eed9c7034bbb867e0c6b Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-26 07:57:08 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 08:00:12 +0000 dev-python/spake2: change to dev-python/cryptography Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> .../files/spake2-0.8-do_not_use_hkdf_package.patch | 113 +++++++++++++++++++++ .../{spake2-0.8.ebuild => spake2-0.8-r1.ebuild} | 8 +- 2 files changed, 119 insertions(+), 2 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8715822c57cf2a409b1515413fa564da5ccf3303 commit 8715822c57cf2a409b1515413fa564da5ccf3303 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-26 08:05:00 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 09:02:58 +0000 dev-python/magic-wormhole-mailbox-server: QA - add missing test dependency on dev-python/mock - as requested in bug #907117, do not use vcs-snapshot - even though this makes for much nicer paths when using commit snapshots... Closes: https://bugs.gentoo.org/907199 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> .../magic-wormhole-mailbox-server-0.4.1_p20230525.ebuild | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bcba35091d347f92a741c3590daf75a548cdea9 commit 3bcba35091d347f92a741c3590daf75a548cdea9 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-26 09:18:44 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 09:20:46 +0000 dev-python/magic-wormhole-transit-relay: QA - add missing test dependency on dev-python/mock - as requested in bug #907117, do not use vcs-snapshot - even though this makes for much nicer paths when using commit snapshots... Closes: https://bugs.gentoo.org/907200 Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> .../magic-wormhole-transit-relay-0.2.1_p20230525.ebuild | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ec50c0ec9e1cdc6072d97c59d1ec668714f8efa commit 6ec50c0ec9e1cdc6072d97c59d1ec668714f8efa Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-05-26 09:27:13 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-05-26 09:27:13 +0000 dev-python/magic-wormhole: QA - as requested in bug #907117, do not use vcs-snapshot - even though this makes for much nicer paths when using commit snapshots... Bug: https://bugs.gentoo.org/907117 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-python/magic-wormhole/magic-wormhole-0.12.0_p20230525.ebuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(In reply to Michał Górny from comment #8) > - dev-python/magic-wormhole fails tests: > > ERROR src/wormhole/test/test_hints.py::describe_hint_obj - TypeError: > describe_hint_obj() missing 3 required positional arguments: 'hin > t', 'relay', and 'tor' > ERROR src/wormhole/test/dilate/test_connector.py::describe_inbound - > TypeError: describe_inbound() missing 1 required positional argume > nt: 'addr' Passes for me. Could you share the log?
Created attachment 862627 [details] /var/log/portage/dev-python:magic-wormhole-0.12.0_p20230525:20230526-030730.log Perhaps it's another case of random plugin breaking stuff.
(In reply to Michał Górny from comment #8) > ERROR src/wormhole/test/test_hints.py::describe_hint_obj - TypeError: > describe_hint_obj() missing 3 required positional arguments: 'hin > t', 'relay', and 'tor' > ERROR src/wormhole/test/dilate/test_connector.py::describe_inbound - > TypeError: describe_inbound() missing 1 required positional argume > nt: 'addr' I have rerun the magic-wormhole tests on three different userlands: - my developer machine, mixed keywording: 454 passed, 31 warnings in 37.50s - stage-3 keyworded ~amd64: 454 passed, 66 warnings in 36.10s - stage-3 keyworded amd64: 454 passed, 66 warnings in 36.65s Would you mind to share an emerge --info and the precise package versions of all reverse dependencies so that I have a chance of reproducing?
(In reply to Michał Górny from comment #14) > Created attachment 862627 [details] > /var/log/portage/dev-python:magic-wormhole-0.12.0_p20230525:20230526-030730. > log > > Perhaps it's another case of random plugin breaking stuff. It's pytest-describe being autoloaded breaking stuff.
