Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 907060 - net-misc/asterisk logrotate queue_log
Summary: net-misc/asterisk logrotate queue_log
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-05-24 07:13 UTC by Vieri
Modified: 2023-08-11 08:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vieri 2023-05-24 07:13:15 UTC
The ebuild for net-misc/asteris installs a logrotate file that treats 'queue_log' and 'messages' the same (https://gitweb.gentoo.org/repo/gentoo.git/tree/net-misc/asterisk/files/1.6.2/asterisk.logrotate4). Why?

Since queue_log is a call detail log (in the sense that it logs when a call enters and exits/completes the queue), shouldn't it be treated just like 'cdr-csv/*.csv'?
Comment 1 Jaco Kroon 2023-06-07 11:27:49 UTC
Hi,

Because that's the way I received it, but sure we can change that one, would you mind waiting for the next release cycle?

Perhaps even attach what you would suggest for logrotate?

We don't particularly use queue_log and ours doesn't grow at insane stupid rates (our messages are probably ten times the size of queue_log, with full probably about 20 times the size of messages), but what you say make a lot of sense.

Kind Regards,
Jaco
Comment 2 Jaco Kroon 2023-07-10 08:45:42 UTC
I've moved the logrotate into asterisk-base now, along with all the init related stuff.  This is new package contains all the gentoo-specific support infrastructure for asterisk.
Comment 3 Vieri 2023-07-13 15:12:07 UTC
No rush at all.
I can definitely wait.
Thanks!
Comment 4 Jaco Kroon 2023-07-14 06:33:27 UTC
Hi,

Please confirm if you're happy with the PR, and specifically:

https://github.com/gentoo/gentoo/pull/31816/commits/9664299aa1eb0a0727b01f1a038e5c684846f3f6#diff-91b74202755dadf8fb53cf0bab214702358f9f815d865c0551fc0a34252eb537

Kind regards,
Jaco
Comment 5 Larry the Git Cow gentoo-dev 2023-08-11 08:13:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=959deea778d9aa4f174493f2a9d390d14a3c4df1

commit 959deea778d9aa4f174493f2a9d390d14a3c4df1
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2023-07-09 19:46:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-11 08:12:05 +0000

    net-misc/asterisk-base: new package, add 1
    
    Closes: https://bugs.gentoo.org/907060
    
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/asterisk-base/asterisk-base-1.ebuild      |  42 +++
 net-misc/asterisk-base/files/asterisk.service-1    |  23 ++
 .../asterisk-base/files/asterisk.service-1.conf    |  10 +
 net-misc/asterisk-base/files/asterisk_wrapper-1    | 227 +++++++++++++++
 net-misc/asterisk-base/files/confd-1               | 169 +++++++++++
 net-misc/asterisk-base/files/initd-1               | 311 +++++++++++++++++++++
 net-misc/asterisk-base/files/logrotate-1           |  27 ++
 net-misc/asterisk-base/files/tmpfiles-1.conf       |   2 +
 net-misc/asterisk-base/metadata.xml                |  12 +
 9 files changed, 823 insertions(+)