Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906939 - [guru] app-editors/pulsar-bin-1.105.0 installs files with broken symlink
Summary: [guru] app-editors/pulsar-bin-1.105.0 installs files with broken symlink
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: YiFei Zhu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2023-05-22 10:07 UTC by Agostino Sarubbo
Modified: 2023-05-25 02:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,83.67 KB, text/plain)
2023-05-22 10:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-05-22 10:07:01 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/pulsar-bin-1.105.0 installs files with broken symlink.
Discovered on: amd64 (internal ref: guru_ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-05-22 10:07:03 UTC
Created attachment 862180 [details]
build.log

build log and emerge --info
Comment 2 YiFei Zhu 2023-05-22 16:40:31 UTC
> Symbolic link /opt/Pulsar/resources/app.asar.unpacked/node_modules/tree-sitter-bash/build/node_gyp_bins/python3 points to /usr/bin/python3 which does not exist.

Does a RDEPEND on dev-lang/python-exec[native-symlinks] makes sense?
Comment 3 Viorel Munteanu gentoo-dev 2023-05-22 17:19:22 UTC
No, please don't do that.  Depending on python is explicitly forbidden by a QA rule: https://projects.gentoo.org/qa/policy-guide/languages.html#pg0501

Please check if the symlink is actually used, you might be able to simply remove it in src_install.

If it really is needed, please read the python guide https://projects.gentoo.org/python/guide/single.html and depend on python correctly, then fix the symlink to point to the proper python interpreter (something like
dosym -r "${PYTHON}" "${$ED}"/opt/Pulsar/blahblahblah/python3 )

btw, from build log you also need to depend on x11-libs/libxkbcommon:

 * QA Notice: Unresolved soname dependencies:
 * 
 * 	/opt/Pulsar/pulsar: libxkbcommon.so.0
 * 

Thank you.
Comment 4 YiFei Zhu 2023-05-22 17:36:27 UTC
> If it really is needed, please read the python guide https://projects.gentoo.org/python/guide/single.html and depend on python correctly, then fix the symlink to point to the proper python interpreter (something like

Problem is this is an upstream binary package extracted here. It's not a symlink created explicitly by the ebuild

Though, a quick search around the web shows
- https://github.com/nodejs/node-gyp/issues/2713 - seems like part of the build process and not the run process
- https://github.com/tree-sitter/tree-sitter-bash - python seems unused in here

And a quick test by removing the directory nothing seems broken. I think I'll remove the symlink and the containing directory (the symlink is the only file inside) in the ebuild.

> btw, from build log you also need to depend on x11-libs/libxkbcommon:

Thanks for noting. I fixed it earlier in https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=f3c50dca839159c343c02a88654e04e2c77cdd45 for https://bugs.gentoo.org/906938
Comment 5 Larry the Git Cow gentoo-dev 2023-05-25 02:20:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=22db5ba15a4e2bf96111a3206e27938577912511

commit 22db5ba15a4e2bf96111a3206e27938577912511
Author:     YiFei Zhu <zhuyifei1999@gmail.com>
AuthorDate: 2023-05-22 17:42:04 +0000
Commit:     YiFei Zhu <zhuyifei1999@gmail.com>
CommitDate: 2023-05-22 17:42:04 +0000

    app-editors/pulsar-bin: remove node_gyp_bins directory
    
    Contains python3 symlink which may be broken depending on system.
    
    Closes: https://bugs.gentoo.org/906939
    Signed-off-by: YiFei Zhu <zhuyifei1999@gmail.com>

 app-editors/pulsar-bin/pulsar-bin-1.105.0.ebuild | 4 ++++
 1 file changed, 4 insertions(+)