Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906859 - sys-apps/util-linux-2.39 mount option 'user' ignores 'exec'
Summary: sys-apps/util-linux-2.39 mount option 'user' ignores 'exec'
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/util-linux/util-li...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-05-20 19:21 UTC by Hank Leininger
Modified: 2023-05-23 03:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2023-05-20 19:21:05 UTC
This was mentioned in unrelated bug about util-linux, #906797, comment https://bugs.gentoo.org/906797#c4

This seems like upstream issue https://github.com/util-linux/util-linux/issues/2238, for which there's been no discussion or fix yet.

mount(8) still says "This option implies the options noexec, nosuid, and nodev (unless overridden by subsequent options, as in the option line user,exec,dev,suid)." So it's apparently still intended that setting user,exec explicitly should not be mounted as noexec.

This is probably good enough reason to keep util-linux-2.39 masked even after #906797 is fixed.
Comment 1 Daniel Pouzzner 2023-05-20 19:25:38 UTC
Thanks Hank!

Re keeping 2.39 masked, that was my exact thinking.
Comment 2 Larry the Git Cow gentoo-dev 2023-05-23 03:14:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef0405e6d22915b93da87d5eb77ff132ca6da14

commit 5ef0405e6d22915b93da87d5eb77ff132ca6da14
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-23 03:13:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-23 03:13:20 +0000

    sys-apps/util-linux: backport another mount regression fix (user option parsing)
    
    Closes: https://bugs.gentoo.org/906859
    Signed-off-by: Sam James <sam@gentoo.org>

 .../util-linux-2.39-mount-parse-options-user.patch | 46 ++++++++++++++++++++++
 sys-apps/util-linux/util-linux-2.39-r2.ebuild      |  1 +
 2 files changed, 47 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca46cab3e9d658ced95d386616f0b2c3abda5400

commit ca46cab3e9d658ced95d386616f0b2c3abda5400
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2023-05-20 19:38:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-23 03:09:25 +0000

    sys-apps/util-linux: Fix for mount_setattr use on <5.12 kernels
    
    Backported pending upstream fix from
    https://github.com/util-linux/util-linux/pull/2248
    
    Note that there's at least one other breaking bug in util-linux-2.39
    so the mask probably shouldn't be removed yet.
    
    Bug: https://bugs.gentoo.org/906859
    Closes: https://bugs.gentoo.org/906797
    Closes: https://github.com/gentoo/gentoo/pull/31108
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../util-linux-2.39-check-for-mount_setattr.patch  |  94 +++++
 .../util-linux-2.39-tests-for-mount_setattr.patch  |  13 +
 sys-apps/util-linux/util-linux-2.39-r2.ebuild      | 398 +++++++++++++++++++++
 3 files changed, 505 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-23 03:31:15 UTC
We'll keep it masked until 2.39.1 at the very least. But I've pulled in the fix anyway.