Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906523 - www-servers/apache-2.4.57: fails to compile against net-libs/rustls-ffi-0.10.0
Summary: www-servers/apache-2.4.57: fails to compile against net-libs/rustls-ffi-0.10.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-16 06:37 UTC by Adrian Bassett
Modified: 2023-09-03 08:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Bassett 2023-05-16 06:37:30 UTC
Unbumped www-servers/apache ebuilds were recently modified to include a tls module with an implicit dependency on net-libs/rustls-ffi.

Not sure which version of rustls-ffi might have been used for testing but apache-2.4.57 (at least) fails to compile against net-libs/rustls-ffi-0.10.0:

tls_core.c:510:14: error: 'rustls_client_hello' has no member named 'sni_name'
  510 |     if (hello->sni_name.len > 0) {
      |              ^~
tls_core.c:511:55: error: 'rustls_client_hello' has no member named 'sni_name'
  511 |         cc->sni_hostname = apr_pstrndup(c->pool, hello->sni_name.data, hello->sni_name.len);
      |                                                       ^~
tls_core.c:511:77: error: 'rustls_client_hello' has no member named 'sni_name'
  511 | hostname = apr_pstrndup(c->pool, hello->sni_name.data, hello->sni_name.len);

However, the compile succeeds if rustls-ffi is downgraded to 0.9.1

There is some anticipation of this problem at https://www.mail-archive.com/dev@httpd.apache.org/msg77226.html




Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-16 06:39:42 UTC
I don't think it's an implicit dependency, it's set in the eclass.

Anyway, thanks.
Comment 2 Adrian Bassett 2023-05-16 06:41:38 UTC
(In reply to Sam James from comment #1)
> I don't think it's an implicit dependency, it's set in the eclass.
> 
> Anyway, thanks.

Sorry, missed that!
Comment 3 Leonid Kopylov 2023-05-23 16:13:59 UTC
Same for me. www-servers/apache-2.4.57 fails to build with net-libs/rustls-ffi-0.10.0, when apache2_modules_tls enabled
Comment 4 Zentoo 2023-05-25 16:13:11 UTC
www-servers:apache-2.4.57 fails to build here too with net-libs/rustls-ffi-0.10.0 and APACHE2_MODULES="tls" on ~amd64 system.
Comment 5 Larry the Git Cow gentoo-dev 2023-05-26 09:35:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fba530b2684f515d1da5f8e0baa1116a3e29f5a

commit 3fba530b2684f515d1da5f8e0baa1116a3e29f5a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-26 09:06:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-26 09:35:16 +0000

    www-servers/apache: fix build w/ rustls-ffi-0.10.0
    
    Closes: https://bugs.gentoo.org/906523
    Signed-off-by: Sam James <sam@gentoo.org>

 www-servers/apache/apache-2.4.57.ebuild            |  3 +-
 .../files/apache-2.4.57-rustls-ffi-0.10.0.patch    | 51 ++++++++++++++++++++++
 2 files changed, 53 insertions(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-09-03 08:32:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/apache.git/commit/?id=0e37a586f336fa92d10c4113b9e3ebd5012f6a00

commit 0e37a586f336fa92d10c4113b9e3ebd5012f6a00
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2023-09-03 08:31:25 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2023-09-03 08:31:25 +0000

    Add rustls-ffi patch
    
    Bug: https://bugs.gentoo.org/906523
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 2.4/patches/06_rustls_ffi.patch | 51 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)