906512 – dev-libs/expat: conditionally build tests

Bug 906512 - dev-libs/expat: conditionally build tests

Summary: dev-libs/expat: conditionally build tests

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Freedesktop bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2023-05-16 03:53 UTC by Sam James
Modified:	2023-05-31 13:01 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam James archtester

2023-05-16 03:53:38 UTC

Any reason to not do $(use_with test tests) to save building the tests if they're not going to be run?

Comment 1 Sebastian Pipping gentoo-dev

2023-05-16 10:29:40 UTC

Hi Sam, I'm not sure it matters. Does it? Would you be up to take this issue over?

Comment 2 Sam James archtester

2023-05-17 03:59:54 UTC

We generally try to conditionally build tests if we can to avoid wasted time, especially on very slow machines.

Anyway, sure.

Comment 3 Larry the Git Cow gentoo-dev

2023-05-31 03:26:20 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=932f1e8726ce40f5575371c44e539b81624badfd

commit 932f1e8726ce40f5575371c44e539b81624badfd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-31 03:13:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-31 03:13:58 +0000

    dev-libs/expat: conditionally build tests
    
    Closes: https://bugs.gentoo.org/906512
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/expat/expat-2.5.0.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 4 Sebastian Pipping gentoo-dev

2023-05-31 13:01:43 UTC

Thanks!