Building speex with USE=valgrind fails with: /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ../libspeex/.libs/libspeex.so: undefined reference to `VALGRIND_MAKE_READABLE' collect2: error: ld returned 1 exit status Reproducible: Always
Created attachment 861731 [details] emerge --info
Created attachment 861732 [details] build.log
Created attachment 861734 [details, diff] Patch for building with current valgrind VALGRIND_MAKE_READABLE has been replaced with VALGRIND_MAKE_MEM_DEFINED starting with version 3.2 (2006) https://valgrind.org/docs/manual/dist.news.old.html
Thank you! Would you mind sending this upstream or would you like me to?
I'm ok with you sending it upstream, if there still is one.
Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6baa20f72862687508e23181f49972f8e428a50 commit f6baa20f72862687508e23181f49972f8e428a50 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-05-16 03:55:13 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-16 03:55:13 +0000 media-libs/speex: fix valgrind build Closes: https://bugs.gentoo.org/906455 Thanks-to: Andrei Slavoiu <ansla80@yahoo.com> Signed-off-by: Sam James <sam@gentoo.org> media-libs/speex/files/speex-1.2.1-valgrind.patch | 53 +++++++++++++++++++++++ media-libs/speex/speex-1.2.1-r1.ebuild | 1 + media-libs/speex/speex-1.2.1.ebuild | 5 ++- 3 files changed, 58 insertions(+), 1 deletion(-)
Though I upgraded to media-libs/speex-1.2.1-r1 `emerge media-video/obs-studio` fails with: /usr/lib64/libspeex.so.1: undefined reference to `VALGRIND_MAKE_READABLE' Should I report a new bug for media-video/obs-studio?
(In reply to Lars from comment #8) > Though I upgraded to media-libs/speex-1.2.1-r1 `emerge > media-video/obs-studio` fails with: > > /usr/lib64/libspeex.so.1: undefined reference to `VALGRIND_MAKE_READABLE' > > Should I report a new bug for media-video/obs-studio? Nah, we can use this bug, I think. Could you rebuild it first just to check? emerge -v1 media-libs/speex. If that fixes obs for you, I'll revbump then.
(In reply to Sam James from comment #9) > (In reply to Lars from comment #8) > > Though I upgraded to media-libs/speex-1.2.1-r1 `emerge > > media-video/obs-studio` fails with: > > > > /usr/lib64/libspeex.so.1: undefined reference to `VALGRIND_MAKE_READABLE' > > > > Should I report a new bug for media-video/obs-studio? > > Nah, we can use this bug, I think. Could you rebuild it first just to check? > emerge -v1 media-libs/speex. > > If that fixes obs for you, I'll revbump then. I just realized that the patch was newer than my last sync. After syncing re-emerging media-libs/speex, emerging media-video/obs-studio succeeded.
Thank you! I'll revbump now.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b48ebe65007f0d5638b8e6459480de240987c317 commit b48ebe65007f0d5638b8e6459480de240987c317 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-05-17 07:12:45 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-17 07:13:26 +0000 media-libs/speex: revbump(!) for fixed valgrind patch Interestingly, the missing definition leaked into VALGRIND_MAKE_READABLE because of bfd's defaults :( Closes: https://bugs.gentoo.org/906455 Fixes: f6baa20f72862687508e23181f49972f8e428a50 Signed-off-by: Sam James <sam@gentoo.org> media-libs/speex/{speex-1.2.1-r1.ebuild => speex-1.2.1-r2.ebuild} | 0 1 file changed, 0 insertions(+), 0 deletions(-)
