Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906311 - java-pkg-simple.eclass: commit 3eb0cfe3 breaks test selection if JAVA_TEST_SRC_DIR lists multiple directories.
Summary: java-pkg-simple.eclass: commit 3eb0cfe3 breaks test selection if JAVA_TEST_SR...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest, REGRESSION
Depends on:
Blocks:
 
Reported: 2023-05-14 07:05 UTC by Volkmar W. Pogatzki
Modified: 2023-09-27 06:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Volkmar W. Pogatzki 2023-05-14 07:05:37 UTC
Commit 3eb0cfe3 seems to break test selection if there are multiple directories listed in JAVA_TEST_SRC_DIR as in dev-java/icu4j-72.1

JAVA_TEST_SRC_DIR=(
	tests/charset/src
	tests/collate/src
	tests/core/src
	...
)


It appears that tests only from the first directory are run:

debug: -Djava.io.tmpdir=/var/tmp/portage/dev-java/icu4j-72.1/temp
debug: -Djava.awt.headless=true
debug: -Djava.locale.providers=CLDR,COMPAT,SPI
debug: org.junit.runner.JUnitCore
debug: com.ibm.icu.dev.test.charset.TestSelection
debug: com.ibm.icu.dev.test.charset.TestConversion
debug: com.ibm.icu.dev.test.charset.TestCharset
JUnit version 4.13.2-SNAPSHOT

Reverting commit 3eb0cfe3 would solve this regression but would break test separation per module as intended for multi-jar packages like dev-java/byte-buddy-1.14.0
Comment 1 Volkmar W. Pogatzki 2023-05-14 07:08:34 UTC
CCing Leo3418
Comment 2 Larry the Git Cow gentoo-dev 2023-09-27 06:58:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0733594d8ff5e3fdd2b7617c36fdd2c761c66666

commit 0733594d8ff5e3fdd2b7617c36fdd2c761c66666
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-05-14 07:39:19 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-09-27 06:57:51 +0000

    Revert "java-pkg-simple.eclass: improve test selection for multi-jar packages"
    
    This reverts commit 3eb0cfe339e79270446731b8f27bdc1b060d023b.
    
    Closes: https://bugs.gentoo.org/906311
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 eclass/java-pkg-simple.eclass | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)