Bug 906221 – games-engines/odamex-10.3.0: Version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Wood 2023-05-12 19:54:15 UTC]

Version 10.3.0 of odamex was released on December 9, 2022: https://github.com/odamex/odamex/releases/tag/10.3.0

[Comment 1 Mike Wood 2023-05-12 19:55:22 UTC]

Created attachment 861587 [details]
games-engines/odamex-10.3.0 ebuild

Updated ebuild

[Comment 2 Mike Wood 2023-05-12 19:56:18 UTC]

Created attachment 861588 [details, diff]
games-engines/odamex-10.3.0 unbundle fltk patch

Unbundling fltk still requires a patch. Other unbundle patches are no longer necessary.

[Comment 3 Mike Wood 2023-05-12 19:57:19 UTC]

As this is a multiplayer engine this version bump should be proceeded by the removal of the 10.0.0 version. That will allow for a few bug reports to be closed as the reported issues are resolved in this version of the game engine.

[Comment 4 Larry the Git Cow 2023-05-14 14:26:35 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b86bdf2c2d16d11c6a6ba3465aec11cb656d6386

commit b86bdf2c2d16d11c6a6ba3465aec11cb656d6386
Author:     James Le Cuirot <[e-mail]>
AuthorDate: 2023-05-14 14:24:42 +0000
Commit:     James Le Cuirot <[e-mail]>
CommitDate: 2023-05-14 14:26:21 +0000

    games-engines/odamex: Bump to 10.3.0, drop old 10.0.0
    
    Thanks to Mike Wood for the ebuild. Upstream merged most of our patches. I have
    bumped wxGTK to 3.2.
    
    Closes: https://bugs.gentoo.org/906221
    Signed-off-by: James Le Cuirot <[e-mail]>

 games-engines/odamex/Manifest                      |  2 +-
 .../odamex/files/odamex-10.0.0-gcc12.patch         | 21 -----
 .../odamex/files/odamex-10.0.0-master-std.patch    | 28 -------
 .../odamex/files/odamex-10.0.0-musl.patch          | 60 --------------
 .../files/odamex-10.0.0-unbundle-jsoncpp.patch     | 85 -------------------
 .../files/odamex-10.0.0-unbundle-miniupnpc.patch   | 96 ----------------------
 ...ltk.patch => odamex-10.3.0-unbundle-fltk.patch} | 54 ++++--------
 games-engines/odamex/metadata.xml                  |  1 +
 .../{odamex-10.0.0.ebuild => odamex-10.3.0.ebuild} | 15 ++--
 9 files changed, 25 insertions(+), 337 deletions(-)

[Comment 5 Mike Wood 2023-05-14 18:48:58 UTC]

Bumping to wxGTK 3.2 seems to have introduced a segfault when starting the launcher.

[Comment 6 James Le Cuirot 2023-05-14 20:02:36 UTC]

Oh, it works for me. Do you see the IWAD selector or nothing at all? If you don't even see that then I'm not sure if that's related because that selector uses FLTK, not wxGTK. Please also update/rebuild wxGTK if you already had it installed.

[Comment 7 Mike Wood 2023-05-14 20:37:31 UTC]

(In reply to James Le Cuirot from comment #6)
> Oh, it works for me. Do you see the IWAD selector or nothing at all? If you
> don't even see that then I'm not sure if that's related because that
> selector uses FLTK, not wxGTK. Please also update/rebuild wxGTK if you
> already had it installed.

I see the iwad selector when running odamex directly. wxGTK is used by the game launcher odalaunch. That is what is crashing. When building against wxGTK 3.0 it runs fine. With wxGTK 3.2 it crashes as soon as it finishes updating the server list. The crash occurs when it attempts to sort the server list. I rebuilt the latest wxGTK 3.2 but it does not resolve the issue. This is a bug upstream.

[Comment 8 James Le Cuirot 2023-05-14 22:17:20 UTC]

Oh heh, I've never tried odalaunch before. I've only ever started it in single player. I did wonder where wxGTK came into it! So yes, I can reproduce the crash now, and I've reverted the ebuild back to 3.0.