Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906156 - Ban prepstrip and prepallstrip in all EAPIs
Summary: Ban prepstrip and prepallstrip in all EAPIs
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on: 905355 916031
Blocks: 906128
  Show dependency tree
 
Reported: 2023-05-11 17:27 UTC by Ulrich Müller
Modified: 2023-10-25 05:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2023-05-11 17:27:15 UTC
Commands starting with the string "prep" are "reserved for package manager use and may not be used or relied upon by ebuilds" (see PMS). This applies to *all* EAPIs, not just EAPI 7 and later.

The last ebuild using prepstrip or prepallstrip was removed from the Gentoo repo on 2019-04-14.
Comment 1 Ulrich Müller gentoo-dev 2023-05-11 17:29:16 UTC
This would also allow considerable code simplification in bin/estrip.
Comment 2 Larry the Git Cow gentoo-dev 2023-05-11 20:19:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=63d6f2e8985de480c21a5c2f09bba1547c7de6b8

commit 63d6f2e8985de480c21a5c2f09bba1547c7de6b8
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-05-11 17:30:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-11 20:15:47 +0000

    prep{,all}strip: Deprecate in all EAPIs
    
    Calling these commands from ebuilds was never allowed.
    Last usage was removed from Gentoo repository on 2019-04-14.
    
    Bug: https://bugs.gentoo.org/906156
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/ebuild-helpers/prepallstrip | 4 +++-
 bin/ebuild-helpers/prepstrip    | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-11 20:21:17 UTC
(In reply to Ulrich Müller from comment #1)
> This would also allow considerable code simplification in bin/estrip.

Look forward to it ;)
Comment 4 Larry the Git Cow gentoo-dev 2023-06-01 01:23:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08be91eebdbff0de0e033efe30c633219a9859ca

commit 08be91eebdbff0de0e033efe30c633219a9859ca
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-06-01 01:22:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-06-01 01:23:18 +0000

    sys-apps/portage: add 3.0.48
    
    Closes: https://bugs.gentoo.org/722270
    Closes: https://bugs.gentoo.org/879687
    Closes: https://bugs.gentoo.org/898232
    Closes: https://bugs.gentoo.org/898366
    Closes: https://bugs.gentoo.org/905355
    Closes: https://bugs.gentoo.org/905358
    Closes: https://bugs.gentoo.org/905868
    Closes: https://bugs.gentoo.org/906129
    Closes: https://bugs.gentoo.org/906156
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.48.ebuild | 296 +++++++++++++++++++++++++++++++++
 2 files changed, 297 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2023-10-21 19:23:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=dafad634cc4d46b6d7b45ec1535044f281916ef4

commit dafad634cc4d46b6d7b45ec1535044f281916ef4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-05-12 17:33:47 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-10-21 08:01:25 +0000

    prep{,all}strip: Ban in ebuild scope
    
    Closes: https://bugs.gentoo.org/906156
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 bin/ebuild-helpers/prepallstrip | 13 ++-----------
 bin/ebuild-helpers/prepstrip    |  9 ++-------
 bin/estrip                      |  4 +---
 3 files changed, 5 insertions(+), 21 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-10-25 05:49:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b9128b401def05cac46f9e6d66048e5a0d888b8

commit 2b9128b401def05cac46f9e6d66048e5a0d888b8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-25 05:48:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-25 05:48:40 +0000

    sys-apps/portage: add 3.0.54
    
    Closes: https://bugs.gentoo.org/905869
    Closes: https://bugs.gentoo.org/915551
    Closes: https://bugs.gentoo.org/915896
    Closes: https://bugs.gentoo.org/916106
    Closes: https://bugs.gentoo.org/916108
    Closes: https://bugs.gentoo.org/916112
    Closes: https://bugs.gentoo.org/916116
    Closes: https://bugs.gentoo.org/916139
    Closes: https://bugs.gentoo.org/916141
    Closes: https://bugs.gentoo.org/916142
    Closes: https://bugs.gentoo.org/916149
    Closes: https://bugs.gentoo.org/916182
    Closes: https://bugs.gentoo.org/916231
    Closes: https://bugs.gentoo.org/916235
    Closes: https://bugs.gentoo.org/916240
    Closes: https://bugs.gentoo.org/916242
    Closes: https://bugs.gentoo.org/916245
    Closes: https://bugs.gentoo.org/916248
    Closes: https://bugs.gentoo.org/899898
    Closes: https://bugs.gentoo.org/906129
    Closes: https://bugs.gentoo.org/906156
    Closes: https://bugs.gentoo.org/916031
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.54.ebuild | 238 +++++++++++++++++++++++++++++++++
 2 files changed, 239 insertions(+)