Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906100 - games-simulation/openrct2: add ~ppc64 keyword
Summary: games-simulation/openrct2: add ~ppc64 keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: PPC64 Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: CC-ARCHES, KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2023-05-10 23:34 UTC by Piotr Kubaj
Modified: 2024-01-02 15:22 UTC (History)
1 user (show)

See Also:
Package list:
games-simulation/openrct2 ~ppc64
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj 2023-05-10 23:34:52 UTC
Builds fine on ppc64le, but it's known that build breaks on big-endian.

Reproducible: Always
Comment 1 Conrad Kostecki gentoo-dev 2023-07-28 07:35:14 UTC
ping
Comment 2 matoro archtester 2023-12-10 03:30:34 UTC
Fails to compile test suite here?

FAILED: test/tests/CMakeFiles/OpenRCT2Tests.dir/BitSetTests.cpp.o                                                                                                                
/usr/bin/powerpc64le-unknown-linux-gnu-g++ -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DOPENGL_NO_LINK -D__WARN_SUGGEST_FINAL_METHODS__ -D__WARN_SUGGEST_FINAL_TYPES__ -I/var/tmp/portage
/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/libopenrct2 -I/var/tmp/portage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/test/tests/../../src -isystem /var/tmp/po
rtage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/src/openrct2/../thirdparty -isystem /usr/include/libpng16 -isystem /usr/include/freetype2  -O2 -pipe -mcpu=power9 -mtun
e=power9 -fstrict-overflow -fstrict-aliasing  -Wundef -Wmissing-declarations -Winit-self -Wall -Wextra -Wshadow -Wno-unknown-pragmas -Wno-missing-braces -Wno-comment -Wnonnull -
Wno-unused-parameter -Wno-attributes -DDEBUG=0 -std=gnu++17 -fPIE -DUSE_MMAP -MD -MT test/tests/CMakeFiles/OpenRCT2Tests.dir/BitSetTests.cpp.o -MF test/tests/CMakeFiles/OpenRCT2
Tests.dir/BitSetTests.cpp.o.d -o test/tests/CMakeFiles/OpenRCT2Tests.dir/BitSetTests.cpp.o -c /var/tmp/portage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/test/tests/Bit
SetTests.cpp
/var/tmp/portage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/test/tests/BitSetTests.cpp: In member function ‘virtual void BitTest_test_big_Test::TestBody()’:
/var/tmp/portage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/test/tests/BitSetTests.cpp:101:24: error: static assertion failed
  101 |     static_assert(std::is_same_v<decltype(bits)::BlockType, uint32_t>);
      |                   ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/games-simulation/openrct2-0.4.6/work/OpenRCT2-0.4.6/test/tests/BitSetTests.cpp:102:38: error: static assertion failed
  102 |     static_assert(bits.data().size() == 8);
      |                   ~~~~~~~~~~~~~~~~~~~^~~~
Comment 3 matoro archtester 2023-12-21 02:57:43 UTC
This should be the fix https://github.com/OpenRCT2/OpenRCT2/pull/19462
Comment 4 matoro archtester 2023-12-21 18:19:46 UTC
Not actually correct, I identified the problem and opened https://github.com/OpenRCT2/OpenRCT2/pull/21103 upstream
Comment 5 Conrad Kostecki gentoo-dev 2024-01-01 18:49:51 UTC
@matoro: Thank you for your help. I have now commited 0.4.7 to tree, which should fixed this. Could you retry again?
Comment 6 matoro archtester 2024-01-01 20:32:38 UTC
(In reply to Conrad Kostecki from comment #5)
> @matoro: Thank you for your help. I have now commited 0.4.7 to tree, which
> should fixed this. Could you retry again?

Works perfect, I've pushed keywords up to my branch and they should be in shortly, thanks!
Comment 7 Larry the Git Cow gentoo-dev 2024-01-02 07:38:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c89cf789507f503f215b11fe5de78cdc355b38c2

commit c89cf789507f503f215b11fe5de78cdc355b38c2
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2024-01-01 20:31:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-02 07:37:21 +0000

    profiles/features/big-endian: mask games-simulation/openrct2
    
    Bug: https://bugs.gentoo.org/906100
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/features/big-endian/package.mask | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 8 matoro archtester 2024-01-02 15:22:51 UTC
ppc64 done

all arches done