Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906045 - dev-lang/spidermonkey: enables debuggging symbols by default
Summary: dev-lang/spidermonkey: enables debuggging symbols by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-09 21:18 UTC by Sam James
Modified: 2023-05-11 07:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-09 21:18:23 UTC
Ionen pointed out that spidermonkey seems to pass -gdwarf-4 by default unless --disable-debug-symbols is passed in EXTRA_ECONF.

Looking around, it seems Alpine also passes --disable-debug-symbols as well.

We should probably then pass --disable-debug-symbols to reduce the build time a bit and disk space requirements. I imagine FF + TB needs the same?
Comment 1 Ionen Wolkens gentoo-dev 2023-05-09 21:41:15 UTC
(In reply to Sam James from comment #0)
> I imagine FF + TB needs the same?
Seems there's already some handling for this over there, but missing for spidermonkey.

        if is-flag '-g*' ; then
            if use clang ; then
                mozconfig_add_options_ac 'from CFLAGS' --enable-debug-symbols=$(get-flag '-g*')
            else
                mozconfig_add_options_ac 'from CFLAGS' --enable-debug-symbols
            fi
        else
            mozconfig_add_options_ac 'Gentoo default' --disable-debug-symbols
        fi
Comment 2 Larry the Git Cow gentoo-dev 2023-05-10 12:14:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6aad8625f0579570a07e4d437557ca7c7e842f07

commit 6aad8625f0579570a07e4d437557ca7c7e842f07
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-05-10 12:14:25 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-05-10 12:14:51 +0000

    dev-lang/spidermonkey: add 102.11.0
    
    Closes: https://bugs.gentoo.org/906045
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-lang/spidermonkey/Manifest                     |   1 +
 .../files/spidermonkey-102-known-test-failures.txt |   5 +
 dev-lang/spidermonkey/spidermonkey-102.11.0.ebuild | 413 +++++++++++++++++++++
 3 files changed, 419 insertions(+)
Comment 3 Ionen Wolkens gentoo-dev 2023-05-10 14:42:13 UTC
fwiw, these could probably be reduced now if USE=-debug:

    if use test ; then
        CHECKREQS_DISK_BUILD="7000M"
    else
        CHECKREQS_DISK_BUILD="6000M"
    fi

I only tried with USE="jit -*" (not checked clang/lto/tests) but the gap from the current requirement is rather big:

 * Final size of build directory: 3314324 KiB ( 3.1 GiB)
 * Final size of installed tree:    41696 KiB (40.7 MiB)

With USE=debug it still seem about right, albeit I did run out of space last time in stable despite 6GB free (maybe it's a bit borderline):

 * Final size of build directory: 6206668 KiB (  5.9 GiB)
 * Final size of installed tree:   897848 KiB (876.8 MiB)
Comment 4 Joonas Niilola gentoo-dev 2023-05-10 18:35:24 UTC
# grep -r "Final size of build directory" /var/tmp/portage/vbslogs/build/*
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182439.log: * Final size of build directory: 3459448 KiB ( 3.2 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182029.log: * Final size of build directory: 3443684 KiB ( 3.2 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182926.log: * Final size of build directory: 3663116 KiB ( 3.4 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-183133.log: * Final size of build directory: 3465816 KiB ( 3.3 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182310.log: * Final size of build directory: 3458768 KiB ( 3.2 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182154.log: * Final size of build directory: 3440112 KiB ( 3.2 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-120907.log: * Final size of build directory: 3550248 KiB ( 3.3 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182600.log: * Final size of build directory: 3617108 KiB ( 3.4 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-182759.log: * Final size of build directory: 3439456 KiB ( 3.2 GiB)
/var/tmp/portage/vbslogs/build/dev-lang/spidermonkey-102.11.0:20230510-120740.log: * Final size of build directory: 3458764 KiB ( 3.2 GiB)


3,4 GB is:
* USE:        abi_x86_64 amd64 elibc_glibc kernel_linux lto userland_GNU

guess adjusting makes sense. Funny earlier today when I was testing firefox-esr I was thinking I haven't checked the final size of build directory for _firefox_ in a while now.
Comment 5 Larry the Git Cow gentoo-dev 2023-05-11 07:01:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf78017747a257d3a64325cf691df3123636edba

commit bf78017747a257d3a64325cf691df3123636edba
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-05-11 05:46:26 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-05-11 07:01:37 +0000

    dev-lang/spidermonkey: reduce disk space requirement for 102.11.0
    
     - after disabling debugging symbols from the build.
    
    Bug: https://bugs.gentoo.org/906045
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-lang/spidermonkey/spidermonkey-102.11.0.ebuild | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)