Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905985 - net-libs/rpcsvc-proto-1.4.3-r1 - musl-1.2.4 LFS64 change - struct stat64 buf;
Summary: net-libs/rpcsvc-proto-1.4.3-r1 - musl-1.2.4 LFS64 change - struct stat64 buf;
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: musl-1.2.4
  Show dependency tree
 
Reported: 2023-05-09 00:42 UTC by immolo
Modified: 2023-05-10 19:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (rpcsvc-proto.log,7.27 KB, text/plain)
2023-05-09 00:42 UTC, immolo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description immolo 2023-05-09 00:42:02 UTC
Created attachment 861350 [details]
build.log

Compiling net-libs/rpcsvc-proto suffers from the LFS64 change in musl since 1.2.4

Steps to reproduce from stage3:

1. set ACCEPT_KEYWORDS="~amd64"
2. emerge -va sys-libs/musl
3. emerge -va net-libs/rpcsvc-proto

Error:

rpc_main.c: In function 'find_cpp':
rpc_main.c:340:17: error: storage size of 'buf' isn't known
  340 |   struct stat64 buf;
      |                 ^~~
rpc_main.c:342:7: warning: implicit declaration of function 'stat64'; did you mean 'stat'? [-Wimplicit-function-declaration]
  342 |   if (stat64 (CPP, &buf) == 0)
      |       ^~~~~~
      |       stat
rpc_main.c: In function 'checkfiles':
rpc_main.c:1128:17: error: storage size of 'buf' isn't known
 1128 |   struct stat64 buf;
Comment 1 immolo 2023-05-09 00:43:24 UTC
MrBull ~ # emerge --info
Portage 3.0.47 (python 3.11.3-final-0, default/linux/amd64/17.0/musl, gcc-13, musl-1.2.4, 6.2.14-gentoo-dist x86_64)
=================================================================
System uname: Linux-6.2.14-gentoo-dist-x86_64-Intel-R-_Core-TM-_i5-5300U_CPU_@_2.30GHz-with-libc
KiB Mem:     7997412 total,   1084532 free
KiB Swap:    4194300 total,   2475516 free
Timestamp of repository gentoo: Mon, 08 May 2023 20:00:01 +0000
Head commit of repository gentoo: e2df99959623331aa3710cc48992e783cb9f5985
Timestamp of repository musl: Sun, 07 May 2023 16:18:01 +0000
Head commit of repository musl: bfd9e7a95cf707144d645afeb33c2cd4602ae084

sh bash 5.2_p15-r2
ld GNU ld (Gentoo 2.40 p4) 2.40.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r2::gentoo
dev-lang/perl:             5.36.1-r1::gentoo
dev-lang/python:           3.10.11::gentoo, 3.11.3::gentoo
dev-lang/rust:             1.69.0-r1::gentoo
dev-util/cmake:            3.26.3::gentoo
dev-util/meson:            1.1.0::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/openrc:           0.47.1::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-devel/autoconf:        2.13-r8::gentoo, 2.71-r6::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.40-r4::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r1::gentoo, 16.0.3::gentoo
sys-devel/gcc:             13.1.0-r1::gentoo
sys-devel/gcc-config:      2.10::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             15.0.7::gentoo, 16.0.2::gentoo
sys-devel/llvm:            15.0.7::gentoo, 16.0.3::gentoo
sys-devel/make:            4.4.1::gentoo
sys-kernel/linux-headers:  6.3::gentoo (virtual/os-headers)
sys-libs/musl:             1.2.4::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    volatile: False
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts:
    sync-rsync-verify-jobs: 1

musl
    location: /var/db/repos/musl
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/musl.git
    masters: gentoo
    volatile: False

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-gentoo-linux-musl"
CFLAGS="-O2 -pipe -march=native "
CHOST="x86_64-gentoo-linux-musl"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native "
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native "
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native "
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="charset.alias /usr/share/locale/locale.alias"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X acl alsa amd64 bzip2 cli crypt dri elogind font-config fortran gif iconv ipv6 jpeg libglvnd libtirpc logrotate lto ncurses nls nptl openmp pam pcre png pulseaudio readline seccomp split-usr ssl svg test-rust tkip truetype unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sse3 sse4_1 sse4_2 ssse3" ELIBC="musl" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="synaptics evdev libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_USER_TARGETS="aarch64" RUBY_TARGETS="ruby30" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 2 Nikita Romaniuk 2023-05-09 02:04:39 UTC
They fixed this some time ago in the master branch, but did not bump the version.
What do we do in this situation? Patching the downloaded release with their commit?

https://github.com/thkukuk/rpcsvc-proto/commit/28d1adf9209926bc822b338d97c4c99de057a23b
Comment 3 Agostino Sarubbo gentoo-dev 2023-05-09 06:12:08 UTC
tinderbox_musl has reproduced this issue with version 1.4.3-r1 - Updating summary.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-09 12:51:22 UTC
(In reply to Nikita Romanyuk from comment #2)
> They fixed this some time ago in the master branch, but did not bump the
> version.
> What do we do in this situation? Patching the downloaded release with their
> commit?
> 
> https://github.com/thkukuk/rpcsvc-proto/commit/
> 28d1adf9209926bc822b338d97c4c99de057a23b

Yeah, we'll backport it.
Comment 5 Larry the Git Cow gentoo-dev 2023-05-09 20:49:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e5eb81267aa903a742d9e63e5fee668a0b0cbdb

commit 9e5eb81267aa903a742d9e63e5fee668a0b0cbdb
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2023-05-09 20:04:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-09 20:49:09 +0000

    net-libs/rpcsvc-proto: LFS64 shim fix
    
    The autoconf macro AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS=64
    where necessary to ensure that off_t and all interfaces using off_t
    are 64bit, even on 32bit systems.
    
    Replace stat64 by equivalent stat struct/func.
    
    Closes: https://bugs.gentoo.org/905985
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/30960
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/rpcsvc-proto-1.4.3-lfs64.patch           | 70 ++++++++++++++++++++++
 net-libs/rpcsvc-proto/rpcsvc-proto-1.4.3-r2.ebuild | 50 ++++++++++++++++
 2 files changed, 120 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2023-05-10 19:29:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=146d7abc157943375069faef5ebbee1b634241ce

commit 146d7abc157943375069faef5ebbee1b634241ce
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-10 19:29:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-10 19:29:26 +0000

    net-libs/rpcsvc-proto: add 1.4.4
    
    Bug: https://bugs.gentoo.org/905985
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/rpcsvc-proto/Manifest                  |  1 +
 net-libs/rpcsvc-proto/rpcsvc-proto-1.4.4.ebuild | 44 +++++++++++++++++++++++++
 2 files changed, 45 insertions(+)