Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905901 - app-text/stardict: Last Rites
Summary: app-text/stardict: Last Rites
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 905957
  Show dependency tree
 
Reported: 2023-05-07 20:39 UTC by Matt Turner
Modified: 2023-06-11 22:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2023-05-07 20:39:52 UTC
stardict seems basically unmaintained both in upstream and Gentoo. (See https://bugs.gentoo.org/776394 for example)

It's still on EAPI=6, depends on a bunch of deprecated packages, has no reverse dependencies, etc; and it's been this way for many years.

I think it's time to give it last rites. This package is maybe overlay-quality, but definitely not up to scratch for ::gentoo.

Removing it will enable further clean ups (e.g. it is one of very few remaining consumers of app-text/gnome-doc-utils and app-text/enchant and is *the* last consumer of gnome-extra/gucharmap:0).
Comment 1 David Seifert gentoo-dev 2023-05-07 21:10:11 UTC
In https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6539ff8057a3f04764016c9c023bff60ddb265ed, Bircoph removed the last-rite for most of stardict and its associated dictionaries.

The last time Bircoph touched stardict was over 4.5 years ago:
https://gitweb.gentoo.org/repo/gentoo.git/log/?qt=grep&q=app-text%2Fstardict

In https://bugs.gentoo.org/776394, Bircoph asks for a "2 week timeout" (that doesn't apply to stablereqs), and then never replied again.

In https://bugs.gentoo.org/735670, it's obvious the package has been broken with Clang for ages with a seemingly simple fix.

All in all, I think it's fair to say that Bircoph doesn't actually "maintain" this package in practice.
Comment 2 Larry the Git Cow gentoo-dev 2023-05-11 22:26:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a0a0ebb526cce917c052f540037ba0519a20c42

commit 7a0a0ebb526cce917c052f540037ba0519a20c42
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-07 20:40:51 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-11 22:26:01 +0000

    stardict.eclass: Mark @DEAD
    
    Bug: https://bugs.gentoo.org/905901
    Closes: https://github.com/gentoo/gentoo/pull/30923
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 eclass/stardict.eclass | 1 +
 1 file changed, 1 insertion(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ce7873c1528648becb1e02235240fc0938a2ed35

commit ce7873c1528648becb1e02235240fc0938a2ed35
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-07 20:41:38 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-11 22:25:59 +0000

    profiles: Mask app-text/sdcv for removal
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51b02ff345f06adb9f4c96e538e27c4c5f7864c3

commit 51b02ff345f06adb9f4c96e538e27c4c5f7864c3
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-07 20:40:28 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-11 22:25:20 +0000

    profiles: Mask app-dicts/stardict-* for removal
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a474ccea40d8cd166d6b973531290c985bc3922

commit 7a474ccea40d8cd166d6b973531290c985bc3922
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-07 20:33:19 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-11 22:24:32 +0000

    profiles: Mask app-text/stardict for removal
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 3 Roman 'gryf' Dobosz 2023-05-15 10:08:18 UTC
> stardict seems basically unmaintained both in upstream and Gentoo.

That's not true. I can see new releases[1] even this year for 3.x branch. I don't understand why removing such utility, while there are no alternatives?

[1] https://sourceforge.net/projects/stardict-4/files/
Comment 4 Sergey 'L29Ah' Alirzaev 2023-05-15 14:49:44 UTC
The last sdcv release was under a month ago. Why is it masked?
Comment 5 Matt Turner gentoo-dev 2023-05-15 15:04:53 UTC
(In reply to Roman 'gryf' Dobosz from comment #3)
> > stardict seems basically unmaintained both in upstream and Gentoo.
> 
> That's not true. I can see new releases[1] even this year for 3.x branch. I
> don't understand why removing such utility, while there are no alternatives?
> 
> [1] https://sourceforge.net/projects/stardict-4/files/

As I said in the initial comment:

> It's still on EAPI=6, depends on a bunch of deprecated packages, has no reverse dependencies, etc; and it's been this way for many years.

(In reply to Sergey 'L29Ah' Alirzaev from comment #4)
> The last sdcv release was under a month ago. Why is it masked?

I was under the impression that it is not usable without stardict, but I may be wrong. I don't mind keeping it if it's still useful; it doesn't depend on a pile of deprecated packages.
Comment 6 s4bip4+c8yqo8n7vhcm8 2023-05-16 18:20:19 UTC
sdcv is a console-based stardict alternative and usable without stardict, so please unmask it. It would also be nice if you could keep app-dicts/stardict-* as they are still useful to sdcv users.
Comment 7 cJ 2023-05-16 20:58:24 UTC
sdcv has minimal dependencies, it is small and maintained, and I also don't think the removal of the stardict GUI should affect it.
Comment 8 Matt Turner gentoo-dev 2023-05-16 23:46:32 UTC
Thanks for the info! I don't see any problem keeping sdvc. The only thing that gives me pause is that its maintainer is barely around [1] and he doesn't actually maintain any of the dictionaries themselves. They're all either maintainer-needed or assigned cjk@, which is effectively the same:


> gentoo % find -path './app-dicts/stardict*/metadata.xml' -exec grep maintainer-needed {} +
> ./app-dicts/stardict-freedict-tur-eng/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-lat/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-deu/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-dictd-devils/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-tur-deu/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-fra/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-mova-smiley/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-swe/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-quick-ru-en/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-xdict-zh-en-gb/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-rus/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-spa/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-ita/metadata.xml:	<!-- maintainer-needed -->
> ./app-dicts/stardict-freedict-eng-tur/metadata.xml:	<!-- maintainer-needed -->

> gentoo % find -path './app-dicts/stardict*/metadata.xml' -exec grep @ {} +                
> ./app-dicts/stardict-cedict-zh-en-big5/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-xdict-en-zh-big5/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-cedict-zh-en-gb/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-jmdict-ja-en/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-jmdict-en-ja/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-xdict-en-zh-gb/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-cdict-en-zh-big5/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-langdao-en-zh-gb/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-langdao-zh-en-gb/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-xdict-zh-en-big5/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-oxford-en-zh-gb/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-quick-jpn-eng/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-quick-eng-jpn/metadata.xml:		<email>cjk@gentoo.org</email>
> ./app-dicts/stardict-cdict-en-zh-gb/metadata.xml:		<email>cjk@gentoo.org</email>

Looking at the upstream HOMEPAGE, I don't see new releases, so maybe these really don't require much maintenance.

Thoughts?


[1] https://gitweb.gentoo.org/repo/gentoo.git/log/?qt=author&q=bircoph%40gentoo.org
Comment 9 Larry the Git Cow gentoo-dev 2023-05-17 00:12:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ecc20a56320ccf1a7550e8cccf76a6dc157dec5

commit 4ecc20a56320ccf1a7550e8cccf76a6dc157dec5
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-16 23:50:12 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-17 00:11:50 +0000

    Revert "profiles: Mask app-text/sdcv for removal"
    
    This reverts commit ce7873c1528648becb1e02235240fc0938a2ed35.
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 6 ------
 1 file changed, 6 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ddbba72cb878d66fcb614a664beeb0976eea153

commit 3ddbba72cb878d66fcb614a664beeb0976eea153
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-16 23:49:47 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-17 00:11:49 +0000

    Revert "stardict.eclass: Mark @DEAD"
    
    This reverts commit 7a0a0ebb526cce917c052f540037ba0519a20c42.
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 eclass/stardict.eclass | 1 -
 1 file changed, 1 deletion(-)
Comment 10 Matt Turner gentoo-dev 2023-05-17 13:13:30 UTC
I've unmasked sdcv and stardict.eclass. As soon as bug 906587 is handled I'll unmask the dictionaries (the dictionaries depend on stardict OR sdcv and most architectures only had keywords for stardict and not sdcv, so we need to keyword sdcv).
Comment 11 Larry the Git Cow gentoo-dev 2023-05-19 21:02:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efbf813301fcc02a037a1d9fd7e99e81fe33524e

commit efbf813301fcc02a037a1d9fd7e99e81fe33524e
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-19 21:01:32 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-19 21:01:56 +0000

    Revert "profiles: Mask app-dicts/stardict-* for removal"
    
    This reverts commit 51b02ff345f06adb9f4c96e538e27c4c5f7864c3.
    
    Bug: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask | 32 --------------------------------
 1 file changed, 32 deletions(-)
Comment 12 Larry the Git Cow gentoo-dev 2023-06-11 22:30:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb140e2e6bf42b5ca7f88f53afd2806c252a6ac4

commit cb140e2e6bf42b5ca7f88f53afd2806c252a6ac4
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-06-11 22:25:31 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-06-11 22:30:22 +0000

    app-text/stardict: Delete
    
    Bug: https://bugs.gentoo.org/676920
    Bug: https://bugs.gentoo.org/710450
    Bug: https://bugs.gentoo.org/733006
    Bug: https://bugs.gentoo.org/735670
    Closes: https://bugs.gentoo.org/905901
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 app-text/stardict/Manifest                         |   4 -
 .../files/stardict-4.0.0_pre20160518-tabfile.patch |  38 ----
 app-text/stardict/metadata.xml                     |  39 ----
 app-text/stardict/stardict-3.0.6-r5.ebuild         | 189 -------------------
 .../stardict/stardict-4.0.0_pre20170304-r2.ebuild  | 207 ---------------------
 profiles/package.mask                              |  10 -
 6 files changed, 487 deletions(-)