Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905872 - dev-lang/yasm-1.3.0-r1 riscv keyword
Summary: dev-lang/yasm-1.3.0-r1 riscv keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-07 12:22 UTC by Andrew Cameron
Modified: 2023-12-12 18:33 UTC (History)
0 users

See Also:
Package list:
>=dev-lang/yasm-1.3.0-r1 ~riscv
Runtime testing required: ---
nattka: sanity-check+


Attachments
Log of the build and test results (yasm-1.3.0-r1.log,49.70 KB, text/x-log)
2023-05-07 12:23 UTC, Andrew Cameron
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cameron 2023-05-07 12:22:06 UTC
Please add the riscv keyword to dev-lang/yasm-1.3.0-r1
It emerges and runs successfully on my VisionFive 2 Riscv SBC

Reproducible: Always
Comment 1 Andrew Cameron 2023-05-07 12:23:14 UTC
Created attachment 861269 [details]
Log of the build and test results
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-09 13:10:18 UTC
>An assembler for x86 and x86_64 instruction sets

I don't think this makes sense, does it?
Comment 3 Andrew Cameron 2023-05-09 16:44:22 UTC
1) It is a Dependency for Phoronix-test-suite as they use it in their benchmarks.
2) It can also be used on other architectures for validating X86 or X86_64 assembler code to see if it compiles.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-09 17:01:34 UTC
(In reply to Andrew Cameron from comment #3)
> 1) It is a Dependency for Phoronix-test-suite as they use it in their
> benchmarks.
> 2) It can also be used on other architectures for validating X86 or X86_64
> assembler code to see if it compiles.

Does anyone actually do that? It's only keyworded on arm64 + ppc64 outside of amd64/x86 and even those feel like a mistake.
Comment 5 Andrew Cameron 2023-05-09 19:16:49 UTC
As I said  https://www.phoronix-test-suite.com/ wants it installed as they use it in their benchmarks. It is one of the install-dependencies for their tests.
Without it the tests I was doing would not run.

See https://openbenchmarking.org/result/2303193-NE-2303170NE99 for one of the Benchmarks I ran.
Comment 6 SpanKY gentoo-dev 2023-12-12 18:23:08 UTC
sounds like it can be used to cross-compile code just fine.  i don't see an issue with keywording this anywhere.
Comment 7 Larry the Git Cow gentoo-dev 2023-12-12 18:32:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02d88c6e61ff9fab0fdf897ccddf4bdaa6f094e9

commit 02d88c6e61ff9fab0fdf897ccddf4bdaa6f094e9
Author:     Mike Frysinger <vapier@gentoo.org>
AuthorDate: 2023-12-12 18:32:11 +0000
Commit:     Mike Frysinger <vapier@gentoo.org>
CommitDate: 2023-12-12 18:32:11 +0000

    dev-lang/yasm: add riscv keyword #905872
    
    Fixes: https://bugs.gentoo.org/905872
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Mike Frysinger <vapier@chromium.org>

 dev-lang/yasm/yasm-1.3.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-12 18:33:42 UTC
Sure. The reason to be skeptical was if it was being pulled in unconditionally by another packsge when it wasn't being used anyway.