Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905841 - net-p2p/deluge-2.1.1-r4: Fix consoleui return error
Summary: net-p2p/deluge-2.1.1-r4: Fix consoleui return error
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paolo Pedroni
URL:
Whiteboard:
Keywords: PATCH
Depends on: 906745
Blocks:
  Show dependency tree
 
Reported: 2023-05-06 18:47 UTC by Scott Jones
Modified: 2023-05-20 06:46 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
deluge-2.1.1-consoleui-deferred_fix.patch (deluge-2.1.1-consoleui-deferred_fix.patch,412 bytes, patch)
2023-05-06 18:47 UTC, Scott Jones
Details | Diff
deluge-2.1.1-r4.patch (deluge-2.1.1-r4.patch,424 bytes, patch)
2023-05-06 18:48 UTC, Scott Jones
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Jones 2023-05-06 18:47:21 UTC
Created attachment 861244 [details, diff]
deluge-2.1.1-consoleui-deferred_fix.patch

This deluge patch fixes the ConsoleUI error that appears harmless, but will cause console commands to always return 1, which breaks scripts.  It looks like this was introduced in 2.1.0 and is supposed to be fixed in 2.1.2.  The error will look like this:
<Deferred at 0x7f9d47ba1a90 current result: None>

I've included an ebuild patch too, which will only apply the deluge patch if the 'console' USE flag is enabled.  I've been running this for about a week without issues.

Paolo, you can include the deluge patch with the other patches instead, I just thought this was cleaner... but I appreciate you maintaining deluge and leave that decision up to you!

Bug: https://dev.deluge-torrent.org/ticket/3582
git: https://github.com/deluge-torrent/deluge/pull/408
Comment 1 Scott Jones 2023-05-06 18:48:06 UTC
Created attachment 861245 [details, diff]
deluge-2.1.1-r4.patch
Comment 2 Larry the Git Cow gentoo-dev 2023-05-19 09:10:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1e57173f56c1ab6951a27291322b35273983a620

commit 1e57173f56c1ab6951a27291322b35273983a620
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2023-05-19 09:09:51 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-05-19 09:10:48 +0000

    net-p2p/deluge: Fix return error
    
    Thanks-to: Scott Jones
    Closes: https://bugs.gentoo.org/905841
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-p2p/deluge/deluge-2.1.1-r4.ebuild              | 179 +++++++++++++++++++++
 .../files/deluge-2.1.1-consoleui-deferred.patch    |  13 ++
 2 files changed, 192 insertions(+)