Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905695 - app-accessibility/brltty-6.5-r1 fails with python-3.11
Summary: app-accessibility/brltty-6.5-r1 fails with python-3.11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Accessibility Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-05-04 09:32 UTC by crabbed halo ablution
Modified: 2023-11-29 04:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-accessibility:brltty-6.5-r1:20230504-092608.log (app-accessibility:brltty-6.5-r1:20230504-092608.log,186.63 KB, text/plain)
2023-05-04 09:33 UTC, crabbed halo ablution
Details
emerge --info brltty (emergeinfo.txt,9.16 KB, text/plain)
2023-05-04 09:34 UTC, crabbed halo ablution
Details

Note You need to log in before you can comment on or make changes to this bug.
Description crabbed halo ablution 2023-05-04 09:32:42 UTC
Fails to build with error:
"/usr/bin/python3" ./setup.py "${@}"
Traceback (most recent call last):
  File "/var/tmp/portage/app-accessibility/brltty-6.5-r1/work/brltty-6.5/Bindings/Python/./setup.py", line 21, in <module>
    from setuptools import setup, Extension
ModuleNotFoundError: No module named 'setuptools'


Reproducible: Always
Comment 1 crabbed halo ablution 2023-05-04 09:33:47 UTC
Created attachment 861119 [details]
app-accessibility:brltty-6.5-r1:20230504-092608.log
Comment 2 crabbed halo ablution 2023-05-04 09:34:27 UTC
Created attachment 861120 [details]
emerge --info brltty
Comment 3 crabbed halo ablution 2023-05-07 19:30:19 UTC
I think I found the problem. Even though brltty was emerged with PYTHON_TARGETS="python3_11 -python3_10", it apparently used the default system interpreter, which at the time was set to python 3.10. Some hack is needed so it calls the right python interpreter (python3.11) and not the global one (python).
Comment 4 Larry the Git Cow gentoo-dev 2023-10-10 05:44:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81a72b436df07cca118495976262e92792b12d7c

commit 81a72b436df07cca118495976262e92792b12d7c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-10 05:41:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-10 05:44:30 +0000

    app-accessibility/brltty: add 6.6
    
    Closes: https://bugs.gentoo.org/905695
    Closes: https://bugs.gentoo.org/911229
    Closes: https://bugs.gentoo.org/913019
    Signed-off-by: Sam James <sam@gentoo.org>

 app-accessibility/brltty/Manifest                  |   1 +
 app-accessibility/brltty/brltty-6.6.ebuild         | 224 +++++++++++++++++++++
 .../brltty/files/brltty-6.6-cython3.patch          |  41 ++++
 3 files changed, 266 insertions(+)
Comment 5 Eli Schwartz 2023-11-28 19:20:23 UTC
Still doesn't work. PR incoming...
Comment 6 Larry the Git Cow gentoo-dev 2023-11-29 04:10:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5552bb02bcdaf88004f485ebb16e1263a5edfe2

commit d5552bb02bcdaf88004f485ebb16e1263a5edfe2
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2023-11-28 19:13:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-29 04:09:00 +0000

    app-accessibility/brltty: add missing build dependency on setuptools
    
    This does not use distutils-r1, so we need to manually add this
    dependency in order for the upstream Makefile to go drive a non-pep517
    build all by itself.
    
    Closes: https://bugs.gentoo.org/905695
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-accessibility/brltty/brltty-6.6-r1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02f8a1e85e899ded8c1b150232eb780a3adb49ae

commit 02f8a1e85e899ded8c1b150232eb780a3adb49ae
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2023-11-28 19:07:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-11-29 04:09:00 +0000

    app-accessibility/brltty: fix building python bindings too many times
    
    Although --disable-python-bindings was used in the main build, to defer
    building them for the python_foreach, the original use_enable was never
    removed. So the python bindings if enabled at all, would always build
    twice or more: once for python3, and once for each USE-enabled impl. The
    python3 version might not actually work due to dependencies, so the
    build might fail. If it did work by *coincidence*, it would be for
    whatever the default python-exec is, which may not be what is in
    PYTHON_TARGETS.
    
    Bug: https://bugs.gentoo.org/905695
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-accessibility/brltty/{brltty-6.6.ebuild => brltty-6.6-r1.ebuild} | 1 -
 1 file changed, 1 deletion(-)