Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905469 - sci-libs/gklib-5.1.1_p20230327 adds -Werror flag on its own
Summary: sci-libs/gklib-5.1.1_p20230327 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-05-02 14:07 UTC by Agostino Sarubbo
Modified: 2023-05-02 14:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,84.92 KB, text/plain)
2023-05-02 14:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-05-02 14:07:49 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/gklib-5.1.1_p20230327 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-05-02 14:07:51 UTC
Created attachment 861040 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-05-02 14:09:49 UTC
ftr, -O is also overwritten with -O3
Comment 3 Larry the Git Cow gentoo-dev 2023-05-02 14:25:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=55f6641933bde51d14c1a67fe0957b997e122031

commit 55f6641933bde51d14c1a67fe0957b997e122031
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2023-05-02 14:24:55 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2023-05-02 14:25:12 +0000

    sci-libs/gklib: respect user flags
    
    Closes: https://bugs.gentoo.org/905469
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 .../gklib-5.1.1_p20230327-respect-user-flags.patch | 51 ++++++++++++++++++++++
 ...0327.ebuild => gklib-5.1.1_p20230327-r1.ebuild} |  1 +
 2 files changed, 52 insertions(+)