Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905123 - Update games-simulation/unknown-horizons::gamerlay for Python 3.10
Summary: Update games-simulation/unknown-horizons::gamerlay for Python 3.10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vadim A. Misbakh-Soloviov (mva)
URL:
Whiteboard:
Keywords:
Depends on: 905665
Blocks:
  Show dependency tree
 
Reported: 2023-04-26 14:59 UTC by Michał Dec
Modified: 2024-01-16 04:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild of games-strategy/unknown-horizons-2019.1-r1 which uses the patches (unknown-horizons-2019.1-r1.ebuild,1.32 KB, text/plain)
2023-04-26 14:59 UTC, Michał Dec
Details
Corrects distro detection in setup.py (python-3.8.patch,548 bytes, patch)
2023-04-26 15:01 UTC, Michał Dec
Details | Diff
Corrects json decoder calls (jsondecoder.patch,369 bytes, patch)
2023-04-26 15:01 UTC, Michał Dec
Details | Diff
Updates references to Iterable properties (unitmanager.patch,824 bytes, patch)
2023-04-26 15:02 UTC, Michał Dec
Details | Diff
One more call fix (util_preloader.patch,398 bytes, patch)
2023-04-26 15:04 UTC, Michał Dec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Dec 2023-04-26 14:59:23 UTC
Created attachment 860789 [details]
ebuild of games-strategy/unknown-horizons-2019.1-r1 which uses the patches

Currently, the ebuild is only good if we're using Python 3.8 or older. Upstream is not going to help us out, because they have decided to migrate to Godot and discontinue developing the FIFEngine-based version of Unknown Horizons.

Because of this, gamerlay has to either drop this package or patch it so that it can work with newer versions of Python.

Fortunately for any Unknown Horizons fans, I have a patched ebuild and code patches that can get us the latter solution.
Comment 1 Michał Dec 2023-04-26 15:00:03 UTC
Sorry, the patches are actually for Python 3.8 or newer. I made a typo in the OP. Unknown Horizons is originally supported only on Python up to 3.7. More files coming up.
Comment 2 Michał Dec 2023-04-26 15:01:11 UTC
Created attachment 860790 [details, diff]
Corrects distro detection in setup.py
Comment 3 Michał Dec 2023-04-26 15:01:50 UTC
Created attachment 860791 [details, diff]
Corrects json decoder calls
Comment 4 Michał Dec 2023-04-26 15:02:59 UTC
Created attachment 860792 [details, diff]
Updates references to Iterable properties
Comment 5 Michał Dec 2023-04-26 15:04:04 UTC
Created attachment 860793 [details, diff]
One more call fix
Comment 6 Michał Dec 2023-05-03 20:42:20 UTC
Depends on https://bugs.gentoo.org/905665 as well
Comment 7 Larry the Git Cow gentoo-dev 2024-01-16 04:25:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gamerlay.git/commit/?id=4900137dde22ca34250c4de54fb1d2ec3e569170

commit 4900137dde22ca34250c4de54fb1d2ec3e569170
Author:     Vadim Misbakh-Soloviov <mva@gentoo.org>
AuthorDate: 2024-01-16 04:21:43 +0000
Commit:     Vadim Misbakh-Soloviov <mva@gentoo.org>
CommitDate: 2024-01-16 04:24:30 +0000

    games-strategy/unknown-horizons: fix build
    
    Closes: https://bugs.gentoo.org/905123
    Signed-off-by: Vadim Misbakh-Soloviov <mva@gentoo.org>

 .../unknown-horizons/files/json_decoder.patch        |  8 ++++++++
 .../unknown-horizons/files/python-3.8.patch          | 19 +++++++++++++++++++
 .../unknown-horizons/files/unitmanager.patch         | 20 ++++++++++++++++++++
 .../unknown-horizons/files/util_preloader.patch      | 14 ++++++++++++++
 games-strategy/unknown-horizons/metadata.xml         | 14 +++++++-------
 ...19.1.ebuild => unknown-horizons-2019.1-r1.ebuild} | 17 +++++++++++++++--
 6 files changed, 83 insertions(+), 9 deletions(-)