Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905084 - xfce-extra/xfce4-systemload-plugin-1.3.2 does not compile on x86
Summary: xfce-extra/xfce4-systemload-plugin-1.3.2 does not compile on x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal major (vote)
Assignee: XFCE Team
URL: https://salsa.debian.org/xfce-team/go...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-04-25 19:59 UTC by fabalthazar
Modified: 2023-04-27 04:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch proposal (01_Fix-build-failure-due-to-wrong-var-type.patch,363 bytes, patch)
2023-04-25 19:59 UTC, fabalthazar 		Details | Diff
Build error (build_error_log.txt,2.54 KB, text/plain)
2023-04-25 20:00 UTC, fabalthazar 		Details
emerge --info xfce-extra/xfce4-systemload-plugin (emerge--info.txt,6.57 KB, text/plain)
2023-04-25 20:00 UTC, fabalthazar 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fabalthazar 2023-04-25 19:59:07 UTC 
Created attachment 860765 [details, diff]
Patch proposal

xfce4-systemload-plugin-1.3.2 does not compile on x86 architecture but is tagged as stable.
Should x86 arch have stayed testing?

Find attached the log showing the build error.

The bug is known upstream: https://gitlab.xfce.org/panel-plugins/xfce4-systemload-plugin/-/issues/25
And patched by our Debian mates here: https://salsa.debian.org/xfce-team/goodies/xfce4-systemload-plugin/-/blob/dd6f4d01a05e6f9652d98437debb80fc4a8f1c03/debian/patches/01_Fix-build-failure-due-to-wrong-var-type.patch

I have successfully applied the attached patch which could be a start point to make this package stable on x86.
Comment 1 fabalthazar 2023-04-25 20:00:09 UTC 
Created attachment 860767 [details]
Build error
Comment 2 fabalthazar 2023-04-25 20:00:27 UTC 
Created attachment 860768 [details]
emerge --info xfce-extra/xfce4-systemload-plugin
Comment 3 Larry the Git Cow gentoo-dev 2023-04-27 04:17:29 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d8dc57c3570616a47e7599b3e7692788ac81180

commit 7d8dc57c3570616a47e7599b3e7692788ac81180
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-27 04:15:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-27 04:17:18 +0000

    xfce-extra/xfce4-systemload-plugin: fix build on x86
    
    Closes: https://bugs.gentoo.org/905084
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/xfce4-systemload-plugin-1.3.2-x86.patch  | 22 ++++++++
 .../xfce4-systemload-plugin-1.3.2-r1.ebuild        | 60 ++++++++++++++++++++++
 2 files changed, 82 insertions(+)