Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904958 - net-im/zoom-5.14.2.2046: SSO login fails unless token is passed directly to /opt/zoom/ZoomLauncher, ie Gentoo's wrapper script somehow breaks SSO
Summary: net-im/zoom-5.14.2.2046: SSO login fails unless token is passed directly to /...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ulrich Müller
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-04-24 08:00 UTC by Michael Moon
Modified: 2023-04-25 15:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Moon 2023-04-24 08:00:04 UTC
Got a puzzling one here, my organization switched to SSO-only and zoom got stuck in a login loop - app start, request SSO login, open browser, login success, feed token to zoom via zoommtg:// url, zoom either ignores it completely or (if closed in the interim) just asks to log in again as if it can't see the tokens it's being passed.

With some experimentation, I found that bypassing /usr/bin/zoom and telling my browser to use /opt/zoom/ZoomLauncher directly made it behave - however even editing /usr/bin/zoom to invoke ZoomLauncher didn't work despite "$@" and I have no idea why.

Some amount of upstream discussion is in zoom ticket 16978485 although since zoom keeps its tickets private there's not much point providing a direct link here - I'm just giving the reference number in case someone else wants to discuss this issue with zoom support.

Curiously, ZoomLauncher _does_ work if invoked without the LD_LIBRARY_PATH wrapper (I guess it does that by itself now?) - not sure if it did in earlier versions.

I guess I'm proposing that (if testing succeeds for y'all) we get rid of the wrapper and change the ebuild to make_desktop_entry "/opt/zoom/ZoomLauncher %U" instead of the current make_wrapper and make_desktop_entry "zoom %U"; ie:

diff --git a/zoom-5.14.2.2046.ebuild.old b/zoom-5.14.2.2046.ebuild
index 6c6cfdb..9c1c17f 100644
--- a/zoom-5.14.2.2046.ebuild.old
+++ b/zoom-5.14.2.2046.ebuild
@@ -160,9 +160,7 @@ src_install() {
 		fi
 	fi
 
-	make_wrapper zoom /opt/zoom/zoom /opt/zoom \
-		/opt/zoom:/opt/zoom/Qt/lib:/opt/zoom/cef
-	make_desktop_entry "zoom %U" Zoom videoconference-zoom \
+	make_desktop_entry "/opt/zoom/ZoomLauncher %U" Zoom videoconference-zoom \
 		"Network;VideoConference;" \
 		"MimeType=$(printf '%s;' \
 			x-scheme-handler/zoommtg \
Comment 1 Larry the Git Cow gentoo-dev 2023-04-25 04:57:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c80b12101e3f997fcfdb738dcecb3a8174d94fae

commit c80b12101e3f997fcfdb738dcecb3a8174d94fae
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-04-25 04:56:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-04-25 04:56:46 +0000

    profiles: Mask net-im/zoom-5.14.5.2430-r1 for testing
    
    Bug: https://bugs.gentoo.org/904958
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 profiles/package.mask | 4 ++++
 1 file changed, 4 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=474df6681c5a53917a360c675869d6c9bcb5a6d4

commit 474df6681c5a53917a360c675869d6c9bcb5a6d4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-04-25 04:53:03 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-04-25 04:55:24 +0000

    net-im/zoom: Start with upstream launcher instead of wrapper
    
    Bug: https://bugs.gentoo.org/904958
    Suggested-by: Michael Moon  <triffid.hunter@gmail.com>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 net-im/zoom/zoom-5.14.5.2430-r1.ebuild | 191 +++++++++++++++++++++++++++++++++
 1 file changed, 191 insertions(+)
Comment 2 Ulrich Müller gentoo-dev 2023-04-25 04:58:43 UTC
Solved in slightly different way. Please unmask and test r1.
Comment 3 Ulrich Müller gentoo-dev 2023-04-25 05:14:56 UTC
BTW, we had reverted from ZoomLaucher to the shell wrapper because of bug 750437 comment #61. Any chance that you could also test this on a HiDPI screen?
Comment 4 Michael Moon 2023-04-25 05:32:47 UTC
Unfortunately I don't have access to a HiDPI screen, unless 108x107 DPI counts?

Comment 62 in that bug seems to suggest it was a result of the user doing things weirdly and they found a workaround - although it's odd how that bug got derailed from crashes (ostensibly solved by bundled-qt flag) to DPI scaling issues

The -r1 you just posted seems to work fine for me 👍
Comment 5 Ulrich Müller gentoo-dev 2023-04-25 06:49:53 UTC
(In reply to Michael Moon from comment #4)
> Comment 62 in that bug seems to suggest it was a result of the user doing
> things weirdly and they found a workaround - although it's odd how that bug
> got derailed from crashes (ostensibly solved by bundled-qt flag) to DPI
> scaling issues

This sometimes happens (and there it was within the context of the fix for the original issue).

> The -r1 you just posted seems to work fine for me 👍

So let's unmask for wider testing.
Comment 6 Larry the Git Cow gentoo-dev 2023-04-25 06:50:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e18263d8804f85cb3e13ed5b5056e99d73f5b65

commit 7e18263d8804f85cb3e13ed5b5056e99d73f5b65
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-04-25 06:47:21 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-04-25 06:50:12 +0000

    Revert "profiles: Mask net-im/zoom-5.14.5.2430-r1 for testing"
    
    This reverts commit c80b12101e3f997fcfdb738dcecb3a8174d94fae.
    
    Closes: https://bugs.gentoo.org/904958
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 profiles/package.mask | 4 ----
 1 file changed, 4 deletions(-)