By default app-office/sc-im permits a maximum of 65536 rows. This limit is hard coded at compile time by the -DMAXROWS cflag. This value can optionally be set as high as 1048576 — which would bring sc-im to row count parity with most other modern spreadsheet programs. Can we either make 1048576 the default in place of 65536 or add a new "max_rows" use flag here? Without this change some large spreadsheets will not load in sc-im.
Does this break some compatibility with older spread sheets? If now, I would recommend so set unconditionally the higher limit.
Does this break some compatibility with older spread sheets? If not, I would recommend so set unconditionally the higher limit.
Setting this value unconditionally won't break comparability with anything, it just allows sc-im to work with larger spreadsheets. Interoperability with ≤ 65536 row files is unchanged. This setting is just a vestige of the fact that sc-im is a 20 year old codebase. Twenty years ago system RAM was still measured in megabytes and most spreadsheets had a similar maximum value. Today, spreadsheets can get much larger than 65536 rows. I'm all for setting the value to 1048576 unconditionally if you're OK with it.
Since it doesn't have any cons, I've made this the default in the above pull request.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=64dca91e05079168e4f0ea3f51a5e051e480e6ef commit 64dca91e05079168e4f0ea3f51a5e051e480e6ef Author: Efe İzbudak <efe.izbudak@metu.edu.tr> AuthorDate: 2023-04-23 03:26:59 +0000 Commit: Conrad Kostecki <conikost@gentoo.org> CommitDate: 2023-04-23 12:28:35 +0000 app-office/sc-im: change max rows value The build flag -DMAXROWS used to set max rows have been changed to 1048576 to comply with modern standards. Closes: https://bugs.gentoo.org/904837 Signed-off-by: Efe İzbudak <efe.izbudak@metu.edu.tr> Closes: https://github.com/gentoo/gentoo/pull/30715 Signed-off-by: Conrad Kostecki <conikost@gentoo.org> app-office/sc-im/sc-im-0.8.3-r1.ebuild | 141 +++++++++++++++++++++++++++++++++ 1 file changed, 141 insertions(+)
