Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904517 - lua-single.eclass: LUA_SINGLE_TARGET should be set to a default value as PYTHON_SINGLE_TARGET
Summary: lua-single.eclass: LUA_SINGLE_TARGET should be set to a default value as PYTH...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-18 15:47 UTC by Pacho Ramos
Modified: 2023-04-19 12:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2023-04-18 15:47:28 UTC
Recently I got this error:
!!! The ebuild selected to satisfy "app-text/xournalpp" has unmet requirements.
- app-text/xournalpp-1.1.3-r1::gentoo USE="" ABI_X86="(64)" LUA_SINGLE_TARGET="-lua5-3 -lua5-4"

  The following REQUIRED_USE flag constraints are unsatisfied:
    exactly-one-of ( lua_single_target_lua5-3 lua_single_target_lua5-4 )

(dependency required by "@selected" [set])
(dependency required by "@world" [argument])

And I was surprised about me needing to manually set a value for every system I maintain... I think it should be handled as PYTHON_SINGLE_TARGET, that sets a default value that gets updates when maintainers think newer versions are stable enough

Thanks
Comment 1 Pacho Ramos gentoo-dev 2023-04-18 15:51:23 UTC
Mmm... it seems it is not like python case as I see many different packages needing a different single target :S

In that case maybe each package should default to a preferred lua version using +USE syntax :/
Comment 2 Marek Szuba archtester gentoo-dev 2023-04-18 15:54:29 UTC
I am pretty sure that DO set the default of LUA_SINGLE_TARGET - to the target which at least at the time of us having done it provided the greatest package coverage, i.e. lua5-1. Welcome to the Lua world, where in spite of having been EOLed upstream ages ago 5.1 simply will not die.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2023-04-18 16:37:58 UTC
The way targets are set is the same:
profiles/base/make.defaults currently contains:

PYTHON_TARGETS="python3_10"
PYTHON_SINGLE_TARGET="python3_10"
LUA_SINGLE_TARGET="lua5-1"
LUA_TARGETS="lua5-1"
Comment 4 Arfrever Frehtes Taifersar Arahesis 2023-04-18 16:50:02 UTC
Some solution might be:

1. Set LUA_SINGLE_TARGET="lua5-4" LUA_TARGETS="lua5-4" in make.defaults.

2. Add appropriate per-package lua_single_target_lua5-1 and/or lua_targets_lua5-1 entries in package.use.


Currently the inverse was done, but very incompletely:
In profiles/base/package.use:

>=app-editors/vis-0.7-r1 lua_single_target_lua5-4
>=sys-cluster/ceph-17.2.0 lua_single_target_lua5-4
>=app-arch/rpm-4.17.0 lua_single_target_lua5-4
media-video/wireplumber lua_single_target_lua5-4

Instead of having ever-growing list of ..._lua5-4 entries, I suggest to have initially bigger, gradually shrinking list of ..._lua5-1 entries in package.use.
Comment 5 Pacho Ramos gentoo-dev 2023-04-19 12:50:43 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #4)
> Some solution might be:
> 
> 1. Set LUA_SINGLE_TARGET="lua5-4" LUA_TARGETS="lua5-4" in make.defaults.

I tried that... but then I realized many other lua-single packages need other lua versions and does not work :/

> 
> 2. Add appropriate per-package lua_single_target_lua5-1 and/or
> lua_targets_lua5-1 entries in package.use.
> 
> 
> Currently the inverse was done, but very incompletely:
> In profiles/base/package.use:
> 
> >=app-editors/vis-0.7-r1 lua_single_target_lua5-4
> >=sys-cluster/ceph-17.2.0 lua_single_target_lua5-4
> >=app-arch/rpm-4.17.0 lua_single_target_lua5-4
> media-video/wireplumber lua_single_target_lua5-4

Ah... I guess then that xournalpp was forgotten there 

> 
> Instead of having ever-growing list of ..._lua5-4 entries, I suggest to have
> initially bigger, gradually shrinking list of ..._lua5-1 entries in
> package.use.

Yeah.. if more packages move to newer versions that would make sense :/
Comment 6 Larry the Git Cow gentoo-dev 2023-04-19 12:55:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4312ac55afc6750aaf12f3462c32bdcf78a902c0

commit 4312ac55afc6750aaf12f3462c32bdcf78a902c0
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2023-04-19 12:54:39 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-04-19 12:54:39 +0000

    profiles/base: latest xournalpp needs lua >= 5.3
    
    Bug: https://bugs.gentoo.org/904517
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 profiles/base/package.use | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)