Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904433 - app-containers/podman-4.4.0 or later shouldn't depend on app-containers/cni-plugins as app-containers/netavark replaces it
Summary: app-containers/podman-4.4.0 or later shouldn't depend on app-containers/cni-p...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 907805
Blocks:
  Show dependency tree
 
Reported: 2023-04-17 07:16 UTC by Rahil Bhimjiani
Modified: 2023-09-21 22:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rahil Bhimjiani 2023-04-17 07:16:10 UTC
Since 4.4.0 cni-plugins is deprecated and shouldn't be the hard dependency anymore
https://github.com/containers/podman/releases/tag/v4.4.0
Comment 1 Rahil Bhimjiani 2023-05-19 23:44:51 UTC
Please confirm if it has been fixed or not.
Comment 2 Zac Medico gentoo-dev 2023-05-22 15:07:15 UTC
I tested with podman-4.5.0, and it still defaults to using cni-plugins unless configured to use netavark in containers.conf like this:

[network]
network_backend = "netavark"

If cni-plugins is not installed, podman will fail to run unless it is configured like above. The ebuild dependencies accept netavark and aardvark-dns as an alternative to cni-plugins, but it's still the user's responsibility to configure network_backend to use netavark.
Comment 3 Rahil Bhimjiani 2023-05-25 04:05:33 UTC
So how do other distros list it as "optional" runtime dependency? 

Please take a look

https://packages.fedoraproject.org/pkgs/podman/podman/fedora-38-updates.html
https://archlinux.org/packages/extra/x86_64/podman/
https://packages.debian.org/experimental/podman

Thank you
Comment 4 Zac Medico gentoo-dev 2023-05-26 04:12:41 UTC
Here it says for network_backend:

> The default value is empty which means that it will automatically choose CNI or netavark.

I'll have to investigate to see why I did not observe this automatic behavior.
Comment 5 Zac Medico gentoo-dev 2023-05-26 04:13:43 UTC
This is where I found the network_backend documentation:

https://github.com/containers/common/blob/main/docs/containers.conf.5.md
Comment 6 Rahil Bhimjiani 2023-05-26 05:09:17 UTC
> CNI is being deprecated from Podman and support will be dropped at a future date. Netavark is now advised and is the default network backend for Podman.

https://github.com/containers/podman/releases/tag/v4.4.0

I just want gentoo to have same behaviour as other guys, if they're having it as optional dep so should we.

In my investigation Gentoo doesn't have "containers-common" (https://github.com/containers/common) package in tree, so it's not installed. That package provides default configs & documentation.
Comment 7 Larry the Git Cow gentoo-dev 2023-09-21 22:17:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2941140a0760ca358eecc44391a79479f024a3de

commit 2941140a0760ca358eecc44391a79479f024a3de
Author:     Rahil Bhimjiani <rahil3108@gmail.com>
AuthorDate: 2023-09-21 18:34:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-21 22:16:19 +0000

    app-containers/containers-common: add 0.56.0 and live
    
    Common configs & docs for Containers eco-system (i.e. podman buildah skopeo...)
    
    Go realm, executables are all in compiled, static, tidy in one binary but docs & configs...OMG all over the place. Spent whole day coding all these (such noob, I know), but was fun & fulfilling. Once this is merged the foundation of podman-stack is built, so will proceed to update frontend packages of eco-system.
    
    Closes: https://bugs.gentoo.org/907805
    Closes: https://bugs.gentoo.org/904433
    Closes: https://bugs.gentoo.org/914456
    Closes: https://bugs.gentoo.org/907804
    Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32976
    Signed-off-by: Sam James <sam@gentoo.org>

 app-containers/containers-common/Manifest          |    1 +
 .../containers-common-0.56.0.ebuild                |   76 ++
 .../containers-common-9999.ebuild                  |   76 ++
 .../containers-common/files/default.yaml           |   28 +
 .../containers-common/files/fix-warnings.patch     |   24 +
 app-containers/containers-common/files/mounts.conf |    3 +
 app-containers/containers-common/files/policy.json |   14 +
 .../containers-common/files/seccomp.json           | 1051 ++++++++++++++++++++
 app-containers/containers-common/metadata.xml      |   17 +
 9 files changed, 1290 insertions(+)