Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904381 - dev-qt/qtwebengine-5.15.9_p20230404[system-icu]: fails to compile with dev-libs/icu-73.1 (error: invalid conversion from ‘const UChar*’ {aka ‘const short unsigned int*’} to ‘const char16_t*’ [-fpermissive])
Summary: dev-qt/qtwebengine-5.15.9_p20230404[system-icu]: fails to compile with dev-li...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
: 904448 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-04-15 21:27 UTC by Chris Smith
Modified: 2023-05-10 22:01 UTC (History)
33 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (qtwebengine.log.xz,150.96 KB, application/x-xz)
2023-04-15 21:29 UTC, Chris Smith
Details
Patch against =dev-libs/icu-73.1 (icu-73.1-fix-compilation-of-user-code-with-uchar-override.patch,1.76 KB, patch)
2023-04-16 11:12 UTC, Sven Hesse
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Smith 2023-04-15 21:27:13 UTC
qtwebengine-5.15.9_p20230404 fails to compile
possibly related to the upgrade to icu-73.1?



Reproducible: Always

Actual Results:  
In file included from /usr/include/unicode/timezone.h:45,
                 from /usr/include/unicode/calendar.h:42,
                 from /usr/include/unicode/dtfmtsym.h:29,
                 from ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/v8/src/objects/js-display-name
s.cc:21:
/usr/include/unicode/ures.h: In function ‘icu::UnicodeString icu::ures_getUnicodeString(const UResourceBundle*, UErrorCode*)’:
/usr/include/unicode/ures.h:815:39: error: invalid conversion from ‘const UChar*’ {aka ‘const short unsigned int*’} to ‘const char16_t*’ [-fpermissive]
  815 |     const char16_t *r = ures_getString(resB, &len, status);
      |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
      |                                       |
      |                                       const UChar* {aka const short unsigned int*}
/usr/include/unicode/ures.h: In function ‘icu::UnicodeString icu::ures_getNextUnicodeString(UResourceBundle*, const char**, UErrorCode*)’:
/usr/include/unicode/ures.h:840:43: error: invalid conversion from ‘const UChar*’ {aka ‘const short unsigned int*’} to ‘const char16_t*’ [-fpermissive]
  840 |     const char16_t* r = ures_getNextString(resB, &len, key, status);
      |                         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           |
      |                                           const UChar* {aka const short unsigned int*}
/usr/include/unicode/ures.h: In function ‘icu::UnicodeString icu::ures_getUnicodeStringByIndex(const UResourceBundle*, int32_t, UErrorCode*)’:
/usr/include/unicode/ures.h:862:46: error: invalid conversion from ‘const UChar*’ {aka ‘const short unsigned int*’} to ‘const char16_t*’ [-fpermissive]
  862 |     const char16_t* r = ures_getStringByIndex(resB, indexS, &len, status);
      |                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                              |
      |                                              const UChar* {aka const short unsigned int*}
/usr/include/unicode/ures.h: In function ‘icu::UnicodeString icu::ures_getUnicodeStringByKey(const UResourceBundle*, const char*, UErrorCode*)’:
/usr/include/unicode/ures.h:885:44: error: invalid conversion from ‘const UChar*’ {aka ‘const short unsigned int*’} to ‘const char16_t*’ [-fpermissive]
  885 |     const char16_t* r = ures_getStringByKey(resB, key, &len, status);
      |                         ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                            |
      |                                            const UChar* {aka const short unsigned int*}
ninja: build stopped: subcommand failed.


emerge --info
Portage 3.0.46 (python 3.10.11-final-0, default/linux/amd64/17.1/desktop/plasma/systemd/merged-usr, gcc-12, glibc-2.37-r2, 6.2.11-gentoo x86_64)
=================================================================
System uname: Linux-6.2.11-gentoo-x86_64-AMD_Ryzen_9_5900X_12-Core_Processor-with-glibc2.37
KiB Mem:    65787340 total,   9639276 free
KiB Swap:    6291452 total,   6275724 free
Timestamp of repository gentoo: Sat, 15 Apr 2023 18:46:55 +0000
Head commit of repository gentoo: 35dc02091b78e067e469bddf8485f76e72db1f30

Head commit of repository audio-overlay: 1c9f55a7270cc6780bbe67113ac363ac6b428c69

sh bash 5.2_p15-r2
ld GNU ld (Gentoo 2.40 p4) 2.40.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0-r2::gentoo
dev-lang/python:           3.10.11::gentoo, 3.11.3::gentoo
dev-lang/rust:             1.68.2::gentoo
dev-util/cmake:            3.26.3::gentoo
dev-util/meson:            1.0.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-apps/systemd:          253.3::gentoo
sys-devel/autoconf:        2.71-r6::gentoo
sys-devel/automake:        1.16.5-r1::gentoo
sys-devel/binutils:        2.40-r4::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/gcc:             12.2.1_p20230304::gentoo
sys-devel/gcc-config:      2.10::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/llvm:            16.0.1::gentoo
sys-devel/make:            4.4.1::gentoo
sys-kernel/linux-headers:  6.2::gentoo (virtual/os-headers)
sys-libs/glibc:            2.37-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/sync/gentoo.git
    priority: -1000
    volatile: False

audio-overlay
    location: /var/db/repos/audio-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-audio/audio-overlay.git
    masters: gentoo
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    volatile: False

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
AR="ar"
CBUILD="x86_64-pc-linux-gnu"
CC="gcc"
CFLAGS="-O2 -march=native -fomit-frame-pointer -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d"
CXX="g++"
CXXFLAGS="-O2 -march=native -fomit-frame-pointer -pipe"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --autounmask-keep-masks"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.osuosl.org/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O2 -Wl,--as-needed"
LEX="flex"
LINGUAS="en_US en"
MAKEOPTS="V=1 -j1"
NM="nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="ranlib"
SHELL="/bin/bash"
USE="X a52 aac aalib acl acpi activities alsa amd64 amr apache2 audiofile bash-completion bluray branding btrfs bzip2 cairo caps cdaudio cdda cddb cdparanoia cdr cdrdao chm chromecast cleartype cli colord corefonts crypt cups curl dbus declarative djvu dri dssi dts dv dvb dvd dvdr ebook egl encode exif fam fdk ffmpeg flac fortran gdbm gif gmp google gphoto2 gpm gstreamer gtk gtk3 gtk4 gui iconv icu imagemagick imap imlib introspection ipod ipv6 jack java jpeg jpeg2k kde kpathsea kvm kwallet ladspa lame lash lcms libffi libglvnd libinput libnotify libtirpc linguas_en_US lm-sensors lv2 lvm lzma mad marble midi mmap mng mozilla mp3 mp4 mpeg mtp multimedia musicbrainz ncurses network nls nodrm nptl nsplugin ofx ogg opencl openexr opengl openmp opus pam pango pcre pdf pipewire pipewire-alsa plasma png policykit ppds pulseaudio qemu qml qt5 readline rtmp rust sasl scanner screencast sdl seccomp semantic-desktop slp smp sndfile sound speex spell ssl startup-notification subversion svg systemd test-rust theora threads tiff tk transparency truetype type1 udev udisks unicode unwind upower usb v4l vaapi vcd vdpau vim-syntax vorbis vpx vst wav wavpack wayland webp widgets wmf wxwidgets x264 x265 xattr xcb xcomposite xft xine xkb xml xscreensaver xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" NGINX_MODULES_HTTP="autoindex fancyindex fastcgi gzip" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" QEMU_SOFTMMU_TARGETS="x86_64" QEMU_USER_TARGETS="x86_64" RUBY_TARGETS="(-ruby27) (-ruby30) ruby31 ruby32" SANE_BACKENDS="epson epson2" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Chris Smith 2023-04-15 21:29:29 UTC
Created attachment 860171 [details]
build log
Comment 2 Sven Hesse 2023-04-15 22:43:53 UTC
Seems to be related to =dev-libs/icu-73.1 , and this change in ICU:
https://github.com/unicode-org/icu/commit/2de88f9d9c07f7e693449f94858d96053222acea
https://unicode-org.atlassian.net/browse/ICU-21833

2de88f9 in ICU changes UChar* to char16_t* ures.h, but qtwebengine wants to compile with -DUCHAR_TYPE=uint16_t. Looks like a valid compiler error to me, that needs at least a cast.

Interestingly, the issue in ICU says that C header files are supposed to stay untouched, but ures.h clearly is a C header file.
Comment 3 Stephan Hartmann (RETIRED) gentoo-dev 2023-04-16 09:35:37 UTC
Overriding UCHAR_TYPE was removed long time ago, see https://crrev.com/c/2830820.
Comment 4 Sven Hesse 2023-04-16 11:12:11 UTC
Created attachment 860182 [details, diff]
Patch against =dev-libs/icu-73.1

With this as a user-patch to =dev-libs/icu-73.1 and re-emerging icu, qtwebengine compiles again. But I have no evaluated in depth, if the change has any more consequences.

And especially if overriding UChar isn't wanted anymore, this is more of a very temporary patch.
Comment 5 he.ousia 2023-04-16 18:57:24 UTC
Patch works ok with gcc-13.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-17 10:29:49 UTC
*** Bug 904448 has been marked as a duplicate of this bug. ***
Comment 7 Gary E. Miller 2023-04-18 01:43:06 UTC
Same problem for me.
Comment 8 Larry the Git Cow gentoo-dev 2023-04-18 02:12:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a5db7fc59b5ff77e2cf44f51784ed4e87aeab5b

commit 5a5db7fc59b5ff77e2cf44f51784ed4e87aeab5b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-18 02:11:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-18 02:12:00 +0000

    dev-libs/icu: fix builds w/ UCHAR_TYPE set
    
    Closes: https://bugs.gentoo.org/904381
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/icu/files/icu-73.1-fix-UChar-api.patch |  49 +++++++
 dev-libs/icu/icu-73.1-r1.ebuild                 | 163 ++++++++++++++++++++++++
 2 files changed, 212 insertions(+)
Comment 9 Larry the Git Cow gentoo-dev 2023-05-10 22:01:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=004077eb58c061c1b39ada2654cc409e91fac2de

commit 004077eb58c061c1b39ada2654cc409e91fac2de
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-10 21:40:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-10 21:41:15 +0000

    dev-libs/icu: switch to upstream variant of UChar patch
    
    Closes: https://bugs.gentoo.org/904381
    Signed-off-by: Sam James <sam@gentoo.org>

 .../icu/files/icu-73.1-fix-UChar-api-deux.patch    |  82 +++++++++++
 dev-libs/icu/icu-73.1-r2.ebuild                    | 163 +++++++++++++++++++++
 2 files changed, 245 insertions(+)