Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 903666 - app-portage/java-ebuilder: Should support multi-line MAVEN_PROVIDES values
Summary: app-portage/java-ebuilder: Should support multi-line MAVEN_PROVIDES values
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 903667
  Show dependency tree
 
Reported: 2023-04-01 17:11 UTC by Yuan Liao (Leo3418)
Modified: 2023-04-15 08:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuan Liao (Leo3418) 2023-04-01 17:11:17 UTC
Currently, java-ebuilder does not support MAVEN_PROVIDES values that span across multiple lines, like:

    MAVEN_PROVIDES="
    	org.ow2.asm:asm-bom:9.4
    	org.ow2.asm:asm:9.4
    "

As of version 0.5.1, the PortageParser class of java-ebuilder reads an input ebuild line by line, and when it finds a line that starts with 'MAVEN_PROVIDES=', it parses only that line without looking at more lines ahead, thus it does not support multi-line MAVEN_PROVIDES values.  See line 307 of PortageParser.java for more details.

When an ebuild installs JAR files for more than one Maven artifact, the ebuild should define MAVEN_PROVIDES instead of MAVEN_ID to list these artifacts (MAVEN_ID is just for a single artifact).  If a single ebuild installs a lot of artifacts (e.g. dev-java/junit-5.9.2, which installs at least 8), then the value of MAVEN_PROVIDES would be an extremely long single-line string, unless java-ebuilder supports multi-line MAVEN_PROVIDES values.
Comment 1 Larry the Git Cow gentoo-dev 2023-04-15 08:14:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/java-ebuilder.git/commit/?id=3dc12a1cf977e05cd3ff4ef0c61267c5e4abf395

commit 3dc12a1cf977e05cd3ff4ef0c61267c5e4abf395
Author:     Yuan Liao <liaoyuan@gmail.com>
AuthorDate: 2021-06-11 20:52:25 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-04-15 08:13:52 +0000

    Add support for multi-line MAVEN_PROVIDES definition
    
    Closes: https://bugs.gentoo.org/903666
    Signed-off-by: Yuan Liao <liaoyuan@gmail.com>
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../java/ebuilder/portage/PortageParser.java       | 81 ++++++++++++++--------
 1 file changed, 52 insertions(+), 29 deletions(-)