Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 903197 - sys-devel/clang-runtime: riscv: sys-libs/compiler-rt-sanitizers REQUIRED_USE flag constraints are unsatisfied
Summary: sys-devel/clang-runtime: riscv: sys-libs/compiler-rt-sanitizers REQUIRED_USE ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: LLVM support project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-03-27 14:49 UTC by jinqiang zhang
Modified: 2023-03-27 19:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
info.txt (info.txt,6.47 KB, text/plain)
2023-03-27 14:57 UTC, jinqiang zhang
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jinqiang zhang 2023-03-27 14:49:34 UTC
sys-libs/compiler-rt-sanitizers on riscv is unable to merge:

!!! The ebuild selected to satisfy "sys-libs/compiler-rt-sanitizers" has unmet requirements.
- sys-libs/compiler-rt-sanitizers-16.0.0::gentoo USE="clang (-asan) (-cfi) -debug (-dfsan) (-gwp-asan) (-hwasan) (-libfuzzer) (-lsan) (-memprof) (-msan) (-orc) (-profile) (-safestack) (-scudo) (-shadowcallstack) -test (-tsan) (-ubsan) -verify-sig (-xray)"

  The following REQUIRED_USE flag constraints are unsatisfied:
    any-of ( asan dfsan lsan msan hwasan tsan ubsan safestack cfi scudo shadowcallstack gwp-asan libfuzzer orc profile xray )

  The above constraints are a subset of the following complete expression:
    any-of ( asan dfsan lsan msan hwasan tsan ubsan safestack cfi scudo shadowcallstack gwp-asan libfuzzer orc profile xray ) test? ( cfi? ( ubsan ) gwp-asan? ( scudo ) )
Comment 1 jinqiang zhang 2023-03-27 14:50:26 UTC
It looks like all uses are masked, I think we can at least unmask one of them?

profiles/arch/base/package.use.mask
# Michał Górny <mgorny@gentoo.org> (2020-12-21)
# Mask all sanitizers by default, unmask on arches supporting them.
sys-libs/compiler-rt-sanitizers asan dfsan lsan msan hwasan tsan
sys-libs/compiler-rt-sanitizers ubsan safestack cfi scudo
sys-libs/compiler-rt-sanitizers shadowcallstack gwp-asan
sys-libs/compiler-rt-sanitizers libfuzzer memprof orc profile xray

profiles/arch/riscv/parent
../base
Comment 2 jinqiang zhang 2023-03-27 14:57:50 UTC
Created attachment 859091 [details]
info.txt

emerge --info
Comment 3 jinqiang zhang 2023-03-27 15:08:01 UTC
I probably don't actually need sys-libs/compiler-rt-sanitizers , this issue was introduced by removing "sys-devel/clang-runtime sanitize" mask , we should put it back.

https://github.com/gentoo-mirror/gentoo/commit/d8859162a5e027d6a3bf4bd17ec5ee6a271181c3#diff-dcaeb52650ac116888d6ae1c5476b7a18242c3f95ff710618397ee01064f3443
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-27 15:18:23 UTC
(In reply to jinqiang zhang from comment #3)
> I probably don't actually need sys-libs/compiler-rt-sanitizers , this issue
> was introduced by removing "sys-devel/clang-runtime sanitize" mask , we
> should put it back.
> 
> https://github.com/gentoo-mirror/gentoo/commit/
> d8859162a5e027d6a3bf4bd17ec5ee6a271181c3#diff-
> dcaeb52650ac116888d6ae1c5476b7a18242c3f95ff710618397ee01064f3443

It's better to unmask things where appropriate than put the mask back if it's not needed.
Comment 5 jinqiang zhang 2023-03-27 18:44:13 UTC
(In reply to Sam James from comment #4)
> 
> It's better to unmask things where appropriate than put the mask back if
> it's not needed.

I saw upstream already supports asan (since 12.0.0) lsan (since 13.0.0) on riscv, I will create a pull request to unmask them :D

asan: https://reviews.llvm.org/D87580
lsan: https://reviews.llvm.org/D92403
Comment 6 Larry the Git Cow gentoo-dev 2023-03-27 19:46:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e383a9e4e375726b83ebc51f1cbc3e5b29be5708

commit e383a9e4e375726b83ebc51f1cbc3e5b29be5708
Author:     jinqiang zhang <peeweep@0x0.ee>
AuthorDate: 2023-03-27 18:45:42 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2023-03-27 19:46:18 +0000

    profiles/arch/riscv: unmask sys-libs/compiler-rt-sanitizers USE
    
    Closes: https://bugs.gentoo.org/903197
    Signed-off-by: jinqiang zhang <peeweep@0x0.ee>
    Closes: https://github.com/gentoo/gentoo/pull/30372
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 profiles/arch/riscv/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)