Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 903189 - sys-apps/xdg-desktop-portal-gnome-44.0[-wayland]: does not build (warning: implicit declaration of function ‘init_external_window_wayland_display’; did you mean ‘init_external _window_x11_display’? [-Wimplicit-function-declaration])
Summary: sys-apps/xdg-desktop-portal-gnome-44.0[-wayland]: does not build (warning: im...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/xdg-de...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-27 11:54 UTC by Christian Bricart
Modified: 2023-03-29 11:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,89.27 KB, text/x-log)
2023-03-27 11:56 UTC, Christian Bricart 		Details
emerge --info (emerge-info.txt,9.56 KB, text/plain)
2023-03-27 11:58 UTC, Christian Bricart 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Bricart 2023-03-27 11:54:47 UTC 
(using USE=-wayland system-wide)

despite USE=-wayland, >=sys-apps/xdg-desktop-portal-gnome-44 tries to reference Wayland specifics from GTK4, which also have been merged with USE=-wayland and hence is lacking anything Wayland specific.

../xdg-desktop-portal-gnome-44.0/src/externalwindow.c: In function ‘init_external_window_display’:
../xdg-desktop-portal-gnome-44.0/src/externalwindow.c:94:12: warning: implicit declaration of function ‘init_external_window_wayland_display’; did you mean ‘init_external
_window_x11_display’? [-Wimplicit-function-declaration]
   94 |     return init_external_window_wayland_display (error);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |            init_external_window_x11_display
../xdg-desktop-portal-gnome-44.0/src/externalwindow.c:94:12: warning: returning ‘int’ from a function with return type ‘GdkDisplay *’ {aka ‘struct _GdkDisplay *’} makes p
ointer from integer without a cast [-Wint-conversion]
   94 |     return init_external_window_wayland_display (error);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-27 11:56:24 UTC 
Please always include the full build.log and emerge --info.
Comment 2 Christian Bricart 2023-03-27 11:56:40 UTC 
Created attachment 859087 [details]
build.log
Comment 3 Christian Bricart 2023-03-27 11:58:11 UTC 
Created attachment 859089 [details]
emerge --info
Comment 4 ivan.mrva 2023-03-28 12:14:14 UTC 
I can confirm the exactly same error on my side as well.
Comment 5 Matt Turner gentoo-dev 2023-03-28 14:05:11 UTC 
> (using USE=-wayland system-wide)

did you at one point have gtk built with USE=wayland?
Comment 6 Matt Turner gentoo-dev 2023-03-28 14:24:29 UTC 
(In reply to Matt Turner from comment #5)
> > (using USE=-wayland system-wide)
> 
> did you at one point have gtk built with USE=wayland?

Just a data point: USE=-wayland emerge xdg-desktop-portal-gnome works here with USE=wayland system-wide.
Comment 7 Larry the Git Cow gentoo-dev 2023-03-28 20:50:44 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47a3d74dc5c3f919f857429dbbc95a11c1496fdf

commit 47a3d74dc5c3f919f857429dbbc95a11c1496fdf
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-03-28 20:50:16 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-03-28 20:50:16 +0000

    sys-apps/xdg-desktop-portal-gnome: fix USE="-wayland" build
    
    Closes: https://bugs.gentoo.org/903189
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../xdg-desktop-portal-gnome-44.0-x11-only.patch   | 36 ++++++++++++++++++++++
 .../xdg-desktop-portal-gnome-44.0.ebuild           |  6 ++++
 2 files changed, 42 insertions(+)
Comment 8 Christian Bricart 2023-03-29 06:33:08 UTC 
thanks for the fix - confirm it works

however, this backport patch would also have to be added to =sys-apps/xdg-desktop-portal-gnome-44_rc ebuild while it still is in the tree.