Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 902009 - sys-apps/ucspi-tcp-0.88-r19: sed: can't read make-makelib.sh: No such file or directory
Summary: sys-apps/ucspi-tcp-0.88-r19: sed: can't read make-makelib.sh: No such file or...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PullRequest
: 902013 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-18 09:51 UTC by Eric Stein
Modified: 2023-04-04 09:02 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sys-apps/ucspi-tcp build.log (build.log,6.38 KB, text/x-log)
2023-03-18 09:51 UTC, Eric Stein
Details
emerge --info (emerge_info.txt,6.80 KB, text/plain)
2023-03-18 09:52 UTC, Eric Stein
Details
Patches qmail.eclass to allow qmail_set_cc wihtout make-makelib.sh (qmail.eclass_solves-packages-without-make-makelib-sh.patch,1.19 KB, patch)
2023-03-19 20:35 UTC, Eric Stein
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Stein 2023-03-18 09:51:54 UTC
Created attachment 858167 [details]
sys-apps/ucspi-tcp build.log

sys-apps/ucspi-tcp-0.88  fails to build after qmail.eclass introduces `|| die` in qmail_set_cc().
ucspi-tcp has no make-makelib.sh, but a Makefile where AR and RANLIB are set by ?=.

These variables could be set in the environment and only the first part in qmail_set_cc is needed.

My best idea is to guard the sed command in qmail_set_cc, to only run if make-makelib.sh exists and set AR and RANLIB in the ebuild.
Comment 1 Eric Stein 2023-03-18 09:52:55 UTC
Created attachment 858169 [details]
emerge --info
Comment 2 Alexander Puchmayr 2023-03-19 09:30:54 UTC
Same here. sys-apps/ucspi-tcp-0.88-r19, portage tree just fetched minutes ago.
Comment 3 Cyp 2023-03-19 13:48:17 UTC
Same here. Probably duplicate with bug 902013.
Comment 4 Toralf Förster gentoo-dev 2023-03-19 14:06:49 UTC
*** Bug 902013 has been marked as a duplicate of this bug. ***
Comment 5 Eric Stein 2023-03-19 20:35:13 UTC
Created attachment 858409 [details, diff]
Patches qmail.eclass to allow qmail_set_cc wihtout make-makelib.sh

There has been some discussion at https://github.com/gentoo/gentoo/pull/30205.

A guard around the sed, which changes make-makelib.sh, seems to be reasonable.
Comment 6 Agostino Sarubbo gentoo-dev 2023-03-20 08:35:15 UTC
ci has reproduced this issue with version 0.88-r19 - Updating summary.
Comment 7 Larry the Git Cow gentoo-dev 2023-04-04 09:02:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6aff85369909ec04e1370741a006d65ca3827a01

commit 6aff85369909ec04e1370741a006d65ca3827a01
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2023-04-03 11:14:21 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-04-04 09:01:43 +0000

    qmail.eclass: Patch make-makelib.sh only if it is present
    
    Some packages use qmail_set_cc function but they don't contain
    make-makelib.sh script. However, recent addition of || die to the sed
    patching this file is newly triggering build failure. This commit
    addresses the problem by checking if the script is available.
    
    Closes: https://bugs.gentoo.org/902009
    Closes: https://bugs.gentoo.org/902019
    Fixes: fd4e88c55e34 ("qmail.eclass: remove EAPI 6")
    Closes: https://github.com/gentoo/gentoo/pull/30456
    Closes: https://github.com/gentoo/gentoo/pull/30205
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 eclass/qmail.eclass | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)